Skip to content

Commit 0c9d59b

Browse files
hdikemanfacebook-github-bot
authored andcommitted
refactor: Remove deprecated code from velox/type/parser/ (facebookincubator#16219)
Summary: Since this type parsing was Presto-specific, it was moved to `velox/functions/prestosql/types/parser`, with this copy kept for backwards compatibility. Since there are no more usages in Presto, this backwards-compatibility API can be removed Reviewed By: HeidiHan0000 Differential Revision: D92076263
1 parent 165fe36 commit 0c9d59b

File tree

11 files changed

+2
-1284
lines changed

11 files changed

+2
-1284
lines changed

velox/exec/fuzzer/VeloxQueryRunner.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
#include "velox/functions/prestosql/types/IPPrefixType.h"
3131
#include "velox/functions/prestosql/types/TimestampWithTimeZoneType.h"
3232
#include "velox/functions/prestosql/types/UuidType.h"
33+
#include "velox/functions/prestosql/types/parser/TypeParser.h"
3334
#include "velox/serializers/PrestoSerializer.h"
34-
#include "velox/type/parser/TypeParser.h"
3535

3636
using namespace facebook::velox::runner;
3737

@@ -64,7 +64,7 @@ RowTypePtr parseBatchRowType(Batch batch) {
6464
std::replace(parsedTypeString.begin(), parsedTypeString.end(), '<', '(');
6565
std::replace(parsedTypeString.begin(), parsedTypeString.end(), '>', ')');
6666
std::replace(parsedTypeString.begin(), parsedTypeString.end(), ':', ' ');
67-
types.push_back(parseType(parsedTypeString));
67+
types.push_back(functions::prestosql::parseType(parsedTypeString));
6868
}
6969

7070
return ROW(std::move(names), std::move(types));

velox/type/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ if(${VELOX_BUILD_TESTING})
1515
add_subdirectory(tests)
1616
endif()
1717

18-
add_subdirectory(parser)
1918
add_subdirectory(tz)
2019
add_subdirectory(fbhive)
2120

velox/type/parser/CMakeLists.txt

Lines changed: 0 additions & 50 deletions
This file was deleted.

velox/type/parser/ParserUtil.cpp

Lines changed: 0 additions & 198 deletions
This file was deleted.

velox/type/parser/ParserUtil.h

Lines changed: 0 additions & 53 deletions
This file was deleted.

velox/type/parser/Scanner.h

Lines changed: 0 additions & 60 deletions
This file was deleted.

0 commit comments

Comments
 (0)