Skip to content

Commit 3818dd1

Browse files
hdikemanfacebook-github-bot
authored andcommitted
refactor(connector): Deprecate unused options from HiveConfig
Summary: These options were added usage in an external repository, and not actually used within Velox. That external dependency is being moved to a separate configuration object, so these options can be deprecated Differential Revision: D91282774
1 parent 0cd99c6 commit 3818dd1

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

velox/connectors/hive/HiveConfig.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -244,14 +244,6 @@ bool HiveConfig::readStatsBasedFilterReorderDisabled(
244244
config_->get<bool>(kReadStatsBasedFilterReorderDisabled, false));
245245
}
246246

247-
std::string HiveConfig::hiveLocalDataPath() const {
248-
return config_->get<std::string>(kLocalDataPath, "");
249-
}
250-
251-
std::string HiveConfig::hiveLocalFileFormat() const {
252-
return config_->get<std::string>(kLocalFileFormat, "");
253-
}
254-
255247
bool HiveConfig::preserveFlatMapsInMemory(
256248
const config::ConfigBase* session) const {
257249
return session->get<bool>(

velox/connectors/hive/HiveConfig.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -194,9 +194,6 @@ class HiveConfig {
194194
static constexpr const char* kReadStatsBasedFilterReorderDisabledSession =
195195
"stats_based_filter_reorder_disabled";
196196

197-
static constexpr const char* kLocalDataPath = "hive_local_data_path";
198-
static constexpr const char* kLocalFileFormat = "hive_local_file_format";
199-
200197
/// Whether to preserve flat maps in memory as FlatMapVectors instead of
201198
/// converting them to MapVectors.
202199
static constexpr const char* kPreserveFlatMapsInMemory =
@@ -283,15 +280,6 @@ class HiveConfig {
283280
bool readStatsBasedFilterReorderDisabled(
284281
const config::ConfigBase* session) const;
285282

286-
/// Returns the file system path containing local data. If non-empty,
287-
/// initializes LocalHiveConnectorMetadata to provide metadata for the tables
288-
/// in the directory.
289-
std::string hiveLocalDataPath() const;
290-
291-
/// Returns the name of the file format to use in interpreting the contents of
292-
/// hiveLocalDataPath().
293-
std::string hiveLocalFileFormat() const;
294-
295283
/// Whether to preserve flat maps in memory as FlatMapVectors instead of
296284
/// converting them to MapVectors.
297285
bool preserveFlatMapsInMemory(const config::ConfigBase* session) const;

0 commit comments

Comments
 (0)