pass configuration from Connector to ConnectorMetadata for all connectors

Summary:
We want to integrate existing configuration systems (TW and defined config attributes) with ConnectorMetadata

There are quite a few configuration values which we have deferred for lack of support

In this change I am ensuring that Hive (and by extension Prism and LocalHive), Impulse, TPCH, and the Test ConnectorMetadata store a reference to the corresponding Connector configuration

Differential Revision: D81365452

Author: hdikeman

velox/connectors/tpch/TpchConnector.cpp

@@ -35,7 +35,7 @@ TpchConnector::TpchConnector(
     const std::string& id,
     std::shared_ptr<const config::ConfigBase> config,
     folly::Executor* /*executor*/)
-    : Connector(id) {
+    : Connector(id), config_(std::move(config)) {
   for (auto& factory : tpchConnectorMetadataFactories()) {
     metadata_ = factory->create(this);
     if (metadata_ != nullptr) {

velox/connectors/tpch/TpchConnector.h

@@ -163,6 +163,11 @@ class TpchConnector final : public Connector {
       std::shared_ptr<const config::ConfigBase> config,
       folly::Executor* /*executor*/);
 
+  const std::shared_ptr<const config::ConfigBase>& connectorConfig()
+      const override {
+    return config_;
+  }
+
   std::unique_ptr<DataSource> createDataSource(
       const RowTypePtr& outputType,
       const ConnectorTableHandlePtr& tableHandle,
@@ -186,6 +191,7 @@ class TpchConnector final : public Connector {
   }
 
  private:
+  std::shared_ptr<const config::ConfigBase> config_;
   std::shared_ptr<ConnectorMetadata> metadata_;
 };
 

velox/connectors/tpch/tests/TpchConnectorTest.cpp

@@ -443,6 +443,22 @@ TEST_F(TpchConnectorTest, orderDateCount) {
   EXPECT_EQ(9, orderDate->size());
 }
 
+TEST_F(TpchConnectorTest, config) {
+  std::unordered_map<std::string, std::string> properties = {
+      {"property", "value"}};
+  auto connector =
+      connector::getConnectorFactory(
+          connector::tpch::TpchConnectorFactory::kTpchConnectorName)
+          ->newConnector(
+              kTpchConnectorId,
+              std::make_shared<config::ConfigBase>(std::move(properties)));
+
+  const auto& config = connector->connectorConfig();
+  auto val = config->get<std::string>("property");
+  EXPECT_TRUE(val.has_value());
+  EXPECT_EQ(val.value(), "value");
+}
+
 } // namespace
 
 int main(int argc, char** argv) {