Breaking NBA API changes

Author: hdurix-tech

.gitignore

@@ -25,6 +25,7 @@ npm-debug.log.*
 
 ### IntelliJ IDEA ###
 .idea
+.run
 *.iws
 *.iml
 *.ipr

src/main/java/fr/hippo/nbastats/infrastructure/secondary/api/ApiCard.java

@@ -0,0 +1,14 @@
+package fr.hippo.nbastats.infrastructure.secondary.api;
+
+class ApiCard {
+
+    private ApiScoreboardGame cardData;
+
+    public ApiScoreboardGame getCardData() {
+        return cardData;
+    }
+
+    public void setCardData(ApiScoreboardGame cardData) {
+        this.cardData = cardData;
+    }
+}

src/main/java/fr/hippo/nbastats/infrastructure/secondary/api/ApiModule.java

@@ -0,0 +1,16 @@
+package fr.hippo.nbastats.infrastructure.secondary.api;
+
+import java.util.Collection;
+
+class ApiModule {
+
+    private Collection<ApiCard> cards;
+
+    public Collection<ApiCard> getCards() {
+        return cards;
+    }
+
+    public void setCards(Collection<ApiCard> cards) {
+        this.cards = cards;
+    }
+}

src/main/java/fr/hippo/nbastats/infrastructure/secondary/api/ApiScoreboard.java

@@ -1,16 +1,20 @@
 package fr.hippo.nbastats.infrastructure.secondary.api;
 
 import java.util.Collection;
+import java.util.stream.Collectors;
 
 class ApiScoreboard {
 
-    private Collection<ApiScoreboardGame> games;
+    private Collection<ApiModule> modules;
 
-    public Collection<ApiScoreboardGame> getGames() {
-        return games;
+    public void setModules(Collection<ApiModule> modules) {
+        this.modules = modules;
     }
 
-    public void setGames(Collection<ApiScoreboardGame> games) {
-        this.games = games;
+    public Collection<ApiScoreboardGame> getGames() {
+        return modules.stream()
+            .flatMap(module -> module.getCards().stream())
+            .map(ApiCard::getCardData)
+            .collect(Collectors.toList());
     }
 }

src/main/java/fr/hippo/nbastats/infrastructure/secondary/api/ApiScoreboardGame.java

@@ -3,7 +3,6 @@
 class ApiScoreboardGame {
 
     private String gameId;
-    private String gameCode;
     private int gameStatus;
     private ApiScoreboardTeam homeTeam;
     private ApiScoreboardTeam awayTeam;
@@ -16,14 +15,6 @@ public void setGameId(String gameId) {
         this.gameId = gameId;
     }
 
-    public String getGameCode() {
-        return gameCode;
-    }
-
-    public void setGameCode(String gameCode) {
-        this.gameCode = gameCode;
-    }
-
     public int getGameStatus() {
         return gameStatus;
     }

src/main/java/fr/hippo/nbastats/infrastructure/secondary/api/ApiScoreboardWrapper.java

@@ -1,25 +1,29 @@
 package fr.hippo.nbastats.infrastructure.secondary.api;
 
-import java.time.LocalDate;
 import org.springframework.http.HttpEntity;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpMethod;
 import org.springframework.stereotype.Repository;
 import org.springframework.web.client.RestTemplate;
 
+import java.time.LocalDate;
+import java.time.format.DateTimeFormatter;
+
 @Repository
 class ApiScoreboards {
 
+    private static final DateTimeFormatter DATE_FORMATTER = DateTimeFormatter.ofPattern("MM/dd/yyyy");
+
     private final RestTemplate rest;
 
     ApiScoreboards(RestTemplate rest) {
         this.rest = rest;
     }
 
     ApiScoreboard forDate(LocalDate date) {
-        String url = "https://stats.nba.com/stats/scoreboardv3?LeagueID=00&GameDate=" + date;
+        String url = "https://core-api.nba.com/cp/api/v1.9/feeds/gamecardfeed?gamedate=" + date.format(DATE_FORMATTER) + "&platform=web";
 
-        return rest.exchange(url, HttpMethod.GET, entityWithNbaHeaders(), ApiScoreboardWrapper.class).getBody().getScoreboard();
+        return rest.exchange(url, HttpMethod.GET, entityWithNbaHeaders(), ApiScoreboard.class).getBody();
     }
 
     public ApiBoxscoreGame boxscoreForGame(String gameId) {
@@ -33,6 +37,7 @@ private static HttpEntity<Void> entityWithNbaHeaders() {
         headers.set("Origin", "https://www.nba.com/");
         headers.set("Referer", "https://www.nba.com/");
         headers.set("User-Agent", "Mozilla/5.0 (X11; Linux x86_64)");
+        headers.set("ocp-apim-subscription-key", "747fa6900c6c4e89a58b81b72f36eb96");
 
         return new HttpEntity<>(headers);
     }

src/main/java/fr/hippo/nbastats/infrastructure/secondary/api/ApiScoreboards.java

@@ -121,7 +121,7 @@ private ApiBoxscoreGame getBoxscoreGame() throws IOException {
     }
 
     private ApiScoreboardGame getScoreboardGame() throws IOException {
-        return JsonHelper.readFromJson(defaultScoreboardJson(), ApiScoreboardWrapper.class).getScoreboard().getGames().iterator().next();
+        return JsonHelper.readFromJson(defaultScoreboardJson(), ApiScoreboard.class).getGames().iterator().next();
     }
 
     private String defaultBoxscoreJson() throws IOException {

src/test/java/fr/hippo/nbastats/infrastructure/secondary/api/ApiNbaGameConverterUnitTest.java

@@ -5,7 +5,6 @@
 
 import fr.hippo.nbastats.domain.GameStatUnitTest;
 import java.time.LocalDate;
-import java.time.format.DateTimeFormatter;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -34,15 +33,15 @@ class ApiNbaGamesUnitTest {
     @BeforeEach
     private void mockScoreboard() {
         LocalDate yesterday = LocalDate.now().minusDays(1);
-        when(scoreboards.forDate(yesterday)).thenReturn(buildScoreboard(game("01", yesterday, 3), game("02", yesterday, 3)));
+        when(scoreboards.forDate(yesterday)).thenReturn(buildScoreboard(game("01", 3), game("02", 3)));
 
         LocalDate today = LocalDate.now();
-        when(scoreboards.forDate(today)).thenReturn(buildScoreboard(game("11", today, 2), game("12", today, 3), game("13", today, 1)));
+        when(scoreboards.forDate(today)).thenReturn(buildScoreboard(game("11", 2), game("12", 3), game("13", 1)));
     }
 
-    private ApiScoreboard buildScoreboard(ApiScoreboardGame... games) {
+    private ApiScoreboard buildScoreboard(ApiModule... modules) {
         ApiScoreboard scoreboard = new ApiScoreboard();
-        scoreboard.setGames(Arrays.asList(games));
+        scoreboard.setModules(Arrays.asList(modules));
         return scoreboard;
     }
 
@@ -78,11 +77,16 @@ private void release() {
         assertThat(games.findUnreleased()).isPresent();
     }
 
-    private ApiScoreboardGame game(String gameId, LocalDate gameDate, int status) {
+    private ApiModule game(String gameId, int status) {
         ApiScoreboardGame gameDetails = new ApiScoreboardGame();
         gameDetails.setGameId(gameId);
         gameDetails.setGameStatus(status);
-        gameDetails.setGameCode(gameDate.format(DateTimeFormatter.ofPattern("yyyyMMdd")) + "/url");
-        return gameDetails;
+
+        ApiCard card = new ApiCard();
+        card.setCardData(gameDetails);
+
+        ApiModule module = new ApiModule();
+        module.setCards(List.of(card));
+        return module;
     }
 }

src/test/java/fr/hippo/nbastats/infrastructure/secondary/api/ApiNbaGamesUnitTest.java

@@ -8,15 +8,14 @@
 import java.nio.file.Path;
 import org.junit.jupiter.api.Test;
 
-class ApiScoreboardWrapperUnitTest {
+class ApiScoreboardUnitTest {
 
     @Test
     void shouldReadFromJson() {
-        ApiScoreboardWrapper scoreboard = JsonHelper.readFromJson(defaultJson(), ApiScoreboardWrapper.class);
+        ApiScoreboard scoreboard = JsonHelper.readFromJson(defaultJson(), ApiScoreboard.class);
 
-        ApiScoreboardGame game = scoreboard.getScoreboard().getGames().iterator().next();
+        ApiScoreboardGame game = scoreboard.getGames().iterator().next();
         assertThat(game.getGameId()).isEqualTo("0022200003");
-        assertThat(game.getGameCode()).isEqualTo("20221019/ORLDET");
         assertThat(game.getGameStatus()).isEqualTo(3);
         assertThat(game.getHomeTeam().getTeamId()).isEqualTo("1610612765");
         assertThat(game.getHomeTeam().getScore()).isEqualTo(113);