Merge pull request jruby#8537 from enebo/no_check

We should always have a valid staticScope

Author: enebo

core/src/main/java/org/jruby/ir/runtime/IRRuntimeHelpers.java

@@ -1659,15 +1659,15 @@ public static RubyHash dupKwargsHashAndPopulateFromArray(ThreadContext context,
 
     @JIT
     public static IRubyObject searchConst(ThreadContext context, StaticScope staticScope, String constName, boolean noPrivateConsts) {
-        RubyModule object = objectClass(context);
-        IRubyObject constant = staticScope == null ? object.getConstant(constName) : staticScope.getConstantInner(constName);
+        IRubyObject constant = staticScope.getConstantInner(constName);
 
         // Inheritance lookup
         RubyModule module = null;
         if (constant == null) {
-            // SSS FIXME: Is this null check case correct?
-            module = staticScope == null ? object : staticScope.getModule();
-            constant = noPrivateConsts ? module.getConstantFromNoConstMissing(constName, false) : module.getConstantNoConstMissing(constName);
+            module = staticScope.getModule();
+            constant = noPrivateConsts ?
+                    module.getConstantFromNoConstMissing(constName, false) :
+                    module.getConstantNoConstMissing(constName);
         }
 
         // Call const_missing or cache

core/src/main/java/org/jruby/ir/targets/indy/ConstantLookupSite.java

@@ -80,18 +80,17 @@ private RubySymbol getSymbolicName(ThreadContext context) {
 
     public IRubyObject searchConst(ThreadContext context, StaticScope staticScope) {
         // Lexical lookup
-        RubyModule object = objectClass(context);
-
         // get switchpoint before value
         SwitchPoint switchPoint = getSwitchPointForConstant(context.runtime);
-        IRubyObject constant = (staticScope == null) ? object.getConstant(name) : staticScope.getConstantInner(name);
+        IRubyObject constant = staticScope.getConstantInner(name);
 
         // Inheritance lookup
         RubyModule module = null;
         if (constant == null) {
-            // SSS FIXME: Is this null check case correct?
-            module = staticScope == null ? object : staticScope.getModule();
-            constant = publicOnly ? module.getConstantFromNoConstMissing(name, false) : module.getConstantNoConstMissing(name);
+            module = staticScope.getModule();
+            constant = publicOnly ?
+                    module.getConstantFromNoConstMissing(name, false) :
+                    module.getConstantNoConstMissing(name);
         }
 
         // Call const_missing or cache

core/src/main/java/org/jruby/ir/targets/simple/ConstantLookupSite.java

@@ -25,16 +25,16 @@ public ConstantLookupSite(RubySymbol name) {
 
     private IRubyObject cacheSearchConst(ThreadContext context, StaticScope staticScope, boolean publicOnly) {
         // Lexical lookup
-        RubyModule object = objectClass(context);
         String id = this.id;
-        IRubyObject constant = (staticScope == null) ? object.getConstant(id) : staticScope.getConstantInner(id);
+        IRubyObject constant = staticScope.getConstantInner(id);
 
         // Inheritance lookup
         RubyModule module = null;
         if (constant == null) {
-            // SSS FIXME: Is this null check case correct?
-            module = staticScope == null ? object : staticScope.getModule();
-            constant = publicOnly ? module.getConstantFromNoConstMissing(id, false) : module.getConstantNoConstMissing(id);
+            module = staticScope.getModule();
+            constant = publicOnly ?
+                    module.getConstantFromNoConstMissing(id, false) :
+                    module.getConstantNoConstMissing(id);
         }
 
         // Call const_missing or cache