flux: fix namespaced crds fetching for users with limited perissions #465
+25
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augustin Pasquier <[email protected]>
augustin-pasq
force-pushed
the
fix-crds-fetching
branch
from
6347745 to
58aa307
Compare
There was a problem hiding this comment.
Pull request overview
This PR aligns the Flux plugin’s resource fetching behavior with the rest of Headlamp by honoring the currently selected namespaces from the global namespace filter, so users with limited namespace permissions no longer need to configure “Allowed namespaces” separately for Flux.
Changes:
- Introduces a
useNamespaceshook in the Flux helpers that reads the selected namespaces from the global Reduxfilter.namespacesstate and exposes them as an array. - Updates all Flux list views (sources, notifications, kustomizations, image automation resources, and Helm releases) to pass the selected namespaces into their respective
useListcalls. - Wires the new hook into each affected list component via imports from
../helpers.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| flux/src/helpers/index.tsx | Adds useNamespaces hook that selects filter.namespaces from Redux and memoizes it as an array, and imports useMemo/useSelector to support it. |
| flux/src/sources/SourceList.tsx | Uses useNamespaces() to restrict Flux source listing (resourceClass.useList) to the currently selected namespaces. |
| flux/src/notifications/NotificationList.tsx | Applies useNamespaces() to alert, provider, and receiver notification useList calls so they follow the namespace filter. |
| flux/src/kustomizations/KustomizationList.tsx | Passes useNamespaces() into Kustomization.useList so kustomizations are fetched per selected namespaces. |
| flux/src/image-automation/ImageAutomationList.tsx | Uses useNamespaces() for image update automations, policies, and repositories to scope their useList calls by namespace. |
| flux/src/helm-releases/HelmReleaseList.tsx | Uses useNamespaces() to scope HelmRelease.useList to selected namespaces. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This pull request fixes Flux resource fetching for users with limited cluster permissions.
When a user has access to only a few namespaces (but not all), Kubernetes resources - including Flux resources - are not displayed by default. Throughout Headlamp, such users must filter by the namespaces they are allowed to access in order to see data. However, for the Flux plugin, users previously had to manually configure
Settings > Cluster > Allowed namespacesbefore being able to view them.With this PR, that extra step is no longer necessary. The Flux plugin will now behave consistently with the rest of the app, providing a more seamless and homogeneous user experience.