Skip to content

Commit 41022b5

Browse files
committed
Merge rust-bitcoin/rust-miniscript#846: Invert malleability test in best_tap_spend
36349ba51bd4ae3f51cd3b4768e024da0a376935 Invert malleability test in `best_tap_spend` (Daniel Roberts) Pull request description: I *really* don't feel like I have enough context to be confident in this change, but at the same time this seems pretty obviously backwards to the best of my (currently lacking) knowledge. ACKs for top commit: apoelstra: ACK 36349ba51bd4ae3f51cd3b4768e024da0a376935; successfully ran local tests Tree-SHA512: 036a1d284f4014ff1c14b88685d148091d36ada5a6ce64dd552f0df26e762dc1f393a3436d0940d69ac68864c1f3f906a6f03a6a6b7b0ae2387e7a3d2ea29aaf
2 parents b8eaa05 + 668becd commit 41022b5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/descriptor/tr/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,12 +488,12 @@ where
488488
let mut min_wit_len = None;
489489
for leaf in spend_info.leaves() {
490490
let mut satisfaction = if allow_mall {
491-
match leaf.miniscript().build_template(provider) {
491+
match leaf.miniscript().build_template_mall(provider) {
492492
s @ Satisfaction { stack: Witness::Stack(_), .. } => s,
493493
_ => continue, // No witness for this script in tr descriptor, look for next one
494494
}
495495
} else {
496-
match leaf.miniscript().build_template_mall(provider) {
496+
match leaf.miniscript().build_template(provider) {
497497
s @ Satisfaction { stack: Witness::Stack(_), .. } => s,
498498
_ => continue, // No witness for this script in tr descriptor, look for next one
499499
}

0 commit comments

Comments
 (0)