Take self by value

heap-coder · heap-coder · commit baf18aa93a5e · 2022-12-18T16:45:12.000+11:00
Clippy emits:

 warning: methods with the following characteristics: (`to_*` and `self`
 type is `Copy`) usually take `self` by value

The method in question is private, change to take `self` by value.
Requires no other changes.
diff --git a/src/interpreter/mod.rs b/src/interpreter/mod.rs
@@ -103,7 +103,7 @@ enum BitcoinKey {
 }
 
 impl BitcoinKey {
-    fn to_pubkeyhash(&self, sig_type: SigType) -> hash160::Hash {
+    fn to_pubkeyhash(self, sig_type: SigType) -> hash160::Hash {
         match self {
             BitcoinKey::Fullkey(pk) => pk.to_pubkeyhash(sig_type),
             BitcoinKey::XOnlyPublicKey(pk) => pk.to_pubkeyhash(sig_type),

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ enum BitcoinKey {`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`impl BitcoinKey {`
`106`		`- fn to_pubkeyhash(&self, sig_type: SigType) -> hash160::Hash {`
	`106`	`+ fn to_pubkeyhash(self, sig_type: SigType) -> hash160::Hash {`
`107`	`107`	`match self {`
`108`	`108`	`BitcoinKey::Fullkey(pk) => pk.to_pubkeyhash(sig_type),`
`109`	`109`	`BitcoinKey::XOnlyPublicKey(pk) => pk.to_pubkeyhash(sig_type),`