Skip to content

[generate:command] Regression with the Annotation stops custom translations from working #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[generate:command] Regression with the Annotation stops custom translations from working #4282

wants to merge 1 commit into from

Conversation

codebymikey
Copy link

The #4074 PR introduced a regression with the annotations.

The DrupalCommand annotation was missing the @ annotation token prefix, which stops translations from being detected for generated commands as it fails validation and marked as an invalid command in the following:

drupal-console/src/Application.php

Lines 123 to 129 in e582d88

if (!$annotationValidator->isValidCommand(
$serviceDefinition->getClass()
)
) {
$invalidCommands[] = $name;
continue;
}

@codebymikey
[generate:command] Address annotation regression
009cb02 
The DrupalCommand annotation was missing the '@' annotation token.
This stops translations from being detected for generated commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codebymikey