feat: add jira fields config to AM secret

Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>

Author: heliapb

pkg/alertmanager/amcfg.go

@@ -3122,6 +3122,20 @@ func (jc *jiraConfig) sanitize(amVersion semver.Version, logger *slog.Logger) er
 			}
 		}
 	}
+
+	lessThanV0_30 := amVersion.LT(semver.MustParse("0.30.0"))
+	if jc.Summary.EnableUpdate != nil && lessThanV0_30 {
+		msg := "'enable_update' on 'summary' supported in Alertmanager >= 0.30.0 only - dropping field from provided config"
+		logger.Warn(msg, "current_version", amVersion.String())
+		jc.Summary.EnableUpdate = nil
+	}
+
+	if jc.Description.EnableUpdate != nil && lessThanV0_30 {
+		msg := "'enable_update' on 'description' supported in Alertmanager >= 0.30.0 only - dropping field from provided config"
+		logger.Warn(msg, "current_version", amVersion.String())
+		jc.Description.EnableUpdate = nil
+	}
+
 	if jc.APIURL != "" {
 		if _, err := validation.ValidateURL(jc.APIURL); err != nil {
 			return fmt.Errorf("invalid 'api_url': %w", err)

pkg/alertmanager/amcfg_test.go

@@ -6857,6 +6857,10 @@ func TestSanitizeJiraConfig(t *testing.T) {
 
 	versionAPITypeAllowed := semver.Version{Major: 0, Minor: 29}
 	versionAPITypeNotAllowed := semver.Version{Major: 0, Minor: 28}
+
+	versionEnableUpdateAllowed := semver.Version{Major: 0, Minor: 30}
+	versionEnableUpdateNotAllowed := semver.Version{Major: 0, Minor: 29}
+
 	for _, tc := range []struct {
 		name           string
 		againstVersion semver.Version
@@ -7008,6 +7012,120 @@ func TestSanitizeJiraConfig(t *testing.T) {
 			},
 			expectErr: true,
 		},
+		{
+			name:           "jira_configs with enable_update on summary",
+			againstVersion: versionEnableUpdateAllowed,
+			in: &alertmanagerConfig{
+				Receivers: []*receiver{
+					{
+						JiraConfigs: []*jiraConfig{
+							{
+								APIURL:    "http://issues.example.com",
+								Project:   "Monitoring",
+								IssueType: "Bug",
+								Summary: jiraFieldConfig{
+									Template:     "{{ template \"jira.default.summary\" . }}",
+									EnableUpdate: ptr.To(false),
+								},
+							},
+						},
+					},
+				},
+			},
+			golden: "jira_config_with_enable_update_summary.golden",
+		},
+		{
+			name:           "jira_configs with enable_update on description",
+			againstVersion: versionEnableUpdateAllowed,
+			in: &alertmanagerConfig{
+				Receivers: []*receiver{
+					{
+						JiraConfigs: []*jiraConfig{
+							{
+								APIURL:    "http://issues.example.com",
+								Project:   "Monitoring",
+								IssueType: "Bug",
+								Description: jiraFieldConfig{
+									Template:     "{{ template \"jira.default.description\" . }}",
+									EnableUpdate: ptr.To(false),
+								},
+							},
+						},
+					},
+				},
+			},
+			golden: "jira_config_with_enable_update_description.golden",
+		},
+		{
+			name:           "jira_configs with enable_update on summary version not supported",
+			againstVersion: versionEnableUpdateNotAllowed,
+			in: &alertmanagerConfig{
+				Receivers: []*receiver{
+					{
+						JiraConfigs: []*jiraConfig{
+							{
+								APIURL:    "http://issues.example.com",
+								Project:   "Monitoring",
+								IssueType: "Bug",
+								Summary: jiraFieldConfig{
+									Template:     "{{ template \"jira.default.summary\" . }}",
+									EnableUpdate: ptr.To(false),
+								},
+							},
+						},
+					},
+				},
+			},
+			golden: "jira_config_with_enable_update_summary_version_not_supported.golden",
+		},
+		{
+			name:           "jira_configs with enable_update on description version not supported",
+			againstVersion: versionEnableUpdateNotAllowed,
+			in: &alertmanagerConfig{
+				Receivers: []*receiver{
+					{
+						JiraConfigs: []*jiraConfig{
+							{
+								APIURL:    "http://issues.example.com",
+								Project:   "Monitoring",
+								IssueType: "Bug",
+								Description: jiraFieldConfig{
+									Template:     "{{ template \"jira.default.description\" . }}",
+									EnableUpdate: ptr.To(false),
+								},
+							},
+						},
+					},
+				},
+			},
+			golden: "jira_config_with_enable_update_description_version_not_supported.golden",
+		},
+		{
+			name:           "jira_configs with enable_update on both summary and description version not supported",
+			againstVersion: versionEnableUpdateNotAllowed,
+			in: &alertmanagerConfig{
+				Receivers: []*receiver{
+					{
+						JiraConfigs: []*jiraConfig{
+							{
+								APIURL:    "http://issues.example.com",
+								Project:   "Monitoring",
+								IssueType: "Bug",
+								Summary: jiraFieldConfig{
+									Template:     "{{ template \"jira.default.summary\" . }}",
+									EnableUpdate: ptr.To(false),
+								},
+								Description: jiraFieldConfig{
+									Template:     "{{ template \"jira.default.description\" . }}",
+									EnableUpdate: ptr.To(false),
+								},
+							},
+						},
+					},
+				},
+			},
+			golden: "jira_config_with_enable_update_both_version_not_supported.golden",
+		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {
 			err := tc.in.sanitize(tc.againstVersion, logger)

pkg/alertmanager/testdata/jira_config_with_enable_update_both_version_not_supported.golden

@@ -461,8 +461,8 @@ type jiraConfig struct {
 	SendResolved      *bool             `yaml:"send_resolved,omitempty"`
 	APIURL            string            `yaml:"api_url,omitempty"`
 	Project           string            `yaml:"project,omitempty"`
-	Summary           string            `yaml:"summary,omitempty"`
-	Description       string            `yaml:"description,omitempty"`
+	Summary           jiraFieldConfig   `yaml:"summary,omitempty"`
+	Description       jiraFieldConfig   `yaml:"description,omitempty"`
 	Labels            []string          `yaml:"labels,omitempty"`
 	Priority          string            `yaml:"priority,omitempty"`
 	IssueType         string            `yaml:"issue_type,omitempty"`
@@ -474,6 +474,11 @@ type jiraConfig struct {
 	APIType           string            `yaml:"api_type,omitempty"`
 }
 
+type jiraFieldConfig struct {
+	Template     string `yaml:"template,omitempty"`
+	EnableUpdate *bool  `yaml:"enable_update,omitempty"`
+}
+
 type rocketchatAttachmentField struct {
 	Short *bool  `yaml:"short"`
 	Title string `yaml:"title,omitempty"`