Skip to content

Commit 82f9648

Browse files
committed
refactor: Update analyzer and build. Override test because I can't for gods sake fix the dependency conflicts with pinned flutter versions.
1 parent 2ad1335 commit 82f9648

File tree

13 files changed

+152
-222
lines changed

13 files changed

+152
-222
lines changed

formats/dogs_cbor/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ dependencies:
1414

1515
dev_dependencies:
1616
lints: ^5.1.1
17-
test: ^1.25.9
17+
test: ^1.29.0

packages/dogs_built/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ dependencies:
1515

1616
dev_dependencies:
1717
lints: ^5.1.1
18-
test: ^1.25.9
18+
test: ^1.29.0

packages/dogs_core/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ dependencies:
2424

2525
dev_dependencies:
2626
lints: ^5.1.1
27-
test: ^1.25.9
27+
test: ^1.29.0

packages/dogs_flutter/example/pubspec.lock

Lines changed: 28 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,18 @@ packages:
55
dependency: transitive
66
description:
77
name: _fe_analyzer_shared
8-
sha256: da0d9209ca76bde579f2da330aeb9df62b6319c834fa7baae052021b0462401f
8+
sha256: "8d7ff3948166b8ec5da0fbb5962000926b8e02f2ed9b3e51d1738905fbd4c98d"
99
url: "https://pub.dev"
1010
source: hosted
11-
version: "85.0.0"
11+
version: "93.0.0"
1212
analyzer:
1313
dependency: transitive
1414
description:
1515
name: analyzer
16-
sha256: "974859dc0ff5f37bc4313244b3218c791810d03ab3470a579580279ba971a48d"
16+
sha256: de7148ed2fcec579b19f122c1800933dfa028f6d9fd38a152b04b1516cec120b
1717
url: "https://pub.dev"
1818
source: hosted
19-
version: "7.7.1"
19+
version: "10.0.1"
2020
args:
2121
dependency: transitive
2222
description:
@@ -45,10 +45,10 @@ packages:
4545
dependency: transitive
4646
description:
4747
name: build
48-
sha256: "6439a9c71a4e6eca8d9490c1b380a25b02675aa688137dfbe66d2062884a23ac"
48+
sha256: "275bf6bb2a00a9852c28d4e0b410da1d833a734d57d39d44f94bfc895a484ec3"
4949
url: "https://pub.dev"
5050
source: hosted
51-
version: "3.0.2"
51+
version: "4.0.4"
5252
build_config:
5353
dependency: transitive
5454
description:
@@ -65,30 +65,14 @@ packages:
6565
url: "https://pub.dev"
6666
source: hosted
6767
version: "4.0.4"
68-
build_resolvers:
69-
dependency: transitive
70-
description:
71-
name: build_resolvers
72-
sha256: "2b21a125d66a86b9511cc3fb6c668c42e9a1185083922bf60e46d483a81a9712"
73-
url: "https://pub.dev"
74-
source: hosted
75-
version: "3.0.2"
7668
build_runner:
7769
dependency: "direct dev"
7870
description:
7971
name: build_runner
80-
sha256: fd3c09f4bbff7fa6e8d8ef688a0b2e8a6384e6483a25af0dac75fef362bcfe6f
81-
url: "https://pub.dev"
82-
source: hosted
83-
version: "2.7.0"
84-
build_runner_core:
85-
dependency: transitive
86-
description:
87-
name: build_runner_core
88-
sha256: ab27e46c8aa233e610cf6084ee6d8a22c6f873a0a9929241d8855b7a72978ae7
72+
sha256: b4d854962a32fd9f8efc0b76f98214790b833af8b2e9b2df6bfc927c0415a072
8973
url: "https://pub.dev"
9074
source: hosted
91-
version: "9.3.0"
75+
version: "2.10.5"
9276
built_collection:
9377
dependency: transitive
9478
description:
@@ -133,10 +117,10 @@ packages:
133117
dependency: transitive
134118
description:
135119
name: code_builder
136-
sha256: "0ec10bf4a89e4c613960bf1e8b42c64127021740fb21640c29c909826a5eea3e"
120+
sha256: "6a6cab2ba4680d6423f34a9b972a4c9a94ebe1b62ecec4e1a1f2cba91fd1319d"
137121
url: "https://pub.dev"
138122
source: hosted
139-
version: "4.10.1"
123+
version: "4.11.1"
140124
collection:
141125
dependency: transitive
142126
description:
@@ -157,10 +141,10 @@ packages:
157141
dependency: transitive
158142
description:
159143
name: crypto
160-
sha256: "1e445881f28f22d6140f181e07737b22f1e099a5e1ff94b0af2f9e4a463f4855"
144+
sha256: c8ea0233063ba03258fbcf2ca4d6dadfefe14f02fab57702265467a19f27fadf
161145
url: "https://pub.dev"
162146
source: hosted
163-
version: "3.0.6"
147+
version: "3.0.7"
164148
cupertino_icons:
165149
dependency: "direct main"
166150
description:
@@ -173,31 +157,31 @@ packages:
173157
dependency: transitive
174158
description:
175159
name: dart_style
176-
sha256: "8a0e5fba27e8ee025d2ffb4ee820b4e6e2cf5e4246a6b1a477eb66866947e0bb"
160+
sha256: "15a7db352c8fc6a4d2bc475ba901c25b39fe7157541da4c16eacce6f8be83e49"
177161
url: "https://pub.dev"
178162
source: hosted
179-
version: "3.1.1"
163+
version: "3.1.5"
180164
dogs_core:
181165
dependency: "direct overridden"
182166
description:
183167
path: "../../dogs_core"
184168
relative: true
185169
source: path
186-
version: "10.0.0-dev.5"
170+
version: "10.1.1"
187171
dogs_flutter:
188172
dependency: "direct main"
189173
description:
190174
path: ".."
191175
relative: true
192176
source: path
193-
version: "0.0.1-dev.7"
177+
version: "0.0.1-dev.12"
194178
dogs_generator:
195179
dependency: "direct dev"
196180
description:
197181
path: "../../dogs_generator"
198182
relative: true
199183
source: path
200-
version: "7.0.0-dev.5"
184+
version: "7.1.0"
201185
duffer:
202186
dependency: transitive
203187
description:
@@ -248,14 +232,6 @@ packages:
248232
description: flutter
249233
source: sdk
250234
version: "0.0.0"
251-
frontend_server_client:
252-
dependency: transitive
253-
description:
254-
name: frontend_server_client
255-
sha256: f64a0333a82f30b0cca061bc3d143813a486dc086b574bfb233b7c1372427694
256-
url: "https://pub.dev"
257-
source: hosted
258-
version: "4.0.0"
259235
glob:
260236
dependency: transitive
261237
description:
@@ -348,18 +324,18 @@ packages:
348324
dependency: transitive
349325
description:
350326
name: lyell
351-
sha256: "552cbf1ae9ba85040c0da34e1bbb2bcec769de4ee9a97ffb3496e60fbd8e03de"
327+
sha256: f24d18ff0fcd5ebcebc265f8c30e51e140a99ef76eb966c29646ba7690d6616f
352328
url: "https://pub.dev"
353329
source: hosted
354-
version: "1.4.5"
330+
version: "1.5.0"
355331
lyell_gen:
356332
dependency: transitive
357333
description:
358334
name: lyell_gen
359-
sha256: "566acd859dc12207740c5285963c3169b2537f6290760dc86388fcb8b8808187"
335+
sha256: "07a828168aff5e0289f2707a7038a9cb000a9fbb47f0ed307e24b5782e961e4f"
360336
url: "https://pub.dev"
361337
source: hosted
362-
version: "3.0.11"
338+
version: "4.0.1"
363339
matcher:
364340
dependency: transitive
365341
description:
@@ -380,10 +356,10 @@ packages:
380356
dependency: transitive
381357
description:
382358
name: meta
383-
sha256: e3641ec5d63ebf0d9b41bd43201a66e3fc79a65db5f61fc181f04cd27aab950c
359+
sha256: "23f08335362185a5ea2ad3a4e597f1375e78bce8a040df5c600c8d3552ef2394"
384360
url: "https://pub.dev"
385361
source: hosted
386-
version: "1.16.0"
362+
version: "1.17.0"
387363
mime:
388364
dependency: transitive
389365
description:
@@ -489,10 +465,10 @@ packages:
489465
dependency: transitive
490466
description:
491467
name: source_gen
492-
sha256: "7b19d6ba131c6eb98bfcbf8d56c1a7002eba438af2e7ae6f8398b2b0f4f381e3"
468+
sha256: "1d562a3c1f713904ebbed50d2760217fd8a51ca170ac4b05b0db490699dbac17"
493469
url: "https://pub.dev"
494470
source: hosted
495-
version: "3.1.0"
471+
version: "4.2.0"
496472
source_span:
497473
dependency: transitive
498474
description:
@@ -545,18 +521,10 @@ packages:
545521
dependency: transitive
546522
description:
547523
name: test_api
548-
sha256: "522f00f556e73044315fa4585ec3270f1808a4b186c936e612cab0b565ff1e00"
549-
url: "https://pub.dev"
550-
source: hosted
551-
version: "0.7.6"
552-
timing:
553-
dependency: transitive
554-
description:
555-
name: timing
556-
sha256: "62ee18aca144e4a9f29d212f5a4c6a053be252b895ab14b5821996cff4ed90fe"
524+
sha256: ab2726c1a94d3176a45960b6234466ec367179b87dd74f1611adb1f3b5fb9d55
557525
url: "https://pub.dev"
558526
source: hosted
559-
version: "1.0.2"
527+
version: "0.7.7"
560528
typed_data:
561529
dependency: transitive
562530
description:
@@ -630,5 +598,5 @@ packages:
630598
source: hosted
631599
version: "3.1.3"
632600
sdks:
633-
dart: ">=3.8.0 <4.0.0"
601+
dart: ">=3.9.0 <4.0.0"
634602
flutter: ">=3.18.0-18.0.pre.54"

packages/dogs_generator/lib/adapters/dog_adapter.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,12 @@
1717
*/
1818

1919
import 'package:analyzer/dart/element/element.dart';
20-
import 'package:analyzer/dart/element/element2.dart';
2120
import 'package:build/build.dart';
2221
import 'package:collection/collection.dart';
2322
import 'package:lyell_gen/lyell_gen.dart';
2423
import 'package:source_gen/builder.dart';
2524

26-
abstract class DogsAdapter<TAnnotation> extends SubjectAdapter<TAnnotation, Element2> {
25+
abstract class DogsAdapter<TAnnotation> extends SubjectAdapter<TAnnotation, Element> {
2726
DogsAdapter({required super.archetype})
2827
: super(descriptorExtension: 'dogs', annotation: TAnnotation);
2928
}

packages/dogs_generator/lib/analyze/built_interop.dart

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import 'package:analyzer/dart/element/element2.dart';
17+
import 'package:analyzer/dart/element/element.dart';
1818
import 'package:analyzer/dart/element/nullability_suffix.dart';
1919
import 'package:analyzer/dart/element/type.dart';
2020
import 'package:build/build.dart';
@@ -39,12 +39,12 @@ late TypeChecker setBuilderChecker;
3939
late TypeChecker builtValueFieldChecker;
4040
late TypeChecker builtValueEnumChecker;
4141

42-
late InterfaceElement2 builtInterface;
43-
late InterfaceElement2 builtBuilderInterface;
42+
late InterfaceElement builtInterface;
43+
late InterfaceElement builtBuilderInterface;
4444

45-
late InterfaceElement2 listBuilderInterface;
46-
late InterfaceElement2 mapBuilderInterface;
47-
late InterfaceElement2 setBuilderInterface;
45+
late InterfaceElement listBuilderInterface;
46+
late InterfaceElement mapBuilderInterface;
47+
late InterfaceElement setBuilderInterface;
4848

4949
bool hasBuiltInterop = false;
5050

@@ -62,11 +62,11 @@ Future tryInitializeBuiltInterop(BuildStep step) async {
6262
_builtValueLibrary = LibraryReader(builtValueLibrary);
6363
_builtCollectionLibrary = LibraryReader(builtCollectionLibrary);
6464

65-
builtInterface = _builtValueLibrary.findType("Built") as InterfaceElement2;
66-
builtBuilderInterface = _builtValueLibrary.findType("Builder") as InterfaceElement2;
67-
listBuilderInterface = _builtCollectionLibrary.findType("ListBuilder") as InterfaceElement2;
68-
mapBuilderInterface = _builtCollectionLibrary.findType("MapBuilder") as InterfaceElement2;
69-
setBuilderInterface = _builtCollectionLibrary.findType("SetBuilder") as InterfaceElement2;
65+
builtInterface = _builtValueLibrary.findType("Built") as InterfaceElement;
66+
builtBuilderInterface = _builtValueLibrary.findType("Builder") as InterfaceElement;
67+
listBuilderInterface = _builtCollectionLibrary.findType("ListBuilder") as InterfaceElement;
68+
mapBuilderInterface = _builtCollectionLibrary.findType("MapBuilder") as InterfaceElement;
69+
setBuilderInterface = _builtCollectionLibrary.findType("SetBuilder") as InterfaceElement;
7070

7171
builtChecker = TypeChecker.fromStatic(builtInterface.thisType);
7272
builtBuilderChecker = TypeChecker.fromStatic(builtBuilderInterface.thisType);
@@ -82,17 +82,17 @@ Future tryInitializeBuiltInterop(BuildStep step) async {
8282
}
8383

8484
Future<IRStructure> structurizeBuilt(
85-
SubjectCodeContext codeContext, SubjectGenContext context, ClassElement2 element) async {
85+
SubjectCodeContext codeContext, SubjectGenContext context, ClassElement element) async {
8686
var counter = codeContext.cachedCounter;
87-
var builtInterfaceImpl = element.thisType.asInstanceOf2(builtInterface)!;
88-
var builderElement = builtInterfaceImpl.typeArguments[1].element3! as ClassElement2;
87+
var builtInterfaceImpl = element.thisType.asInstanceOf(builtInterface)!;
88+
var builderElement = builtInterfaceImpl.typeArguments[1].element! as ClassElement;
8989

9090
var getters =
91-
builderElement.getters2.where((element) => element.isPublic && !element.isStatic).toList();
91+
builderElement.getters.where((element) => element.isPublic && !element.isStatic).toList();
9292

9393
var fields = <IRStructureField>[];
9494
for (var builderGetter in getters) {
95-
var fieldGetter = element.getGetter2(builderGetter.displayName)!;
95+
var fieldGetter = element.getGetter(builderGetter.displayName)!;
9696
var fieldName = fieldGetter.displayName;
9797
var fieldType = fieldGetter.returnType;
9898
var serialType = await getSerialType(fieldType, context);
@@ -101,7 +101,7 @@ Future<IRStructure> structurizeBuilt(
101101
var optional = fieldType.nullabilitySuffix == NullabilitySuffix.question;
102102
if (fieldType is DynamicType) optional = true;
103103

104-
var builtValueFieldAnnotation = fieldGetter.metadata2.annotations
104+
var builtValueFieldAnnotation = fieldGetter.metadata.annotations
105105
.whereTypeChecker(builtValueFieldChecker)
106106
.firstOrNull
107107
?.computeConstantValue();
@@ -137,14 +137,14 @@ Future<IRStructure> structurizeBuilt(
137137
}
138138

139139
Future<void> writeBuiltInteropConverter(
140-
ClassElement2 element, SubjectCodeContext codeContext, SubjectGenContext context) async {
140+
ClassElement element, SubjectCodeContext codeContext, SubjectGenContext context) async {
141141
codeContext.additionalImports.add(AliasImport.gen("package:dogs_core/dogs_core.dart"));
142142
codeContext.additionalImports.add(AliasImport.gen("package:dogs_built/dogs_built.dart"));
143143
codeContext.additionalImports
144144
.add(AliasImport.gen("package:built_collection/built_collection.dart"));
145145

146-
var builtInterfaceImpl = element.thisType.asInstanceOf2(builtInterface)!;
147-
var builderElement = builtInterfaceImpl.typeArguments[1].element3! as ClassElement2;
146+
var builtInterfaceImpl = element.thisType.asInstanceOf(builtInterface)!;
147+
var builderElement = builtInterfaceImpl.typeArguments[1].element! as ClassElement;
148148

149149
var structure = await structurizeBuilt(codeContext, context, element);
150150
var typeRef = codeContext.typeName(element.thisType);
@@ -188,15 +188,15 @@ Future<void> writeBuiltInteropConverter(
188188
..static = true
189189
..lambda = false
190190
..body = Code(
191-
"return (${typeRef}Builder()\n${builderElement.getters2.where((element) => element.isPublic && !element.isStatic).mapIndexed((i, e) {
191+
"return (${typeRef}Builder()\n${builderElement.getters.where((element) => element.isPublic && !element.isStatic).mapIndexed((i, e) {
192192
if (listBuilderChecker.isAssignableFromType(e.returnType)) {
193-
var innerType = e.returnType.asInstanceOf2(listBuilderInterface)!.typeArguments[0];
193+
var innerType = e.returnType.asInstanceOf(listBuilderInterface)!.typeArguments[0];
194194
return "..${e.displayName} = list[$i] == null ? null : gen.ListBuilder<${codeContext.typeName(innerType)}>(list[$i])";
195195
} else if (setBuilderChecker.isAssignableFromType(e.returnType)) {
196-
var innerType = e.returnType.asInstanceOf2(setBuilderInterface)!.typeArguments[0];
196+
var innerType = e.returnType.asInstanceOf(setBuilderInterface)!.typeArguments[0];
197197
return "..${e.displayName} = list[$i] == null ? null : gen.SetBuilder<${codeContext.typeName(innerType)}>(list[$i])";
198198
} else if (mapBuilderChecker.isAssignableFromType(e.returnType)) {
199-
var typeArguments = e.returnType.asInstanceOf2(mapBuilderInterface)!.typeArguments;
199+
var typeArguments = e.returnType.asInstanceOf(mapBuilderInterface)!.typeArguments;
200200
return "..${e.displayName} = list[$i] == null ? null : gen.MapBuilder<${codeContext.typeName(typeArguments[0])}, ${codeContext.typeName(typeArguments[1])}>(list[$i])";
201201
}
202202
return "..${e.displayName} = list[$i]";

0 commit comments

Comments
 (0)