Is it possible to drop the red dot before the line that has error, change the line number to red?

[stokhos]

Is it possible to drop the red dot before the line that has an error, and change the line number to red?
Or maybe add an option for this. Doing this will save some spaces

Best

[grv07]

Since we are using the same space for breakpoint and diagnostic. I have the following questions.

1. What should be the style of the line number if it has a breakpoint and diagnostic?
   Current behavior: It will show the breakpoint if available or show the diagnostic.

2. Since we have diff styles/colors for the current line. What should be the style in case of if the line has both the cursor and the diagnostic/breakpoint?
   Current behavior: Line number color and diagnostic/breakpoint are in separate spaces so no problem.

[stokhos]

Since we are using the same space for breakpoint and diagnostic. I have the following questions.

1. What should be the style of the line number if it has a breakpoint and diagnostic?
   Current behavior: It will show the breakpoint if available or show the diagnostic.

| we could change the line number alignment. Line numbers are right-aligned; we could change the line number to a red left-aligned number.

2. Since we have diff styles/colors for the current line. What should be the style in case of if the line has both the cursor and the diagnostic/breakpoint?
   Current behavior: Line number color and diagnostic/breakpoint are in separate spaces so no problem.

| No changes in current line styles if there is no error or breakpoint in this line.

@kirawi I'd like to work on this. Could you tell me where I should get started?

[kirawi]

You could take a look at

helix/helix-term/src/ui/editor.rs

Lines 710 to 826 in 65edf9c

	pub fn render_gutter(
	editor: &Editor,
	doc: &Document,
	view: &View,
	viewport: Rect,
	surface: &mut Surface,
	theme: &Theme,
	is_focused: bool,
	) {
	let text = doc.text().slice(..);
	let last_line = view.last_line(doc);
	// it's used inside an iterator so the collect isn't needless:
	// https://github.com/rust-lang/rust-clippy/issues/6164
	#[allow(clippy::needless_collect)]
	let cursors: Vec<_> = doc
	.selection(view.id)
	.iter()
	.map(|range| range.cursor_line(text))
	.collect();
	let mut offset = 0;
	let gutter_style = theme.get("ui.gutter");
	let gutter_selected_style = theme.get("ui.gutter.selected");
	// avoid lots of small allocations by reusing a text buffer for each line
	let mut text = String::with_capacity(8);
	for (constructor, width) in view.gutters() {
	let gutter = constructor(editor, doc, view, theme, is_focused, *width);
	text.reserve(*width); // ensure there's enough space for the gutter
	for (i, line) in (view.offset.row..(last_line + 1)).enumerate() {
	let selected = cursors.contains(&line);
	let x = viewport.x + offset;
	let y = viewport.y + i as u16;
	let gutter_style = if selected {
	gutter_selected_style
	} else {
	gutter_style
	};
	if let Some(style) = gutter(line, selected, &mut text) {
	surface.set_stringn(x, y, &text, *width, gutter_style.patch(style));
	} else {
	surface.set_style(
	Rect {
	x,
	y,
	width: *width as u16,
	height: 1,
	},
	gutter_style,
	);
	}
	text.clear();
	}
	offset += *width as u16;
	}
	}
	pub fn render_diagnostics(
	&self,
	doc: &Document,
	view: &View,
	viewport: Rect,
	surface: &mut Surface,
	theme: &Theme,
	) {
	use helix_core::diagnostic::Severity;
	use tui::{
	layout::Alignment,
	text::Text,
	widgets::{Paragraph, Widget, Wrap},
	};
	let cursor = doc
	.selection(view.id)
	.primary()
	.cursor(doc.text().slice(..));
	let diagnostics = doc.diagnostics().iter().filter(|diagnostic| {
	diagnostic.range.start <= cursor && diagnostic.range.end >= cursor
	});
	let warning = theme.get("warning");
	let error = theme.get("error");
	let info = theme.get("info");
	let hint = theme.get("hint");
	let mut lines = Vec::new();
	let background_style = theme.get("ui.background");
	for diagnostic in diagnostics {
	let style = Style::reset()
	.patch(background_style)
	.patch(match diagnostic.severity {
	Some(Severity::Error) => error,
	Some(Severity::Warning) | None => warning,
	Some(Severity::Info) => info,
	Some(Severity::Hint) => hint,
	});
	let text = Text::styled(&diagnostic.message, style);
	lines.extend(text.lines);
	}
	let paragraph = Paragraph::new(lines)
	.alignment(Alignment::Right)
	.wrap(Wrap { trim: true });
	let width = 100.min(viewport.width);
	let height = 15.min(viewport.height);
	paragraph.render(
	Rect::new(viewport.right() - width, viewport.y + 1, width, height),
	surface,
	);
	}

[aral]

A couple of quick accessibility/design notes:

• Colour should never be the only differentiator (think: colour blindness)
• If this is going to be implemented, it should be a non-default preference setting.
• Preferences shouldn’t be seen as an easy alternative to making design decisions.

hth :)