Pyright "Goto definition" returns "No definition found" for transformers

[del2z]

Summary

When using Pyright as LSP for python, command gd can redirect current buffer to the correct positions for modules and functions of numpy, torch, and some other packages, but fails for those of transformers. However, it would succeed if I jump to transformers package first and then go to definitions of some components in it. I guess this relates to the way of helix calling Pyright, because I could do the same using Neovim with Pyright except for its long loading time.

Reproduction Steps

I use a python script as following.

from transformers import GPT2Tokenizer
from torch.nn import Module
from numpy.random import set_state

print(GPT2Tokenizer)
print(Module)
print(set_state)

1. Move cursor to set_state and then press gd, I got
   

2. Go back and move cursor to Module and then press gd, I got
   

3. Go back and move cursor to GPT2Tokenizer and then gd, I got
   

4. If I move cursor to transformers and gd, I got
   

5. Go back and repeat step 3, I got
   

For the first time of performing step 3, Pyright could not return a valid result.

Helix log

~/.cache/helix/helix.log

2023-04-06T11:31:49.286 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/Users/del2z/Downloads",
        },
    ),
}
2023-04-06T11:31:49.286 helix_vcs [ERROR] failed to open diff base for /Users/del2z/Downloads/test.py
2023-04-06T11:31:49.286 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/Users/del2z/Downloads",
        },
    ),
}
2023-04-06T11:31:49.286 helix_vcs [ERROR] failed to obtain current head name for /Users/del2z/Downloads/test.py
2023-04-06T11:31:49.463 helix_term::application [ERROR] Language Server: Received malformed method call workspace/configuration in request 0: protocol error: InvalidParams: Invalid params: invalid value: string "", expected relative URL without a base.
2023-04-06T11:31:49.463 helix_term::application [ERROR] Language Server: Received malformed method call workspace/configuration in request 1: protocol error: InvalidParams: Invalid params: invalid value: string "", expected relative URL without a base.
2023-04-06T11:32:05.228 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/opt/miniconda/envs/main/lib/python3.9/site-packages/numpy/random",
        },
    ),
}
2023-04-06T11:32:05.228 helix_vcs [ERROR] failed to open diff base for /opt/miniconda/envs/main/lib/python3.9/site-packages/numpy/random/mtrand.pyi
2023-04-06T11:32:05.228 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/opt/miniconda/envs/main/lib/python3.9/site-packages/numpy/random",
        },
    ),
}
2023-04-06T11:32:05.228 helix_vcs [ERROR] failed to obtain current head name for /opt/miniconda/envs/main/lib/python3.9/site-packages/numpy/random/mtrand.pyi
2023-04-06T11:32:27.940 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/opt/miniconda/envs/main/lib/python3.9/site-packages/torch/nn/modules",
        },
    ),
}
2023-04-06T11:32:27.940 helix_vcs [ERROR] failed to open diff base for /opt/miniconda/envs/main/lib/python3.9/site-packages/torch/nn/modules/module.py
2023-04-06T11:32:27.940 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/opt/miniconda/envs/main/lib/python3.9/site-packages/torch/nn/modules",
        },
    ),
}
2023-04-06T11:32:27.940 helix_vcs [ERROR] failed to obtain current head name for /opt/miniconda/envs/main/lib/python3.9/site-packages/torch/nn/modules/module.py
2023-04-06T11:32:39.671 helix_view::editor [ERROR] editor error: No definition found.
2023-04-06T11:33:02.769 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/opt/miniconda/envs/main/lib/python3.9/site-packages/transformers",
        },
    ),
}
2023-04-06T11:33:02.770 helix_vcs [ERROR] failed to open diff base for /opt/miniconda/envs/main/lib/python3.9/site-packages/transformers/__init__.py
2023-04-06T11:33:02.770 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/opt/miniconda/envs/main/lib/python3.9/site-packages/transformers",
        },
    ),
}
2023-04-06T11:33:02.770 helix_vcs [ERROR] failed to obtain current head name for /opt/miniconda/envs/main/lib/python3.9/site-packages/transformers/__init__.py
2023-04-06T11:33:27.216 helix_term::commands [ERROR] Shell error: sh: macism: command not found

2023-04-06T11:33:27.216 helix_view::editor [ERROR] editor error: Async job failed: Shell error: sh: macism: command not found

2023-04-06T11:33:33.266 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/opt/miniconda/envs/main/lib/python3.9/site-packages/transformers/models/gpt2",
        },
    ),
}
2023-04-06T11:33:33.266 helix_vcs [ERROR] failed to open diff base for /opt/miniconda/envs/main/lib/python3.9/site-packages/transformers/models/gpt2/tokenization_gpt2.py
2023-04-06T11:33:33.266 helix_vcs [ERROR] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/opt/miniconda/envs/main/lib/python3.9/site-packages/transformers/models/gpt2",
        },
    ),
}
2023-04-06T11:33:33.267 helix_vcs [ERROR] failed to obtain current head name for /opt/miniconda/envs/main/lib/python3.9/site-packages/transformers/models/gpt2/tokenization_gpt2.py

Platform

macOS

Terminal Emulator

iterm2

Helix Version

helix 23.03 (3cf0372)

[pascalkuthe]

Goto definition is entirely server side. It's a very simple request that involves no optional features/capabilities. The only difference I can think of is that nvim might have a longer timeout than helix. The timeout in helix can be configured and defaults to a pretty slow 30s tough so that would surprise me.

Most likely this is an upstream issue since there is really no way the client can mess up a textDocument/definition request.

[pascalkuthe]

2023-04-06T11:31:49.463 helix_term::application [ERROR] Language Server: Received malformed method call workspace/configuration in request 1: protocol error: InvalidParams: Invalid params: invalid value: string "", expected relative URL without a base.

Altough this does sound suspect but I doubt its causing this since the the other definition requests work