Syntax highlighting stops working when updating grammer for Dart maybe other languages too

[Queyrouzec]

Summary

syntax highlighting stops working when updating grammer. I tried multiple commits before and after the current one and the syntax highlighting stops working.

Reproduction Steps

I added this to the language.toml file

[[grammar]]
name = "dart"
source = { git = "https://github.com/UserNobody14/tree-sitter-dart", rev = "ac0bb849ccd1a923963af47573b5e396736ff582" }

then ran hx -g fetch && hx -g build and it returned this

Fetching 18 grammars
17 up to date git grammars
1 updated grammars
	dart now on ac0bb849ccd1a923963af47573b5e396736ff582
Building 18 grammars
17 grammars already built
1 grammars built now
	["dart"]

After my syntax highlight completely stopped. I'm not entirely sure if tree-sitter stopped.
this happens with all commits other than the current one.

I've also tried clearing out the entire runtime file and reinstalling Helix. Unfortunately nothing seems to work.

Here's a link to the dart repo
https://github.com/UserNobody14/tree-sitter-dart

Helix log

~/.cache/helix/helix.log

2024-07-10T17:38:14.875 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:40:38.477 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:41:30.182 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:42:04.767 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:42:20.312 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:42:20.566 helix_lsp::transport [ERROR] dart <- ServerError(-32007): File is not being analyzed
2024-07-10T17:42:25.047 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:42:25.302 helix_lsp::transport [ERROR] dart <- ServerError(-32007): File is not being analyzed
2024-07-10T17:42:48.654 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:42:48.909 helix_lsp::transport [ERROR] dart <- ServerError(-32007): File is not being analyzed
2024-07-10T17:44:01.459 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:44:26.466 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:45:17.997 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:45:40.230 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:47:24.033 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 222, column: 5, offset: 3763, message: "base", kind: NodeType }
2024-07-10T17:48:17.509 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:54:00.418 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T17:54:00.672 helix_lsp::transport [ERROR] dart <- ServerError(-32007): File is not being analyzed
2024-07-10T17:54:27.544 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }
2024-07-10T18:03:09.462 helix_core::syntax [ERROR] Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }

Platform

MacOs M3

Terminal Emulator

Iterm2, warp, default terminal

Installation Method

brew

Helix Version

24.3 (2cadec0)

[the-mikedavis]

The line in the log

Could not parse queries for language "dart". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 33, column: 1, offset: 526, message: "marker_annotation", kind: NodeType }

is caused by updating the parser. Often when you update a parser you need to update the queries as well because the nodes that the parser has no longer has the nodes the queries are trying to pattern match. The log error here is saying that

helix/runtime/queries/dart/highlights.scm

Lines 14 to 15 in 8229a40

	(marker_annotation
	name: (identifier) @attribute)

was removed or renamed - it's no longer a possible node to match on.