Emitting OSC7 escape sequence on change_current_directory command execution?

[GregorLohaus]

It would be great if the change_current_directory command emitted the OSC 7 escape sequence so terminal emulators that use it can take advantage of this. I've hacked this into my own build in the worst possible way so i wont create a pull request but it works so maybe someone can still use it as a reference for doing it the right way: GregorLohaus@b9957e1

[the-mikedavis]

The implementation for the :cd command lives here:

helix/helix-term/src/commands/typed.rs

Lines 1081 to 1103 in ef4a4ff

	fn change_current_directory(
	cx: &mut compositor::Context,
	args: &[Cow<str>],
	event: PromptEvent,
	) -> anyhow::Result<()> {
	if event != PromptEvent::Validate {
	return Ok(());
	}
	let dir = args
	.first()
	.context("target directory not provided")?
	.as_ref();
	let dir = helix_stdx::path::expand_tilde(Path::new(dir));
	helix_stdx::env::set_current_working_dir(dir)?;
	cx.editor.set_status(format!(
	"Current working directory is now {}",
	helix_stdx::env::current_working_dir().display()
	));
	Ok(())
	}

You could place the OSC7 parts after the call to helix_stdx::env::set_current_working_dir(dir) line. If you're looking for Helix to support OSC7 out of the box I would start with adding support for it in the terminal manipulation library we use: https://github.com/crossterm-rs/crossterm. Then we can upgrade our version of crossterm and use the support there. We try to not have bare escape sequences in the codebase - those belong in crossterm.