write-all! (force write all) is not working

[7flash]

Summary

When I type :wa! nothiing happens therefore I have to go through each individual file and do :w!

TLDR; :wa and :w! works but :wa! is not working

Reproduction Steps

No response

Helix log

No response

Platform

macos

Terminal Emulator

kitty

Installation Method

brew

Helix Version

helix 23.10

[7flash]

#7556

[the-mikedavis]

I can't reproduce this: :wa! saves any files that I make changes to. Can you give a reproduction case and more details?

[7flash]

I should have mentioned, the issue appear when there are external changes to my file, and I want to force-override them; so to reproduce, try to make changes to currently opened file in external editor, and then compare outcomes of ":w!" which will override as expected vs ":wa!" which will not unfortunately

[the-mikedavis]

It looks like we skip documents that aren't modified since their last save within Helix:

helix/helix-term/src/commands/typed.rs

Lines 690 to 692 in 5ce77de

	if !doc.is_modified() {
	return None;
	}

That condition could consider the force parameter so that we save documents that haven't been modified as well.