Editor Freezes every time I save and quit an html file

[sdev138]

Summary

Every time I open an html file using Helix, and I don't edit the file, and type ":wq", the editor freezes and I have to close the terminal window. This does not occur if the html file has been edited, or if I saw and quit the html file separately after not editing the file.

Reproduction Steps

1. Open the file using Helix
2. Quit the file using <:wq>
3. Editor freezes
4. Expected Behavior: Close the file and take me back to the terminal

Helix log

No response

Platform

macOS

Terminal Emulator

kitty/wezterm/alacritty

Installation Method

brew

Helix Version

24.7

[the-mikedavis]

Do you have an example html file that reproduces this? It would also be useful to see the log output while running in verbose mode (hx -v --log log.txt and attach log.txt)

[sdev138]

Any html file with any content will reproduce this. I have some issues getting into verbose mode, but once I have the log.txt i'll put it in the discussion.

[foxmean]

I can reproduce with the same helix version (Via homebrew) on MacBook Air M1 macOS 15.1.1 (24B91) with Alacritty and Zelij.
Note: only :wq command that freeze the program. If I only use :w then :q, it works just fine with autoformatting after :w. The bug is only occur with html for me now. (rust & haskell works just fine).
The log file is below

2024-11-27T11:17:52.028 helix_lsp::client [INFO] Using custom LSP config: {"provideFormatter":true}
2024-11-27T11:17:52.030 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"general":{"positionEncodings":["utf-8","utf-32","utf-16"]},"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"dataSupport":true,"disabledSupport":true,"isPreferredSupport":true,"resolveSupport":{"properties":["edit","command"]}},"completion":{"completionItem":{"deprecatedSupport":true,"insertReplaceSupport":true,"resolveSupport":{"properties":["documentation","detail","additionalTextEdits"]},"snippetSupport":true,"tagSupport":{"valueSet":[1]}},"completionItemKind":{}},"formatting":{"dynamicRegistration":false},"hover":{"contentFormat":["markdown"]},"inlayHint":{"dynamicRegistration":false},"publishDiagnostics":{"tagSupport":{"valueSet":[1,2]},"versionSupport":true},"rename":{"dynamicRegistration":false,"honorsChangeAnnotations":false,"prepareSupport":true},"signatureHelp":{"signatureInformation":{"activeParameterSupport":true,"documentationFormat":["markdown"],"parameterInformation":{"labelOffsetSupport":true}}}},"window":{"workDoneProgress":true},"workspace":{"applyEdit":true,"configuration":true,"didChangeConfiguration":{"dynamicRegistration":false},"didChangeWatchedFiles":{"dynamicRegistration":true,"relativePatternSupport":false},"executeCommand":{"dynamicRegistration":false},"fileOperations":{"didRename":true,"willRename":true},"inlayHint":{"refreshSupport":false},"symbol":{"dynamicRegistration":false},"workspaceEdit":{"documentChanges":true,"failureHandling":"abort","normalizesLineEndings":false,"resourceOperations":["create","rename","delete"]},"workspaceFolders":true}},"clientInfo":{"name":"helix","version":"24.7 (079f5442)"},"initializationOptions":{"provideFormatter":true},"processId":29914,"rootPath":"/Users/pkmean/Desktop/codes-lab/rust/the-book/hello","rootUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello","workspaceFolders":[{"name":"hello","uri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello"}]},"id":0}
2024-11-27T11:17:52.379 helix_lsp::transport [INFO] vscode-html-language-server <- {"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"completionProvider":{"resolveProvider":true,"triggerCharacters":[".",":","<","\"","=","/"]},"hoverProvider":true,"documentHighlightProvider":true,"documentRangeFormattingProvider":true,"documentFormattingProvider":true,"documentLinkProvider":{"resolveProvider":false},"documentSymbolProvider":true,"definitionProvider":true,"signatureHelpProvider":{"triggerCharacters":["("]},"referencesProvider":true,"colorProvider":{},"foldingRangeProvider":true,"selectionRangeProvider":true,"renameProvider":true,"linkedEditingRangeProvider":true,"diagnosticProvider":{"documentSelector":null,"interFileDependencies":false,"workspaceDiagnostics":false}}}}
2024-11-27T11:17:52.379 helix_lsp::transport [INFO] vscode-html-language-server <- {"capabilities":{"colorProvider":{},"completionProvider":{"resolveProvider":true,"triggerCharacters":[".",":","<","\"","=","/"]},"definitionProvider":true,"diagnosticProvider":{"documentSelector":null,"interFileDependencies":false,"workspaceDiagnostics":false},"documentFormattingProvider":true,"documentHighlightProvider":true,"documentLinkProvider":{"resolveProvider":false},"documentRangeFormattingProvider":true,"documentSymbolProvider":true,"foldingRangeProvider":true,"hoverProvider":true,"linkedEditingRangeProvider":true,"referencesProvider":true,"renameProvider":true,"selectionRangeProvider":true,"signatureHelpProvider":{"triggerCharacters":["("]},"textDocumentSync":2}}
2024-11-27T11:17:52.379 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"initialized","params":{}}
2024-11-27T11:17:52.379 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{"provideFormatter":true}}}
2024-11-27T11:17:52.379 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"html","text":"<!DOCTYPE html>\n<html lang=\"en\">\n\n<head>\n  <meta charset=\"utf-8\">\n  <title>Hello!</title>\n</head>\n\n<body>\n  <h1>Oops!</h1>\n  <p>Sorry, I don't know what you're asking for.</p>\n</body>\n\n</html>\n","uri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","version":0}}}
2024-11-27T11:17:52.380 helix_lsp::transport [INFO] vscode-html-language-server <- {"jsonrpc":"2.0","id":0,"method":"client/registerCapability","params":{"registrations":[{"id":"6a5a2874-c1bc-4348-9c16-1ac27819a405","method":"workspace/didChangeWorkspaceFolders","registerOptions":{}}]}}
2024-11-27T11:17:52.380 helix_term::application [WARN] Ignoring a client/registerCapability request because dynamic capability registration is not enabled. Please report this upstream to the language server
2024-11-27T11:17:52.380 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","result":null,"id":0}
2024-11-27T11:17:52.890 helix_lsp::transport [INFO] vscode-html-language-server <- {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","diagnostics":[]}}
2024-11-27T11:17:53.990 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"textDocument/formatting","params":{"options":{"insertSpaces":true,"tabSize":2},"textDocument":{"uri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html"}},"id":1}
2024-11-27T11:17:53.993 helix_lsp::transport [INFO] vscode-html-language-server <- {"jsonrpc":"2.0","id":1,"method":"workspace/configuration","params":{"items":[{"scopeUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","section":"css"},{"scopeUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","section":"html"},{"scopeUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","section":"javascript"},{"scopeUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","section":"js/ts"}]}}
2024-11-27T11:18:13.991 helix_view::document [WARN] LSP formatting failed: request 1 timed out
2024-11-27T11:18:14.000 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"textDocument/didSave","params":{"textDocument":{"uri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html"}}}
2024-11-27T11:18:14.001 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"shutdown","id":2}
2024-11-27T11:18:14.003 helix_lsp::transport [INFO] vscode-html-language-server <- {"jsonrpc":"2.0","id":2,"result":null}
2024-11-27T11:18:14.003 helix_lsp::transport [INFO] vscode-html-language-server <- null
2024-11-27T11:18:14.003 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"exit"}

[the-mikedavis]

Thanks for the logs! These lines look noteworthy:

2024-11-27T11:17:53.990 helix_lsp::transport [INFO] vscode-html-language-server -> {"jsonrpc":"2.0","method":"textDocument/formatting","params":{"options":{"insertSpaces":true,"tabSize":2},"textDocument":{"uri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html"}},"id":1}
2024-11-27T11:17:53.993 helix_lsp::transport [INFO] vscode-html-language-server <- {"jsonrpc":"2.0","id":1,"method":"workspace/configuration","params":{"items":[{"scopeUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","section":"css"},{"scopeUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","section":"html"},{"scopeUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","section":"javascript"},{"scopeUri":"file:///Users/pkmean/Desktop/codes-lab/rust/the-book/hello/404.html","section":"js/ts"}]}}
2024-11-27T11:18:13.991 helix_view::document [WARN] LSP formatting failed: request 1 timed out

It looks like we might be locking up since the server wants the response to workspace/configuration while we're blocking on the response to textDocument/formatting. I've added an issue #12176 to track the cause and fix for the bug