Commit 71df242 broke syntax highlighting for bash

[arut-plus]

Summary

No code highlighting for bash due to changes in the runtime/queries/bash/highlights.scm file because of this commit: 71df242
I undid the changes that were made in commit (71df242) and the code highlighting for bash came back.

Reproduction Steps

No response

Helix log

~/.cache/helix/helix.log

2025-01-07T14:34:54.911 helix_core::syntax [ERROR] Could not parse queries for language "bash". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 3, column: 3, offset: 31, message: "ansi_c_string", kind: NodeType }
2025-01-07T14:36:45.065 helix_core::syntax [ERROR] Could not parse queries for language "bash". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 9, column: 3, offset: 99, message: "heredoc_end", kind: NodeType }

Platform

Linux

Terminal Emulator

alacritty 0.14.0

Installation Method

source

Helix Version

helix 25.01 (e698b20)

[David-Else]

Please could you give an example of a file that breaks the syntax highlighting? It seems like your bash grammar is old and does not support "ansi_c_string", it is working fine for me built from source. Did you follow the advice of the error message?

git pull
git checkout 25.01
cargo install --path helix-term --locked

echo Hello $'\t' World

[arut-plus]

Of course, I ran hx -g fetch and hx -g build, but that didn't help.

# grammars do exist
➜ ls ~/src/helix/runtime/grammars/*.so | wc -l
216
➜ grep HELIX_RUNTIME ~/.zshenv
export HELIX_RUNTIME="${HOME}/src/helix/runtime"

I don't really understand what you're specifically talking about: “your bash grammar is old” - how do I update “bash grammar” then? Are you talking about the bash.so file?

If you mean that the code itself is probably old, then no - everything is up to the standards of the latest versions and best practices of bash:

And the error is still the same in ~/.cache/helix/helix.log:

2025-01-07T17:06:18.510 helix_core::syntax [ERROR] Could not parse queries for language "bash". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 3, column: 3, offset: 31, message: "ansi_c_string", kind: NodeType }

[the-mikedavis]

bash.so and runtime/queries/bash/*.scm need to be from the same Helix version. When you see the error message "Could not parse queries for language "bash". Are your grammars out of sync?" that means that your compiled parser (bash.so) is from a different version than the queries. In this case it sounds like the parser is too old because it doesn't recognize a new capture in the queries so you can try removing bash.so and running hx -g build again.

[arut-plus]

I see what you mean - tried everything you suggested, but it didn't work. For the sake of clarity, I reinstalled helix following the instructions in the documentation (I even built grammars again), but the problem persisted. I tried everything suggested in the “Troubleshooting - Missing syntax highlighting” section, but that didn't help either.
I thought that just by strictly following the source build instructions I could avoid this error, but it didn't work.
Anyway, it's not a disaster, I can still roll back the .scm file I need (or just use the pre-built binaries) and still use helix - I just thought it was a bug, that's why I reported it in issues.

By the way, sincere thanks to everyone who contributed to helix-editor ❤️