"sizeof()" snippet does not expand correctly in Helix 25.01

[ZennMystic]

Summary

I have never done this before, so sorry if I did wrong or wrong place. No offense intend.

In Helix 25.01, when selecting the sizeof(expression-or-type) snippet, the placeholder text expression-or-type does not get replaced when typing a value. This results in incorrect code like sizeof(numberexpression-or-type) instead of sizeof(number).

This issue does not occur in versions 24.03 and 24.07.

Steps to Reproduce:

Open a C file in Helix 25.01.
Type siz and select the sizeof(expression-or-type) snippet.
Attempt to replace the placeholder.
Notice that the placeholder remains (sizeof(numberexpression-or-type)).

Expected Behavior:

The snippet should correctly replace the placeholder, resulting in sizeof(number).

Environment:

Helix Version: 25.01
OS: Debian 12
Install Method: Nix

Reproduction Steps

I tried this:

1. hx

I expected this to happen:

Instead, this happened:

Helix log

~/.cache/helix/helix.log

please provide a copy of `~/.cache/helix/helix.log` here if possible, you may need to redact some of the lines

Platform

Linux

Terminal Emulator

wezterm

Installation Method

nixpks

Helix Version

helix 25.01

[the-mikedavis]

I couldn't reproduce this locally. What does the log say when running in verbose mode? hx -v --log log.txt and attach log.txt

[ZennMystic]

Here is the log you asked for.

log.txt

[the-mikedavis]

I reproduced this with clangd version 14 and I think it's a Helix bug with how we interpret snippet tabstops. I'm looking into a fix but a workaround could be to update clangd if that's an option for you. clangd version 19 (which you can get through nixpkgs' clang-tools package) sends a slightly different snippet which works as expected.

Edit: the fix is here #12640

[pascalkuthe]

This is actually a hug in clangd14 (that is fixed on newer versions). The $0 tabstop is not allowed to have a placeholder. We will make our snippet handling more robust to simply discard the placeholder for invalid snippets like this but really the issue was caused by thjs (fairly old) clangd version sending an invalid snippet

[ZennMystic]

Yea I undated clangd and everything worked fine after that. Thank You for your time.