Syntax Highlighting Error

[jeanersten]

Hi, i've been trying to move on from Neovim to Helix, for how simple it is to configure and features that built in to it, this editor is a perfect concept, it seems that many people is so excited about Helix too. Anyway I'm trying to make my own helix theme, and faced this issue:

1. Destrcutor highlighted like normal object / variable. As far as I know destructor is still a function, all my theme settings set function to same color (yellowish) like in the picture.
   

2. Scoped variable like in the picture, std::cout, Krone::variable, don't interpreted correctly, I think it falls back to color of ui.text for some reason.
   

3. In few case, function call colors also falls back to ui.text color, for example If function is located in scoped namespace / double namespace, like Krone::Alright::Function();.
   

4. Last, the color for shell command output (popup that showed after running :run-shell-command) is a bit weird, the first string always get colored, and there's unexpected color going on, which a bit messy in my opinion.
   

I am on Windows 10, installing Helix from winget, and already configured the runtime directory, I also ran helix --health and everything seems fine, I also tried to change the theme to Helix builtin one, and result the same. I am sorry to be perfectionist because I can't see things that is almost perfect but end up not 😭. I'm looking forward if there's solution or not, thanks!

Also thanks to Helix dev, this is by far the most comfortable modal based text-editor, it is also really fast, responsive and easy to configure :D

[CalebLarsen]

I made some recent c++ highlighting changes, would you mind building from source and then reporting back what things are still being highlighted wrong?

One question I had in the meantime is what is the right thing to do with destructors? Should they be highlighted as constructors?

[CalebLarsen]

So problems I've looked into are:

• namespaced variables
• namespaced functions
• constructors/destructors

Is there anything I'm missing?

[jeanersten]

I see... Yes! I think highlighting it as variable will make more sense, because variables are practically used more too, I don't have that much C++ experience too, but for the last 6 months, I used nested namespace between 2 to 3 namespace layers at max depends on the functional context, so limiting it at 4 / 5 will be safe in my opinion, but if that changes so much things to be hard-coded or something that will affect the future highlighting, I think 3 layers is okay too!

[jeanersten]

So problems I've looked into are:

• namespaced variables
• namespaced functions
• constructors/destructors

Is there anything I'm missing?

Just a few minutes ago i found that nested namespace also being treated incorrectly in using statement for example:

as you can see, I think both namespace should have the same color, I think I'll put that on the list if the problem persist in the different Helix code! hehe..

[CalebLarsen]

This is what I have now:

I'm going to give it a day to see if any more weird highlights show up, and then I'll make the PR.

[jeanersten]

Yay! Okay, thank you sir!