Jumplist entries for using ex-mode for line navigation.

[askreet]

When I use, for example, :123 to navigate to line number 123 Helix will jump to line 1, then line 12 and finally line 123 as I type. Each time it navigates as I type an entry is placed into the jumplist so that once I'm done with line 123 pressing C-o jumps to line 12, then line 1, then finally back to where I was before I started my journey.

A couple questions for the community:

1. Is there a configuration option to disable jumping as a number is typed? I actually find it quite jarring in a large file to jump way to the top, then progressively back toward where I want to go.
2. Separately, is it possible not to add the intermediate lines to the jumplist?
3. Is all of this the intended behavior, or something that should land in an Issue?

Thanks in advance!

[the-mikedavis]

The code for this function is here:

helix/helix-term/src/commands/typed.rs

Lines 1413 to 1455 in c9b583e

	pub(super) fn goto_line_number(
	cx: &mut compositor::Context,
	args: &[Cow<str>],
	event: PromptEvent,
	) -> anyhow::Result<()> {
	match event {
	PromptEvent::Abort => {
	if let Some(line_number) = cx.editor.last_line_number {
	goto_line_impl(cx.editor, NonZeroUsize::new(line_number));
	let (view, doc) = current!(cx.editor);
	view.ensure_cursor_in_view(doc, line_number);
	cx.editor.last_line_number = None;
	}
	return Ok(());
	}
	PromptEvent::Validate => {
	ensure!(!args.is_empty(), "Line number required");
	cx.editor.last_line_number = None;
	}
	PromptEvent::Update => {
	if args.is_empty() {
	if let Some(line_number) = cx.editor.last_line_number {
	// When a user hits backspace and there are no numbers left,
	// we can bring them back to their original line
	goto_line_impl(cx.editor, NonZeroUsize::new(line_number));
	let (view, doc) = current!(cx.editor);
	view.ensure_cursor_in_view(doc, line_number);
	cx.editor.last_line_number = None;
	}
	return Ok(());
	}
	let (view, doc) = current!(cx.editor);
	let text = doc.text().slice(..);
	let line = doc.selection(view.id).primary().cursor_line(text);
	cx.editor.last_line_number.get_or_insert(line + 1);
	}
	}
	let line = args[0].parse::<usize>()?;
	goto_line_impl(cx.editor, NonZeroUsize::new(line));
	let (view, doc) = current!(cx.editor);
	view.ensure_cursor_in_view(doc, line);
	Ok(())
	}

The goto_line_impl helper pushes an entry to the jumplist. For this case we should only push a new jumplist entry when the PromptEvent is PromptEvent::Validate (happens when you hit Return).

There isn't currently a way to disable this behavior. It would be nice to debounce it, maybe using the idle-timeout.

[askreet]

Thanks, Mike. I'm going to try my hand at adding this.

[askreet]

Cross-linking #5751 as resolving the intermediate bit.

[CptPotato]

I personally like to use 123gg (alternatively g123g) to jump to a specific line.

It doesn't have a preview, though.

[askreet]

Thanks! I knew there was probably another key combo for this. 👍🏼