Deno LSP gives no-cache-npm for npm: imports

[kj]

Summary

The Deno LSP is giving me an error for npm: imports, which doesn't happen in VS Code. If you modify the buffer at all, e.g. add a blank line, the LSP error goes away and everything is fine.

I have the following configuration in the project's .helix/languages.toml file:

[language-server.deno-lsp]
command = 'deno'
args = ['lsp']
config = { enable = true, unstable = true }

[[language]]
name = 'javascript'
shebangs = ['deno', 'node']
roots = ['deno.json', 'package.json']
language-id = 'javascript'
language-servers = ['deno-lsp']

[[language]]
name = 'jsx'
shebangs = ['deno', 'node']
roots = ['deno.json', 'package.json']
language-id = 'javascriptreact'
language-servers = ['deno-lsp']

[[language]]
name = 'typescript'
shebangs = ['deno', 'node']
roots = ['deno.json', 'package.json', 'tsconfig.json']
language-id = 'typescript'
language-servers = ['deno-lsp']

[[language]]
name = 'tsx'
shebangs = ['deno', 'node']
roots = ['deno.json', 'package.json', 'tsconfig.json']
language-id = 'typescriptreact'
language-servers = ['deno-lsp']

I have the following imports:

import { isInSubnet } from 'npm:[email protected]';
import { parse } from 'npm:[email protected]';
import { z } from 'npm:[email protected]';

If I import from esm.sh instead, there is no problem:

import { isInSubnet } from 'https://esm.sh/[email protected]';
import { parse } from 'https://esm.sh/[email protected]';
import { z } from 'https://esm.sh/[email protected]';

Reproduction Steps

No response

Helix log

2023-05-22T03:53:44.174 helix_lsp::transport [ERROR] deno-lsp err <- "Starting Deno language server...\n"
2023-05-22T03:53:44.174 helix_lsp::transport [ERROR] deno-lsp err <- "  version: 1.33.4 (release, x86_64-unknown-linux-gnu)\n"
2023-05-22T03:53:44.174 helix_lsp::transport [ERROR] deno-lsp err <- "  executable: /home/kelsey/.local/bin/deno\n"
2023-05-22T03:53:44.174 helix_lsp::transport [ERROR] deno-lsp err <- "Connected to \"helix\" 23.05 (d3cca0f3)\n"
2023-05-22T03:53:44.347 helix_lsp::transport [ERROR] deno-lsp err <- "Error converting specifier settings: invalid type: null, expected struct SpecifierSettings\n"
2023-05-22T03:53:44.357 helix_lsp::transport [ERROR] deno-lsp err <- "Server ready.\n"
2023-05-22T03:53:44.357 helix_lsp::transport [ERROR] deno-lsp err <- "Error converting specifier settings: invalid type: null, expected struct SpecifierSettings\n"
2023-05-22T03:53:44.357 helix_lsp::transport [ERROR] deno-lsp err <- "Error converting specifier settings (file:///home/kelsey/projects/js/nebula-generate-hosts/nebula-generate-hosts): Error converting specifier settings: invalid type: null, expected struct SpecifierSettings\n"
2023-05-22T03:53:44.358 helix_lsp::transport [ERROR] deno-lsp err <- "failed to update settings: invalid type: null, expected struct WorkspaceSettings\n"

Platform

Linux

Terminal Emulator

alacritty

Helix Version

23.05-47-gd3cca0f3

[iceghost]

I have the same error in the log. The LSP is working, but unstable features do not work - I can not use Deno.Kv this way.

[iceghost]

Reproduce this by creating a new fresh project (deno run -A -r https://fresh.deno.dev), and then try to use Deno.Kv inside. The LSP won't be able to find it.

[kj]

For whatever reason I don't seem to be having this problem anymore, with the same code above and using:

$ hx --version
helix 23.05 (d3cca0f3)

$ deno --version
deno 1.35.1 (release, x86_64-unknown-linux-gnu)
v8 11.6.189.7
typescript 5.1.6

Edit: Issue is still happening. See below.

[igor-petruk]

I have this problem, no way to use Deno with helix even with hello world. OpenBSD, but the same error

❯ hx --version
helix 23.05
❯ deno --version
deno 1.32.5 (release, x86_64-unknown-openbsd)
v8 11.2.214.9
typescript 5.0.3

[igor-petruk]

Ok, this is fixed in Deno roughly on June 6th, mine was older.

[kj]

Okay, nope, I'm seeing this again. Deno 1.35.3 (released 4 days ago). Same behaviour. On startup, diagnostics show:

Uncached or missing npm package: [email protected] (no-cache-npm)

-until I modify the buffer, then it gets picked up and the diagnostic error goes away. This time I'm using an import map in deno.json, but the first time I wasn't so I don't think that has anything to do with it.

[sanrafa]

I'm on Deno 1.37.0 and ran into this issue. If it helps anyone, I was able to make the error go away by running

deno cache npm:$PKG_NAME

ETA: If it matters, this was a vanilla JS project running with the deno-lsp