Workspace symbol picker not getting more symbols until current batch has no matches

[willhansen]

Summary

The workspace symbol picker is not getting new symbols while typing until there are no matches from the current batch.

The single-file symbol picker seems to be working fine.

The symbol counter in the top right of the left pane of the picker is also updating strangely. While the single-file picker narrows down from the original number, like 400/400 --> 24/400, the workspace picker has both numbers go down, like 128/128 --> 22/22. Even accounting for an unknown initial total number of symbols, I would expect the number to stick at 128/128 until I narrow down enough and the count would drop to something like 22/128.

• Probably would better represent the unknown initial number of symbols as 128/?, but that's a tangent.

Reproduction Steps

I tried this:

In a big rust file with way more than 128 symbols.
Several of the function names start with can_

1. hx
2. <space>S
   • Here, I see the expected initial 128 symbols
3. can
   • I'm expecting to see my functions that start with can
   • Instead, I see only a handful of symbols from the initial 128 that fuzzy match can (not great matches. stuff like Octant)
   • Note that none of this handful contain _ (important for the next step)
4. _
   • I see the expected functions that start with can_
5. <backspace> (the picker input is now back to can)
   • I see the picker state as it was in step 4.
6. _ (picker input is now can_)
   • Picker now appears as it did in step 5.

Helix log

1. rm ~/.cache/helix/helix.log
2. Did reproduction steps above
3. Log file was created, but empty

Platform

NixOS 23.05

Terminal Emulator

alacritty 0.13.0-dev

Helix Version

helix 23.05

[the-mikedavis]

What does the log say when running in verbose mode? hx -v

Do you have the editor.idle-timeout config option customized in your config?

[willhansen]

I have editor.idle-timeout set to 0

With hx -v I get lines like

2023-08-07T18:41:27.847 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"workspace/symbol","params":{"query":"can_"},"id":14}

followed by the query results

2023-08-07T18:41:27.871 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":14,"result":[{"name":...

I'll try this on a file where I don't care about pasting all the code.

---

Edit:

In a twist that probably does not surprise you at all, I can't reproduce this in a file generated by this python script:

#!/usr/bin/env python3

with open("main.rs", "w") as file:
    file.write('fn main() {println!("asdf");}\n')
    for i in range(30000):
        file.write('fn a' + str(i) + '() {println!("asdf");}\n')

---

Edit 2:

Or this one:

#!/usr/bin/env python3

n = 3000
otherfiles = ["b", "c", "d", "e", "f"]
with open("main.rs", "w") as file:
    for name in otherfiles:
        file.write('mod '+name+';\n')
    file.write('fn main() {println!("asdf");}\n')
    for i in range(n):
        file.write('fn a' + str(i) + '() {println!("asdf");}\n')

for name in otherfiles:
    with open(name+".rs", "w") as file:
        for i in range(n):
            file.write('fn ' + name + str(i) + '() {println!("asdf");}\n')

[willhansen]

rust-analyzer 2023-07-17

[willhansen]

Here's the start of the verbose log:

2023-08-07T22:07:04.664 helix_lsp::client [INFO] Using custom LSP config: {"inlayHints":{"bindingModeHints":{"enable":false},"closingBraceHints":{"minLines":10},"closureReturnTypeHints":{"enable":"with_block"},"discriminantHints":{"enable":"fieldless"},"lifetimeElisionHints":{"enable":"skip_trivial"},"typeHints":{"hideClosureInitialization":false}}}
2023-08-07T22:07:04.665 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"general":{"positionEncodings":["utf-8","utf-32","utf-16"]},"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}}},"completion":{"completionItem":{"deprecatedSupport":true,"insertReplaceSupport":true,"resolveSupport":{"properties":["documentation","detail","additionalTextEdits"]},"snippetSupport":true,"tagSupport":{"valueSet":[1]}},"completionItemKind":{}},"hover":{"contentFormat":["markdown"]},"inlayHint":{"dynamicRegistration":false},"publishDiagnostics":{"versionSupport":true},"rename":{"dynamicRegistration":false,"honorsChangeAnnotations":false,"prepareSupport":true},"signatureHelp":{"signatureInformation":{"activeParameterSupport":true,"documentationFormat":["markdown"],"parameterInformation":{"labelOffsetSupport":true}}}},"window":{"workDoneProgress":true},"workspace":{"applyEdit":true,"configuration":true,"didChangeConfiguration":{"dynamicRegistration":false},"executeCommand":{"dynamicRegistration":false},"inlayHint":{"refreshSupport":false},"symbol":{"dynamicRegistration":false},"workspaceEdit":{"documentChanges":true,"failureHandling":"abort","normalizesLineEndings":false,"resourceOperations":["create","rename","delete"]},"workspaceFolders":true}},"clientInfo":{"name":"helix","version":"23.05"},"initializationOptions":{"inlayHints":{"bindingModeHints":{"enable":false},"closingBraceHints":{"minLines":10},"closureReturnTypeHints":{"enable":"with_block"},"discriminantHints":{"enable":"fieldless"},"lifetimeElisionHints":{"enable":"skip_trivial"},"typeHints":{"hideClosureInitialization":false}}},"processId":303800,"rootPath":"[REDACTED]","rootUri":"[REDACTED]","workspaceFolders":[{"name":"[REDACTED]","uri":"[REDACTED]"}]},"id":0}
2023-08-07T22:07:04.677 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":0,"result":{"capabilities":{"positionEncoding":"utf-8","textDocumentSync":{"openClose":true,"change":2,"save":{}},"selectionRangeProvider":true,"hoverProvider":true,"completionProvider":{"resolveProvider":true,"triggerCharacters":[":",".","'","("],"completionItem":{"labelDetailsSupport":false}},"signatureHelpProvider":{"triggerCharacters":["(",",","<"]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":{"codeActionKinds":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite"],"resolveProvider":true},"codeLensProvider":{"resolveProvider":true},"documentFormattingProvider":true,"documentRangeFormattingProvider":false,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":"=","moreTriggerCharacter":[".",">","{"]},"renameProvider":{"prepareProvider":true},"foldingRangeProvider":true,"declarationProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":true},"fileOperations":{"willRename":{"filters":[{"scheme":"file","pattern":{"glob":"**/*.rs","matches":"file"}},{"scheme":"file","pattern":{"glob":"**","matches":"folder"}}]}}},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["comment","decorator","enumMember","enum","function","interface","keyword","macro","method","namespace","number","operator","parameter","property","string","struct","typeParameter","variable","angle","arithmetic","attribute","attributeBracket","bitwise","boolean","brace","bracket","builtinAttribute","builtinType","character","colon","comma","comparison","constParameter","derive","deriveHelper","dot","escapeSequence","formatSpecifier","generic","label","lifetime","logical","macroBang","parenthesis","punctuation","selfKeyword","selfTypeKeyword","semicolon","typeAlias","toolModule","union","unresolvedReference"],"tokenModifiers":["documentation","declaration","static","defaultLibrary","async","attribute","callable","constant","consuming","controlFlow","crateRoot","injected","intraDocLink","library","macro","mutable","public","reference","trait","unsafe"]},"range":true,"full":{"delta":true}},"inlayHintProvider":{"resolveProvider":true},"experimental":{"externalDocs":true,"hoverRange":true,"joinLines":true,"matchingBrace":true,"moveItem":true,"onEnter":true,"openCargoToml":true,"parentModule":true,"runnables":{"kinds":["cargo"]},"ssr":true,"workspaceSymbolScopeKindFiltering":true}},"serverInfo":{"name":"rust-analyzer","version":"2023-07-17"}}}
2023-08-07T22:07:04.677 helix_lsp::transport [INFO] <- {"capabilities":{"callHierarchyProvider":true,"codeActionProvider":{"codeActionKinds":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite"],"resolveProvider":true},"codeLensProvider":{"resolveProvider":true},"completionProvider":{"completionItem":{"labelDetailsSupport":false},"resolveProvider":true,"triggerCharacters":[":",".","'","("]},"declarationProvider":true,"definitionProvider":true,"documentFormattingProvider":true,"documentHighlightProvider":true,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":"=","moreTriggerCharacter":[".",">","{"]},"documentRangeFormattingProvider":false,"documentSymbolProvider":true,"experimental":{"externalDocs":true,"hoverRange":true,"joinLines":true,"matchingBrace":true,"moveItem":true,"onEnter":true,"openCargoToml":true,"parentModule":true,"runnables":{"kinds":["cargo"]},"ssr":true,"workspaceSymbolScopeKindFiltering":true},"foldingRangeProvider":true,"hoverProvider":true,"implementationProvider":true,"inlayHintProvider":{"resolveProvider":true},"positionEncoding":"utf-8","referencesProvider":true,"renameProvider":{"prepareProvider":true},"selectionRangeProvider":true,"semanticTokensProvider":{"full":{"delta":true},"legend":{"tokenModifiers":["documentation","declaration","static","defaultLibrary","async","attribute","callable","constant","consuming","controlFlow","crateRoot","injected","intraDocLink","library","macro","mutable","public","reference","trait","unsafe"],"tokenTypes":["comment","decorator","enumMember","enum","function","interface","keyword","macro","method","namespace","number","operator","parameter","property","string","struct","typeParameter","variable","angle","arithmetic","attribute","attributeBracket","bitwise","boolean","brace","bracket","builtinAttribute","builtinType","character","colon","comma","comparison","constParameter","derive","deriveHelper","dot","escapeSequence","formatSpecifier","generic","label","lifetime","logical","macroBang","parenthesis","punctuation","selfKeyword","selfTypeKeyword","semicolon","typeAlias","toolModule","union","unresolvedReference"]},"range":true},"signatureHelpProvider":{"triggerCharacters":["(",",","<"]},"textDocumentSync":{"change":2,"openClose":true,"save":{}},"typeDefinitionProvider":true,"workspace":{"fileOperations":{"willRename":{"filters":[{"pattern":{"glob":"**/*.rs","matches":"file"},"scheme":"file"},{"pattern":{"glob":"**","matches":"folder"},"scheme":"file"}]}},"workspaceFolders":{"changeNotifications":true,"supported":true}},"workspaceSymbolProvider":true},"serverInfo":{"name":"rust-analyzer","version":"2023-07-17"}}
2023-08-07T22:07:04.677 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"initialized","params":{}}
2023-08-07T22:07:04.677 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{"inlayHints":{"bindingModeHints":{"enable":false},"closingBraceHints":{"minLines":10},"closureReturnTypeHints":{"enable":"with_block"},"discriminantHints":{"enable":"fieldless"},"lifetimeElisionHints":{"enable":"skip_trivial"},"typeHints":{"hideClosureInitialization":false}}}}}
2023-08-07T22:07:04.677 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"languageId":"rust","text":

[gabydd]

oh this is interesting (rust-lang/rust-analyzer#13114) when I use the setting recommend in this issue I get some missing symbols that I could only get when typing almost the full name doing workspace symbol search in helix, maybe that will help your case as well?

edit: also see rust-lang/rust-analyzer#14553

[willhansen]

Looks like rust-analyzer has a default bias towards structs that the local symbol picker does not share.

With a file generated by this script:

#!/usr/bin/env python3

n = 300
with open("main.rs", "w") as file:
    file.write('fn main() {println!("asdf");}\n')
    for i in range(n):
        file.write('fn a' + str(i) + '_snake_func() {println!("asdf");}\n')
        file.write('fn a' + str(i) + 'CamelFunc() {println!("asdf");}\n')
        file.write('struct a' + str(i) + '_snake_struct();\n')
        file.write('struct a' + str(i) + 'CamelStruct();\n')

Workspace symbol picker:

Single-file symbol picker:

---

Edit:

Currently trying to apply the configuration option for "rust-analyzer.workspace.symbol.search.kind": "all_symbols", but I'm not sure I'm applying it correctly.

Edit 2:

The option was config.workspace.symbol.search.kind = "all_symbols", right under the name = "rust" line in the language config.

Fixes the workspace symbol picker right up.