Not all hints are shown in the editor

[thomasnappee]

Summary

Hello !

Using space + a, I expect to find the impl Type for TYPE hint. Only Extract type as type alias is shown on Helix. VSCode shows all the hints.

In the Helix's logs given further, you can see that the hint is computed by the analyzer and received by Helix, but it doesn't seems to be well processed

Thanks for this super editor

Reproduction Steps

No particular step to reproduce the bug

Helix log

~/.cache/helix/helix.log

2023-09-30T23:00:45.933 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"textDocument/codeAction","params":{"context":{"diagnostics":[],"triggerKind":1},"range":{"end":{"character":23,"line":59},"start":{"character":22,"line":59}},"textDocument":{"uri":"file:///operations.rs"}},"id":1}
2023-09-30T23:00:45.935 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":1,"result":[{"title":"Extract type as type alias","kind":"refactor.extract","edit":{"documentChanges":[{"textDocument":{"uri":"file:///operations.rs","version":0},"edits":[{"range":{"start":{"line":59,"character":4},"end":{"line":59,"character":8}},"newText":"type"},{"range":{"start":{"line":59,"character":9},"end":{"line":59,"character":9}},"newText":"Type = "},{"range":{"start":{"line":59,"character":27},"end":{"line":59,"character":57}},"newText":";\n\n    impl Type for PersistencyServiceMock {}"}]}]}}]}
2023-09-30T23:00:45.935 helix_lsp::transport [INFO] <- [{"edit":{"documentChanges":[{"edits":[{"newText":"type","range":{"end":{"character":8,"line":59},"start":{"character":4,"line":59}}},{"newText":"Type = ","range":{"end":{"character":9,"line":59},"start":{"character":9,"line":59}}},{"newText":";\n\n    impl Type for PersistencyServiceMock {}","range":{"end":{"character":57,"line":59},"start":{"character":27,"line":59}}}],"textDocument":{"uri":"file:///operations.rs","version":0}}]},"kind":"refactor.extract","title":"Extract type as type alias"}]

Platform

Linux - Manjaro 23.0.2 (I use arch btw)

Terminal Emulator

alacritty 0.12.2 (9d9982df)

Helix Version

helix 23.05

[pascalkuthe]

that assist is not sent by RA in the logs you provided (and I am not sure what hint you are talking about). If you look at the json sent by the server in the log file there is only a single action:

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": [
    {
      "title": "Extract type as type alias",
      "kind": "refactor.extract",
      "edit": {
        "documentChanges": [
          {
            "textDocument": {
              "uri": "file:///operations.rs",
              "version": 0
            },
            "edits": [
              {
                "range": {
                  "start": {
                    "line": 59,
                    "character": 4
                  },
                  "end": {
                    "line": 59,
                    "character": 8
                  }
                },
                "newText": "type"
              },
              {
                "range": {
                  "start": {
                    "line": 59,
                    "character": 9
                  },
                  "end": {
                    "line": 59,
                    "character": 9
                  }
                },
                "newText": "Type = "
              },
              {
                "range": {
                  "start": {
                    "line": 59,
                    "character": 27
                  },
                  "end": {
                    "line": 59,
                    "character": 57
                  }
                },
                "newText": ";\n\n    impl Type for PersistencyServiceMock {}"
              }
            ]
          }
        ]
      }
    }
  ]

code actions are very simply we only display those that the LSP sends to us. Some RA codeactions require some non-standard LSP extensions. These are not sent if the client doesn't support them (or really is anything but vscode) so it may be one of those. That can't be supported in helix. Another reason may be a version mismatch. If you are using RA from the stable toolchain that is likely significantly outdated (vscode always downloaded the latest release automatically in the background)

[thomasnappee]

The action I'm talking about is the one that automatically write the functions prototypes when you want to implement a trait. You can see it at the end of the json : "newText": ";\n\n impl Type for PersistencyServiceMock {}".

What I supposed is that it should be in the result field of the payload, since it's a known and common codeaction. If you see which codeaction I'm talking about now, is that non-standard LSP ?

Moreover, I'm using RA from the nightly toolchain