Can't install from source - 2 grammars failed to build

[KhazAkar]

Summary

When building using cargo --release --workspace, it fails to build with "thread 'main' panicked at 'Failed to compile tree-sitter grammars: 2 grammars failed to build', helix-term/build.rs:7:14"

Building fails for D language and rescript.

Reproduction Steps

I tried this:

1. Clone helix repo
2. Run cargo build --workspace --release

I expected this to happen:
Build helix properly

Instead, this happened:
Failure to compile tree-sitter

Additionally:
git version: 2.42.0

Helix log

Console log

159 grammars built now
        ["astro", "awk", "bash", "bass", "beancount", "bibtex", "bicep", "blueprint", "c", "c-sharp", "capnp", "clojure", "cmake", "comment", "cpon", "cpp", "css", "cue", "dart", "devicetree", "dhall", "diff", "dockerfile", "dot", "dtd", "edoc", "eex", "elixir", "elm", "elvish", "embedded-template", "erlang", "esdl", "fish", "forth", "fortran", "fsharp", "gas", "gdscript", "gemini", "git-commit", "git-config", "git-rebase", "gitattributes", "gitignore", "gleam", "glsl", "go", "godot-resource", "gomod", "gotmpl", "gowork", "graphql", "hare", "haskell", "haskell-persistent", "hcl", "heex", "hosts", "html", "hurl", "iex", "ini", "java", "javascript", "jinja2", "jsdoc", "json", "jsonnet", "julia", "just", "kdl", "kotlin", "latex", "lean", "ledger", "llvm", "llvm-mir", "lua", "make", "markdoc", "markdown", "markdown_inline", "matlab", "mermaid", "meson", "nasm", "nickel", "nim", "nix", "nu", "ocaml", "ocaml-interface", "odin", "opencl", "openscad", "org", "pascal", "passwd", "pem", "perl", "php", "po", "pod", "ponylang", "prisma", "protobuf", "prql", "purescript", "python", "qmljs", "r", "regex", "rego", "robot", "rst", "ruby", "rust", "scala", "scheme", "scss", "slint", "smithy", "sml", "solidity", "sql", "sshclientconfig", "strace", "svelte", "sway", "swift", "t32", "tablegen", "task", "todotxt", "toml", "tsq", "tsx", "twig", "typescript", "ungrammar", "unison", "uxntal", "v", "vala", "verilog", "vhdl", "vhs", "vue", "wast", "wat", "wgsl", "wit", "wren", "xit", "xml", "yaml", "yuck", "zig"]
  Failure 1/2: rescript Parser compilation failed.
  Stdout: 
  Stderr: /home/khazakar/gitdownload/helix/runtime/grammars/sources/rescript/src/scanner.c:134:9: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
    134 |   const in_string = state->in_quotes || state->in_backticks;
        |   ~~~~~ ^
        |   int
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/rescript/src/scanner.c:184:10: warning: unused variable 'is_unnested' [-Wunused-variable]
    184 |     bool is_unnested = state->parens_nesting == 0;
        |          ^~~~~~~~~~~
  1 warning and 1 error generated.

  Failure 2/2: d Parser compilation failed.
  Stdout: 
  Stderr: /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:70:9: error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     70 |                         if (!isascii(lexer->lookahead) ||
        |                              ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:81:9: error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     81 |                         if (!isascii(lexer->lookahead) ||
        |                              ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:92:9: error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     92 |                         if (!isascii(lexer->lookahead) ||
        |                              ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:126:9: error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    126 |                         if (!isascii(lexer->lookahead) ||
        |                              ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:578:7: warning: variable 'prev' set but not used [-Wunused-but-set-variable]
    578 |         int  prev;
        |              ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:777:46: warning: unused parameter 'arg' [-Wunused-parameter]
    777 | tree_sitter_d_external_scanner_destroy(void *arg)
        |                                              ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:782:48: warning: unused parameter 'arg' [-Wunused-parameter]
    782 | tree_sitter_d_external_scanner_serialize(void *arg, char *buffer)
        |                                                ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:782:59: warning: unused parameter 'buffer' [-Wunused-parameter]
    782 | tree_sitter_d_external_scanner_serialize(void *arg, char *buffer)
        |                                                           ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:789:11: warning: unused parameter 'arg' [-Wunused-parameter]
    789 |     void *arg, const char *buffer, unsigned length)
        |           ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:789:28: warning: unused parameter 'buffer' [-Wunused-parameter]
    789 |     void *arg, const char *buffer, unsigned length)
        |                            ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:789:45: warning: unused parameter 'length' [-Wunused-parameter]
    789 |     void *arg, const char *buffer, unsigned length)
        |                                             ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/scanner.c:795:11: warning: unused parameter 'arg' [-Wunused-parameter]
    795 |     void *arg, TSLexer *lexer, const bool *valid)
        |           ^
  8 warnings and 4 errors generated.
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/parser.c:11649:3: warning: variable 'eof' set but not used [-Wunused-but-set-variable]
   11649 |   START_LEXER();
         |   ^
  /home/khazakar/gitdownload/helix/runtime/grammars/sources/d/src/tree_sitter/parser.h:136:8: note: expanded from macro 'START_LEXER'
    136 |   bool eof = false;             \
        |        ^
  1 warning generated.


  --- stderr
  thread 'main' panicked at 'Failed to compile tree-sitter grammars: 2 grammars failed to build', helix-term/build.rs:7:14

Platform

Linux, openSUSE Tumbleweed 20230929

Terminal Emulator

Konsole 23.08.1

Helix Version

master

[kirawi]

jaredramirez/tree-sitter-rescript#2
gdamore/tree-sitter-d#20

[tcoopman]

@kirawi tree-sitter-rescript seems to be fixed, but I guess there needs to be a PR to update i in helix?

[nanzhong]

Created #8962 for bumping the rescript grammar.