Auto format for toml using taplo doesn't work

[ixora-0]

Summary

Using :w on a .toml file doesn't format it. Error linting and :format works normally.

Reproduction Steps

Installed taplo using cargo https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers#toml

$ taplo -V
taplo 0.8.1

config.toml

[editor]
auto-format = true

languages.toml

[[language]]
name = "toml"
auto-format = true
formatter = { command = "taplo", args = ["fmt", "-"] }

Helix log

~/.cache/helix/helix.log

2023-10-10T13:33:39.562 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"initialize\"\n"
2023-10-10T13:33:39.562 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/foldingRange\"\n"
2023-10-10T13:33:39.562 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/documentSymbol\"\n"
2023-10-10T13:33:39.562 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/formatting\"\n"
2023-10-10T13:33:39.562 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/completion\"\n"
2023-10-10T13:33:39.562 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/hover\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/documentLink\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/semanticTokens/full\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/prepareRename\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"textDocument/rename\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"initialized\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"workspace/didChangeWorkspaceFolders\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"taplo/listSchemas\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"textDocument/didSave\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"textDocument/didClose\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"workspace/didChangeConfiguration\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"textDocument/didOpen\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"taplo/convertToJson\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"taplo/convertToToml\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered request handler method=\"taplo/associatedSchema\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"taplo/associateSchema\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: registered notification handler method=\"textDocument/didChange\"\n"
2023-10-10T13:33:39.563 helix_lsp::transport [ERROR] err <- " INFO taplo: LSP server listening transport=\"stdio\"\n"
2023-10-10T13:33:40.119 helix_lsp::transport [INFO] <- {"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":1,"hoverProvider":true,"completionProvider":{"resolveProvider":false,"triggerCharacters":[".","=","[","{",",","\""]},"documentSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":{"prepareProvider":true},"documentLinkProvider":{},"foldingRangeProvider":true,"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":true}},"semanticTokensProvider":{"workDoneProgress":false,"legend":{"tokenTypes":["tomlArrayKey","tomlTableKey"],"tokenModifiers":["readonly"]},"range":false,"full":true}},"serverInfo":{"name":"Taplo","version":"0.6.1"}}}
2023-10-10T13:33:40.120 helix_lsp::transport [INFO] <- {"capabilities":{"completionProvider":{"resolveProvider":false,"triggerCharacters":[".","=","[","{",",","\""]},"documentFormattingProvider":true,"documentLinkProvider":{},"documentSymbolProvider":true,"foldingRangeProvider":true,"hoverProvider":true,"renameProvider":{"prepareProvider":true},"semanticTokensProvider":{"full":true,"legend":{"tokenModifiers":["readonly"],"tokenTypes":["tomlArrayKey","tomlTableKey"]},"range":false,"workDoneProgress":false},"textDocumentSync":1,"workspace":{"workspaceFolders":{"changeNotifications":true,"supported":true}}},"serverInfo":{"name":"Taplo","version":"0.6.1"}}
2023-10-10T13:33:40.120 helix_lsp::transport [INFO] -> {"jsonrpc":"2.0","method":"initialized","params":{}}

Platform

Windows

Terminal Emulator

tabby 1.0.201

Helix Version

helix 23.05 (7f5940b)

[ixora-0]

Also don't know if this is related but the formatting using prettier is also not working.

[[language]]
name = "typescript"
auto-format = true
formatter = { command = "npx", args = ["prettier", "--parser", "typescript"] }

npx prettier file in command line works normally.

[the-mikedavis]

What does the log file say when you save a typescript file while running in verbose mode? (hx -v)

[ixora-0]

@the-mikedavis it didn't log anything so I ran hx -vvv instead.

2023-10-12T22:01:06.033 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 1
2023-10-12T22:01:06.262 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 1
2023-10-12T22:01:06.447 helix_term::application [DEBUG] received editor event: IdleTimer
2023-10-12T22:01:06.628 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 1
2023-10-12T22:01:06.630 helix_view::document [DEBUG] submitting save of doc 'Some("<filepath>")'
2023-10-12T22:01:06.630 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 1
2023-10-12T22:01:06.631 helix_term::application [DEBUG] received editor event: DocumentSaved(Ok(DocumentSavedEvent { revision: 1, doc_id: DocumentId(1), path: "<filepath>", text: ["<filecontents>"] }))
2023-10-12T22:01:06.631 helix_term::application [DEBUG] document Some("<filepath>") saved with revision 1
2023-10-12T22:01:06.631 helix_view::document [DEBUG] doc 1 revision updated 0 -> 1
2023-10-12T22:01:06.632 helix_view::editor [DEBUG] editor status: '<file>' written, 36L 862B
2023-10-12T22:01:06.633 helix_view::document [DEBUG] id 1 modified - last saved: 1, current: 1

hx --health typescript looks normal and LSP is working fine. Both :w and :fmt didn't format the file.
When the formatter = { command = "npx", args = ["prettier", "--parser", "typescript"] } line in config is removed, :w and :fmt works (but not using prettier though).

[the-mikedavis]

Does it work to format by piping outside of Helix: cat file.ts | npx prettier --parser typescript?

[ixora-0]

Yeah cat file.ts | npx prettier --parser typescript works.

[the-mikedavis]

I can't reproduce - that config works for me on 23.05 and master. Are you sure the config.toml and languages.toml are being picked up? You can try adding an intentional TOML mistake and seeing if helix gives an error on startup. To test this I have .helix/config.toml and .helix/languages.toml created in my local clone of Helix. Then if I start hx languages.toml and :write<ret> then I see the file formatted.

Also, the formatter line is unnecessary for taplo since the taplo language server supports the formatting part of LSP, so that line can be removed.

[David-Else]

@Harrelix You need a Prettier plugin for TOML, it does not work out of the box. Also, see this issue for it to work with Helix: un-ts/toml-tools#69 (comment)

[ixora-0]

@David-Else No I can't use prettier on typescript. #8509 (comment)

[Kurt-Shiwz]

How can i set auto-format·= true once for all languages ?

[Bobrokus]

In my case I had to define the TOML formatter. It didn't work otherwise 🤷

[Rudxain]

set auto-format·= true once for all languages

Currently, that's not possible. For similar reasons why indent = { unit = "\t" } can't be set as default for all langs