"Hover" documentation doesn't show up on first character on GQL field

[Nintron27]

Summary

When using k in space mode on a GraphQL field I expected to get the documentation modal to popup, however, it seems to not work if you have the first character selected. I'm seeing this on version 3.3.22 of the graphql-language-service-cli.

Examples:

Reproduction Steps

I tried:

1. Pressing space then k ontop of a GraphQL field name (on the first character)

I expected this to happen:

• The "hover" documentation to popup

Instead, this happened:

• A blank hover documentation popped up, as if there was no info for the symbol.

To fix it:

1. I just select any other character in the field name and the documentation pops up.

Helix log

helix.log

2023-11-02T23:29:44.822 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:45.023 helix_term::application [DEBUG] received editor event: IdleTimer
2023-11-02T23:29:45.316 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:45.317 helix_lsp::transport [INFO] graphql-language-service -> {"jsonrpc":"2.0","method":"textDocument/hover","params":{"position":{"character":1,"line":1},"textDocument":{"uri":"file:///REDACTED/+page.gql"}},"id":1}
2023-11-02T23:29:45.320 helix_lsp::transport [INFO] graphql-language-service <- {"jsonrpc":"2.0","id":1,"result":{"contents":""}}
2023-11-02T23:29:45.320 helix_lsp::transport [INFO] graphql-language-service <- {"contents":""}
2023-11-02T23:29:45.320 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:45.517 helix_term::application [DEBUG] received editor event: IdleTimer
2023-11-02T23:29:46.897 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:47.098 helix_term::application [DEBUG] received editor event: IdleTimer
2023-11-02T23:29:47.416 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:47.617 helix_term::application [DEBUG] received editor event: IdleTimer
2023-11-02T23:29:47.812 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:47.813 helix_lsp::transport [INFO] graphql-language-service -> {"jsonrpc":"2.0","method":"textDocument/hover","params":{"position":{"character":2,"line":1},"textDocument":{"uri":"file:///REDACTED/+page.gql"}},"id":2}
2023-11-02T23:29:47.814 helix_lsp::transport [INFO] graphql-language-service <- {"jsonrpc":"2.0","id":2,"result":{"contents":"```graphql\nQueryRoot.shop: Shop!\n```\n\nThe shop associated with the storefront access token."}}
2023-11-02T23:29:47.814 helix_lsp::transport [INFO] graphql-language-service <- {"contents":"```graphql\nQueryRoot.shop: Shop!\n```\n\nThe shop associated with the storefront access token."}
2023-11-02T23:29:47.814 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:48.013 helix_term::application [DEBUG] received editor event: IdleTimer
2023-11-02T23:29:49.856 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:50.057 helix_term::application [DEBUG] received editor event: IdleTimer
2023-11-02T23:29:50.134 helix_term::commands::typed [DEBUG] quitting...
2023-11-02T23:29:50.134 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:51.443 helix_term::commands::typed [DEBUG] quitting...
2023-11-02T23:29:51.443 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2023-11-02T23:29:51.443 helix_term::job [DEBUG] waiting on jobs...
2023-11-02T23:29:51.443 helix_term::job [DEBUG] waiting on jobs...
2023-11-02T23:29:51.443 helix_lsp::file_event [DEBUG] Removing LSP client: 0
2023-11-02T23:29:51.443 helix_lsp::transport [INFO] graphql-language-service -> {"jsonrpc":"2.0","method":"shutdown","id":3}
2023-11-02T23:29:51.444 helix_lsp::transport [INFO] graphql-language-service <- {"jsonrpc":"2.0","id":3,"result":null}
2023-11-02T23:29:51.444 helix_lsp::transport [INFO] graphql-language-service <- null
2023-11-02T23:29:51.444 helix_lsp::transport [INFO] graphql-language-service -> {"jsonrpc":"2.0","method":"exit"}

Platform

Linux (NixOS 23.05)

Terminal Emulator

alacritty 0.12.0

Helix Version

helix 23.10 (f6021dd)

[the-mikedavis]

Have you tried this in other editors? I suspect that this is a bug upstream in the language server - it may not be handling the positions correctly when tabs are involved. (That's just a guess though, I haven't looked into the server's codebase.)

[Nintron27]

Ahh, yeah this might be the case. I tried removing all white-spacing and it then shows up:

I don't have any other editors to test it on right now, other than VSCode, which is using it's own plugin.

I'll look at the graphql LS's repo and see if there is bug reports on this.