LSP yellow warnings on gutter don't update when saving file

[germanftorres]

Hi,

Helix 23.10
Elixir 1.15.6
ElixirLS 0.17.7

I'm using helix with ElixirLS for elixir development. I've noticed that the yellow dots that appear marking the lines with LSP warnings/messages don't update properly when saving the file. If I resolve an issue (for example, removing an unused variable), the warning disappears immediately from the diagnostic picker (Space+d or Space+D), but the yellow dot marking the line still shows up and doesn't get cleared. I need to close the buffer and reopen it to see the yellow dot disappear.

Log messages in ~/.cache/helix/helix.log from elixir-ls appear normal and specifically the LSP server receives the textDocument/didChange notification and the LSP server generates a textDocument/publishDiagnostics message, but the helix warnings in the left gutter don't update to reflect the new information received from the LSP.

But after receiving these messages, helix logs an ERROR about receiving a malformed notification from language server.

2023-11-13T20:01:59.119 helix_term::application [DEBUG] document Some("/home/german/dev_work/wetterhub/lib/wetterhub.ex") saved with revision 1
2023-11-13T20:01:59.119 helix_view::document [DEBUG] doc 2 revision updated 0 -> 1
2023-11-13T20:01:59.119 helix_view::editor [DEBUG] editor status: 'lib/wetterhub.ex' written, 15L 169B

2023-11-13T20:01:59.119 helix_lsp::transport [INFO] elixir-ls -> {"jsonrpc":"2.0","method":"textDocument/didSave","params":{"text":"defmodule Wetterhub do\n  @moduledoc \"\"\"\n  This is a module!\n  \"\"\"\n\n  def myfunction(_c, _b) do\n  end\n\n  def hola(a, _b) do\n  end\n\n  def myfunction2(_a, _b) do\n  end\nend\n","textDocument":{"uri":"file:///home/german/dev_work/wetterhub/lib/wetterhub.ex"}}}

2023-11-13T20:01:59.119 helix_lsp::file_event [DEBUG] Received file event for "/home/german/dev_work/wetterhub/lib/wetterhub.ex"
2023-11-13T20:01:59.119 helix_lsp::file_event [DEBUG] Sending didChangeWatchedFiles notification to client 'elixir-ls'
2023-11-13T20:01:59.119 helix_lsp::transport [INFO] elixir-ls -> {"jsonrpc":"2.0","method":"workspace/didChangeWatchedFiles","params":{"changes":[{"type":2,"uri":"file:///home/german/dev_work/wetterhub/lib/wetterhub.ex"}]}}
2023-11-13T20:01:59.119 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1
2023-11-13T20:01:59.120 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Starting build with MIX_ENV: test MIX_TARGET: host","type":3}}
2023-11-13T20:01:59.120 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("Starting build with MIX_ENV: test MIX_TARGET: host"), "type": Number(3)}) })))
2023-11-13T20:01:59.120 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Info, message: "Starting build with MIX_ENV: test MIX_TARGET: host" }
2023-11-13T20:01:59.152 helix_term::application [DEBUG] received editor event: Redraw
2023-11-13T20:01:59.152 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1
2023-11-13T20:01:59.683 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Stopping wetterhub","type":4}}
2023-11-13T20:01:59.683 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("Stopping wetterhub"), "type": Number(4)}) })))
2023-11-13T20:01:59.683 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Unloading wetterhub","type":4}}
2023-11-13T20:01:59.683 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Log, message: "Stopping wetterhub" }
2023-11-13T20:01:59.683 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("Unloading wetterhub"), "type": Number(4)}) })))
2023-11-13T20:01:59.683 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Log, message: "Unloading wetterhub" }
2023-11-13T20:01:59.717 helix_term::application [DEBUG] received editor event: Redraw
2023-11-13T20:01:59.717 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1
2023-11-13T20:01:59.785 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Compiling 1 file (.ex)","type":4}}
2023-11-13T20:01:59.785 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("Compiling 1 file (.ex)"), "type": Number(4)}) })))
2023-11-13T20:01:59.785 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Log, message: "Compiling 1 file (.ex)" }
2023-11-13T20:01:59.793 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"warning: variable \"a\" is unused (if the variable is not meant to be used, prefix it with an underscore)\n  lib/wetterhub.ex:9: Wetterhub.hola/2\n","type":2}}
2023-11-13T20:01:59.793 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("warning: variable \"a\" is unused (if the variable is not meant to be used, prefix it with an underscore)\n  lib/wetterhub.ex:9: Wetterhub.hola/2\n"), "type": Number(2)}) })))
2023-11-13T20:01:59.793 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Warning, message: "warning: variable \"a\" is unused (if the variable is not meant to be used, prefix it with an underscore)\n  lib/wetterhub.ex:9: Wetterhub.hola/2\n" }
2023-11-13T20:01:59.804 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Compile took 684 milliseconds","type":3}}

2023-11-13T20:01:59.804 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"message":"variable \"a\" is unused (if the variable is not meant to be used, prefix it with an underscore)","range":{"end":{"character":10,"line":8},"start":{"character":10,"line":8}},"severity":2,"source":"Elixir"}],"uri":"file:///home/german/dev_work/wetterhub/lib/wetterhub.ex","version":2}}

2023-11-13T20:01:59.804 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("Compile took 684 milliseconds"), "type": Number(3)}) })))
2023-11-13T20:01:59.804 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Info, message: "Compile took 684 milliseconds" }
2023-11-13T20:01:59.804 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"telemetry/event","params":{"name":"build","measurements":{"elixir_ls.build_time":684},"properties":{"elixir_ls.build_result":"mix_compile_ok","elixir_ls.elixir_release":"1.15","elixir_ls.elixir_version":"1.15.6","elixir_ls.erts_version":"14.1","elixir_ls.mix_env":"test","elixir_ls.mix_target":"host","elixir_ls.otp_release":"26"}}}
2023-11-13T20:01:59.804 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "textDocument/publishDiagnostics", params: Map({"diagnostics": Array [Object {"message": String("variable \"a\" is unused (if the variable is not meant to be used, prefix it with an underscore)"), "range": Object {"end": Object {"character": Number(10), "line": Number(8)}, "start": Object {"character": Number(10), "line": Number(8)}}, "severity": Number(2), "source": String("Elixir")}], "uri": String("file:///home/german/dev_work/wetterhub/lib/wetterhub.ex"), "version": Number(2)}) })))
2023-11-13T20:01:59.804 helix_term::application [INFO] Version (2) is out of date for "/home/german/dev_work/wetterhub/lib/wetterhub.ex" (expected (1), dropping PublishDiagnostic notification
2023-11-13T20:01:59.804 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "telemetry/event", params: Map({"measurements": Object {"elixir_ls.build_time": Number(684)}, "name": String("build"), "properties": Object {"elixir_ls.build_result": String("mix_compile_ok"), "elixir_ls.elixir_release": String("1.15"), "elixir_ls.elixir_version": String("1.15.6"), "elixir_ls.erts_version": String("14.1"), "elixir_ls.mix_env": String("test"), "elixir_ls.mix_target": String("host"), "elixir_ls.otp_release": String("26")}}) })))

2023-11-13T20:01:59.804 helix_term::application [ERROR] received malformed notification from Language Server: Unhandled

2023-11-13T20:01:59.804 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"[ElixirLS WorkspaceSymbols] Updating index...","type":3}}
2023-11-13T20:01:59.805 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("[ElixirLS WorkspaceSymbols] Updating index..."), "type": Number(3)}) })))
2023-11-13T20:01:59.805 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Info, message: "[ElixirLS WorkspaceSymbols] Updating index..." }
2023-11-13T20:01:59.813 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"[ElixirLS WorkspaceSymbols] 1 modules need reindexing","type":3}}
2023-11-13T20:01:59.813 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("[ElixirLS WorkspaceSymbols] 1 modules need reindexing"), "type": Number(3)}) })))
2023-11-13T20:01:59.813 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Info, message: "[ElixirLS WorkspaceSymbols] 1 modules need reindexing" }
2023-11-13T20:01:59.814 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"[ElixirLS WorkspaceSymbols] 0 callbacks added to index","type":3}}
2023-11-13T20:01:59.814 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("[ElixirLS WorkspaceSymbols] 0 callbacks added to index"), "type": Number(3)}) })))
2023-11-13T20:01:59.814 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Info, message: "[ElixirLS WorkspaceSymbols] 0 callbacks added to index" }
2023-11-13T20:01:59.814 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"[ElixirLS WorkspaceSymbols] 1 modules added to index","type":3}}
2023-11-13T20:01:59.814 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("[ElixirLS WorkspaceSymbols] 1 modules added to index"), "type": Number(3)}) })))
2023-11-13T20:01:59.814 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Info, message: "[ElixirLS WorkspaceSymbols] 1 modules added to index" }
2023-11-13T20:01:59.814 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"[ElixirLS WorkspaceSymbols] 0 types added to index","type":3}}
2023-11-13T20:01:59.814 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("[ElixirLS WorkspaceSymbols] 0 types added to index"), "type": Number(3)}) })))
2023-11-13T20:01:59.814 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Info, message: "[ElixirLS WorkspaceSymbols] 0 types added to index" }
2023-11-13T20:01:59.815 helix_lsp::transport [INFO] elixir-ls <- {"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"[ElixirLS WorkspaceSymbols] 6 functions added to index","type":3}}
2023-11-13T20:01:59.815 helix_term::application [DEBUG] received editor event: LanguageServerMessage((0, Notification(Notification { jsonrpc: Some(V2), method: "window/logMessage", params: Map({"message": String("[ElixirLS WorkspaceSymbols] 6 functions added to index"), "type": Number(3)}) })))
2023-11-13T20:01:59.815 helix_term::application [INFO] window/logMessage: LogMessageParams { typ: Info, message: "[ElixirLS WorkspaceSymbols] 6 functions added to index" }
2023-11-13T20:01:59.819 helix_term::application [DEBUG] received editor event: Redraw
2023-11-13T20:01:59.820 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1
2023-11-13T20:02:01.804 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1
2023-11-13T20:02:02.416 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1
2023-11-13T20:02:02.933 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1
2023-11-13T20:02:03.789 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1
2023-11-13T20:02:04.250 helix_view::document [DEBUG] id 2 modified - last saved: 1, current: 1

Thanks

Germán