vscode-json-language-server doesn't support executing code action "Sort JSON"

[mattias-arrelid]

Summary

Installing the default language server for JSON as outlined in the official documentation, you get a "Sort JSON" code action in JSON documents. Invoking this results in the following error message:

Language server does not support executing commands

I'm not sure why this action would be available by default if it doesn't work?

Output from hx --health json below:

Configured language servers:
  ✓ vscode-json-language-server: /opt/homebrew/bin/vscode-json-language-server
Configured debug adapter: None
Highlight queries: ✓
Textobject queries: ✘
Indent queries: ✓

Reproduction Steps

I tried this:

1. Installed hx by invoking brew install helix
2. Installed vscode-langservers-extracted using npm, as indicated is the default language server for JSON
3. Opened a JSON document in Helix, hx test.json
4. Pressed Space followed by a (for "Perform code action")
5. Noticed how a popup showed a single item, "Sort JSON"
6. Invoked "Sort JSON"

I expected this to happen:
JSON document would be sorted (by its keys).

Instead, this happened:
You get an error - Language server does not support executing commands

Helix log

~/.cache/helix/helix.log

2023-11-16T21:34:39.019 helix_view::editor [ERROR] editor error: Language server does not support executing commands
2023-11-16T21:37:09.979 helix_view::editor [ERROR] editor error: Language server does not support executing commands
2023-11-16T21:51:18.028 helix_view::editor [ERROR] editor error: Language server does not support executing commands
2023-11-16T21:51:25.082 helix_view::editor [ERROR] editor error: Language server does not support executing commands
2023-11-16T21:52:42.875 helix_view::editor [ERROR] editor error: Language server does not support executing commands

Platform

macOS

Terminal Emulator

wezterm 20231107-082518-f0e3eecb

Installation Method

homebrew

Helix Version

helix 23.10 (f6021dd)

[TornaxO7]

I can investigate that a bit

[TornaxO7]

hm... @arrelid I can't reproduce this. In fact, helix tells me that there are no code actions. May I ask if you have an example file with json?

[mattias-arrelid]

Here's a screenshot of a simple JSON document, and me invoking the code actions popup (space + a).

Document in question:

{
  "test": {
    "a_key": 1,
    "last_key": [
      "hey",
      "you"
    ],
    "another_key": 2
  }
}

If I select everything and pipe to jq -S, I get this (which is what I expected the sort json code action would do):

{
  "test": {
    "a_key": 1,
    "another_key": 2,
    "last_key": [
      "hey",
      "you"
    ]
  }
}

[TornaxO7]

ok, I can't see the version of your LSP json-lsp. May I ask if you can try finding this out?
Just verify that its version is 1.3.4.

[mattias-arrelid]

Just so that I don't forget to mention it: I installed vscode-langservers-extracted instead of vscode-json-languageserver to get the latest version of the JSON LSP (as you can see in the npm package you link to, that standalone version is ~3 years old).

Looking at package.json for vscode-json-languageservice, it's got its version set to ^5.3.7.

[mattias-arrelid]

...which seems to correspond to the (tagged) version that MS published:
https://github.com/microsoft/vscode-json-languageservice/tags

[TornaxO7]

Ah, so it looks like that I'm using the wrong one.

[mattias-arrelid]

Not necessarily wrong - just a quite old one :)

[mattias-arrelid]

@TornaxO7 Please see the attached example