Vue language server code action not work

[vanarok]

Summary

An error is printed to the log when I use the built-in vue language server action "Extract into new dumb component".

2023-12-12T18:43:27.068 helix_lsp::transport [ERROR] volar <- InternalError: Request codeAction/resolve failed with message: Cannot read properties of undefined (reading 'html')
2023-12-12T18:43:27.069 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(29)), original request likely timed out

Platform

Linux (Termux)

Terminal Emulator

Termux

Installation Method

termux package manager

Helix Version

helix 23.10 (f6021dd)

[the-mikedavis]

The message "Cannot read properties of undefined (reading 'html')" comes from the language server - it's throwing an error while trying to handle codeAction/resolve. This seems like a bug upstream in volar to me but could you post the log while running in verbose mode and/or provide more concrete reproduction steps like an example file?

[yowayb]

The responses (from the client, to the language server) to workspace/configuration (from the language server, to the client) are different (between VS Code and Helix). VS Code responds with { html: true } while Helix responds with null. This response is sent just before helix receives the error. Here's the helix log:

2023-12-16T18:22:22.886 helix_lsp::transport [INFO] vuels <- {
  "jsonrpc": "2.0",
  "id": 10,
  "method": "workspace/configuration",
  "params": {
    "items": [
      {
        "section": "volar.format.initialIndent"
      }
    ]
  }
}

2023-12-16T18:22:42.886 helix_lsp::transport [INFO] vuels -> {
  "jsonrpc": "2.0",
  "result": [
    null
  ],
  "id": 10
}

2023-12-16T18:22:42.889 helix_lsp::transport [INFO] vuels <- {
  "jsonrpc": "2.0",
  "id": 4,
  "error": {
    "code": -32603,
    "message": "Request codeAction/resolve failed with message: Cannot read properties of undefined (reading 'html')"
  }
}

And here's VS Code's logs at the same point:

[Trace - 9:23:48 AM] Received request 'workspace/configuration - (19)'.
Params: {
    "items": [
        {
            "section": "volar.format.initialIndent"
        }
    ]
}


[Trace - 9:23:48 AM] Sending response 'workspace/configuration - (19)'. Processing request took 0ms
Result: [
    {
        "html": true
    }
]


[Trace - 9:23:48 AM] Received response 'codeAction/resolve - (82)' in 3ms.
Result: {
    "title": "Extract into new dumb component",
    "data": {
        "uri": "file:///Users/minosh/vue-project-2/src/App.vue",
        "range": [
            286,
            318
        ],
        "newName": "NewComponent"
    },
    "kind": "refactor.move.newFile.dumb",
    "edit": {...TRUNCATED...

[vanarok]

vuejs/language-tools#3811

[vanarok]

you need to install tsdk in config

[yowayb]

One thing strange to me (in my helix.log above) is that 20 seconds passes before Helix sends the null result. 20 seconds is also the default timeout for LSP responses, which I assume applies to responses from the language server.

[yowayb]

@the-mikedavis since Helix is abiding the LSP spec (returning null to the server in the result array) and @vanarok has opened an issue with the language server, I believe this discussion can be closed.