Binding "redo" to Ctrl+Shift+z Doesn't Work

[DrymarchonShaun]

Summary

Not sure what to put here, title is basically the summary

Apologies if this has either been reported already or I'm just being dumb.

In the case I'm being dumb, my entire config is

theme = "catppuccin_macchiato"
[editor]
color-modes = true
cursorline = true
line-number = "relative"

[editor.cursor-shape]
insert = "bar"
normal = "block"
select = "underline"

[editor.indent-guides]
render = true

[keys]
[keys.insert]
C-S-z = "redo"
C-q = ":q"
C-s = ":w"
C-z = "undo"

[keys.normal]
C-S-z = "redo"
C-q = ":q"
C-s = ":w"
C-z = "undo"

Reproduction Steps

With

[keys.normal]
C-S-z = "redo"
C-z = "undo"

in ~/.config/helix/config.toml,

• switch to insert
• type something
• switch back to normal
• ctrl+z to undo what you typed (which works)
• ctrl+shift+z to redo (doesn't work)
• shift+u to redo (does work)

Helix log

~/.cache/helix/helix.log

2024-01-01T12:42:11.202 helix_view::clipboard [DEBUG] Using wl-copy+wl-paste to interact with the system and selection (primary) clipboard 2024-01-01T12:42:11.203 helix_tui::backend::crossterm [DEBUG] The keyboard enhancement protocol is supported in this terminal (checked in 252.147µs) 2024-01-01T12:42:11.203 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:11.454 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:12.553 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.605 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.689 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.719 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.736 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.752 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.840 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.865 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.910 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:13.973 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:14.039 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:14.055 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:14.072 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:14.281 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:14.532 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:14.533 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:14.533 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:15.017 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 1 2024-01-01T12:42:15.018 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 1 2024-01-01T12:42:16.112 helix_view::view [DEBUG] Syncing view ViewId(2v1) between 1 and 0 2024-01-01T12:42:16.112 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:16.363 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:17.014 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:17.265 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:17.342 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:17.583 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:17.786 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:18.037 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:18.078 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:18.329 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:18.338 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:18.589 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:18.688 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:18.939 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:18.954 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:19.196 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:19.425 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:19.676 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:19.852 helix_view::editor [DEBUG] editor status: Already at oldest change 2024-01-01T12:42:19.852 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:20.103 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:20.318 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:20.507 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:20.758 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:20.877 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:21.041 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:21.244 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:21.413 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:21.664 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:22.340 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:22.590 helix_term::application [DEBUG] received editor event: IdleTimer 2024-01-01T12:42:22.847 helix_term::commands::typed [DEBUG] quitting... 2024-01-01T12:42:22.847 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:23.027 helix_term::commands::typed [DEBUG] quitting... 2024-01-01T12:42:23.027 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0 2024-01-01T12:42:23.027 helix_term::job [DEBUG] waiting on jobs... 2024-01-01T12:42:23.027 helix_term::job [DEBUG] waiting on jobs...

Platform

Linux (NixOS)

Terminal Emulator

foot version: 1.16.2

Installation Method

home-manager

Helix Version

helix 23.10 (f6021dd)

[kirawi]

Try C-Z. Shift is not a valid modifier for the config.

[DrymarchonShaun]

EDIT: Oh, wait, i misread C-Z as C-z. Will restest.

Switching it to c-z works. If it's not possible to use shift as a modifier in the config, is there another way?

Am I misreading the docs? They imply shift is valid - see https://docs.helix-editor.com/remapping.html#key-remapping.

"C-S-esc" = "extend_line" # Maps Ctrl-Shift-Escape to extend_line

As well as https://docs.helix-editor.com/remapping.html#special-keys-and-modifiers - "Ctrl, Shift and Alt modifiers are encoded respectively with the prefixes C-, S- and A-."

[DrymarchonShaun]

Alright, that fixed it.

[kirawi]

Yes, I meant to say that shift was not a valid modifier for alphabetic keys (I think)

[cysabi]

I seem to be running into this issue myself when trying to use C-Z on version 25.01.1.
It seems to register all ctrl-shift keybindings as if they were just ctrl-