Pasting is not being handled efficiently in Windows

[NewtonChutney]

Summary

When ctrl+v is used to paste in Windows, the insertions happen character by character for some reason..
The same is not true with hx run from wsl..

It appears the text is input as keystrokes and also affects the mode in which helix works! (the pasting action opened the file picker)
And because of this, even if I had been in insert mode earlier.. brackets are being inserted erroneously.. And the formatting is lost too

2024-01-05.09-36-09.mp4

Reproduction Steps

1. Launch hx and paste from clipboard with ctrl+v (the keybind to paste is configured properly in Windows Terminal)
2. Launch hx in a WSL distro and do the same

expected/actual:
The copy functionality should be the same in case it is a terminal emulator issue, but found the issue only on the Windows build

Helix log

will provide if necessary

Platform

Windows

Terminal Emulator

Windows Terminal v1.18.3181.0

Installation Method

Windows: winget, WSL: Ubuntu apt package

Helix Version

Ubuntu/WSL and Windows: helix 23.10 (f6021dd)

Converted to a discussion from: #9242

[kirawi]

I've never been able to make bracketed paste work with Windows Terminal even though it's supposed to be supported (might be an upstream issue crossterm-rs/crossterm#737). You have alternatives: space-p to paste in the buffer and C-r + * in prompts. Or you can use an alternative terminal emulator such as Wezterm.

[NewtonChutney]

But it does work well when launched from WSL.. In WT that too.. 🤔

[kirawi]

You should also create an issue in Windows Terminal for this since it works in WSL but not in native Windows.

[gabydd]

From looking at crossterm looks like bracketed paste is not implemented if building for windows even if using a terminal that supports it

[NewtonChutney]

Isn't crossterm a Helix dependency..
Ahh, so it ain't a terminal emulator issue..

[kirawi]

I think it is implemented on Windows though: https://github.com/crossterm-rs/crossterm/blob/08762b3ef4519e7f834453bf91e3fe36f4c63fe7/src/event.rs#L385-L387

write_ansi is used for Windows 10+ while the below winapi function is for older versions that don't support bracketed paste.