Use the default terminal size when runtime detection fails #14487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a fallback terminal size to use when runtime detection fails. Since calling `size` from `Terminal` will never fail now, it also changes the function’s signature. If the client code wants to know whether the call succeeded or failed, it’s still possible to call `size` via `Backend`.
This was referenced Sep 23, 2025
the-mikedavis
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
I have a slight preference for this approach since Terminal is meant to close over the Backend. In #14486 we unwrap the same way every time so I'd prefer having the helper in Terminal do that for us.
|
Sure. Thanks for the review and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This is a continuation of the work on #14442.
This commit adds a fallback terminal size to use when runtime detection fails. Since calling
sizefromTerminalwill never fail now, it also changes the function’s signature.If the client code wants to know whether the call succeeded or failed, it’s still possible to call
sizeviaBackend.Related PR
#14486 PR also solves the problem, but in a slightly different way. This allows us to review, compare, and select the best approach.
Before
After
Issue
#14101
Thank you