modules: shell: Add wait before UARTs are suspended

jtguggedal · simensrostad · commit 3c10e9847833 · 2024-11-08T11:24:43.000+01:00
Add a short wait before UARTs are suspended to leave time to empty
the buffers. Otherwise an assert will kick in because the
TX_STOPPED event has not been received before suspending the UARTs.

Signed-off-by: Jan Tore Guggedal &lt;jantore.guggedal@nordicsemi.no&gt;
diff --git a/app/src/modules/shell/shell.c b/app/src/modules/shell/shell.c
@@ -67,6 +67,12 @@ static void uart_disable_handler(struct k_work *work)
 	}
 #endif
 
+	/* Wait for UART buffers to be emptied before suspending.
+	 * If a transfer is ongoing, the driver will cause an assertion to fail.
+	 * 100 ms is an arbitrary value that should be enough for the buffers to empty.
+	 */
+	k_busy_wait(100 * USEC_PER_MSEC);
+
 	if (device_is_ready(uart1_dev)) {
 		pm_device_action_run(uart1_dev, PM_DEVICE_ACTION_SUSPEND);
 	}

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,12 @@ static void uart_disable_handler(struct k_work *work)`
`67`	`67`	`}`
`68`	`68`	`#endif`
`69`	`69`
	`70`	`+ /* Wait for UART buffers to be emptied before suspending.`
	`71`	`+ * If a transfer is ongoing, the driver will cause an assertion to fail.`
	`72`	`+ * 100 ms is an arbitrary value that should be enough for the buffers to empty.`
	`73`	`+ */`
	`74`	`+ k_busy_wait(100 * USEC_PER_MSEC);`
	`75`	`+`
`70`	`76`	`if (device_is_ready(uart1_dev)) {`
`71`	`77`	`pm_device_action_run(uart1_dev, PM_DEVICE_ACTION_SUSPEND);`
`72`	`78`	`}`