Minor SimpleCommandBus test improvement.

boekkooi-fresh · boekkooi-fresh · commit d268432de353 · 2016-07-13T11:40:22.000+02:00
- Renamed method to be more accurate
- Removed unneeded execute call
diff --git a/tests/CommandBus/SimpleCommandBusTest.php b/tests/CommandBus/SimpleCommandBusTest.php
@@ -47,13 +47,10 @@ public function itExecutesAMessage()
      * @test
      * @expectedException \HelloFresh\Engine\CommandBus\Exception\MissingHandlerException
      */
-    public function itLosesMessageWhenThereIsNoHandlers()
+    public function itFailsWhenThereIsNoHandlers()
     {
         $command = new TestCommand("hey");
         $this->commandBus->execute($command);
-
-        $handler = new TestHandler();
-        $this->assertSame(0, $handler->getCounter());
     }
 
     /**
@@ -66,7 +63,6 @@ public function itFailsWhenHaveInvalidSubscriber()
         $handler = new TestHandler();
 
         $this->locator->addHandler($command, $handler);
-        $this->commandBus->execute($command);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -47,13 +47,10 @@ public function itExecutesAMessage()`
`47`	`47`	`* @test`
`48`	`48`	`* @expectedException \HelloFresh\Engine\CommandBus\Exception\MissingHandlerException`
`49`	`49`	`*/`
`50`		`- public function itLosesMessageWhenThereIsNoHandlers()`
	`50`	`+ public function itFailsWhenThereIsNoHandlers()`
`51`	`51`	`{`
`52`	`52`	`$command = new TestCommand("hey");`
`53`	`53`	`$this->commandBus->execute($command);`
`54`		`-`
`55`		`- $handler = new TestHandler();`
`56`		`- $this->assertSame(0, $handler->getCounter());`
`57`	`54`	`}`
`58`	`55`
`59`	`56`	`/**`
`@@ -66,7 +63,6 @@ public function itFailsWhenHaveInvalidSubscriber()`
`66`	`63`	`$handler = new TestHandler();`
`67`	`64`
`68`	`65`	`$this->locator->addHandler($command, $handler);`
`69`		`- $this->commandBus->execute($command);`
`70`	`66`	`}`
`71`	`67`
`72`	`68`	`/**`