Merge pull request #28 from hellofresh/patch/fix-golangci-lint

 Avoid GoLangCI Lint excluding rules by default

Author: boekkooi-fresh

.golangci.yml

@@ -24,3 +24,16 @@ linters:
     - varcheck
     - vet
     - vetshadow
+
+issues:
+  exclude-use-default: false
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - errcheck
+
+    # Ignore the streamEvents.Close errcheck warning since we do not want to introduce a logger for repositories just yet
+    - path: aggregate/repository.go
+      text: "Error return value of \\`streamEvents.Close\\` is not checked"
+      linters:
+        - errcheck

driver/inmemory/internal/generate_matcher/main.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"flag"
+	"fmt"
 	"os"
 	"path/filepath"
 	"reflect"
@@ -196,11 +197,16 @@ func main() {
 		panic(err)
 	}
 
+	/* #nosec G302 */
 	f, err := os.OpenFile(matcherPath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
 	if err != nil {
 		panic(err)
 	}
-	defer f.Close()
+	defer func() {
+		if err := f.Close(); err != nil {
+			fmt.Printf("failed to close file: %s\n", err)
+		}
+	}()
 
 	err = tmpl.Execute(f, struct {
 		Types        []reflect.Kind

driver/inmemory/matcher.go

@@ -119,8 +119,8 @@ func (c *metadataConstraint) Matches(val interface{}) (bool, error) {
 func (e IncompatibleMatcherError) Error() string {
 	msg := bytes.NewBufferString("goengine: incompatible metadata.Matcher")
 	for _, err := range e {
-		msg.WriteRune('\n')
-		msg.WriteString(err.Error())
+		_, _ = msg.WriteRune('\n')
+		_, _ = msg.WriteString(err.Error())
 	}
 
 	return msg.String()

driver/sql/postgres/eventstore.go

@@ -207,7 +207,7 @@ func (e *EventStore) AppendToWithExecer(ctx context.Context, conn driverSQL.Exec
 
 	result, err := conn.ExecContext(
 		ctx,
-		/* #nosec */
+		/* #nosec G201 */
 		fmt.Sprintf(
 			"INSERT INTO %s (%s) VALUES %s",
 			tableName,
@@ -254,17 +254,17 @@ func (e *EventStore) prepareInsertValues(streamEvents []goengine.Message, lenCol
 	for i := 0; i < placeholderCount; i++ {
 		if m := i % lenCols; m == 0 {
 			if i != 0 {
-				placeholders.WriteString("),")
+				_, _ = placeholders.WriteString("),")
 			}
-			placeholders.WriteRune('(')
+			_, _ = placeholders.WriteRune('(')
 		} else {
-			placeholders.WriteRune(',')
+			_, _ = placeholders.WriteRune(',')
 		}
 
-		placeholders.WriteRune('$')
-		placeholders.WriteString(strconv.Itoa(i + 1))
+		_, _ = placeholders.WriteRune('$')
+		_, _ = placeholders.WriteString(strconv.Itoa(i + 1))
 	}
-	placeholders.WriteString(")")
+	_, _ = placeholders.WriteString(")")
 	e.preparedInsertPlaceholder[messageCount] = placeholders.String()
 
 	return e.preparedInsertPlaceholder[messageCount]

driver/sql/postgres/projector_aggregate_storage.go

@@ -61,7 +61,7 @@ func newAggregateProjectionStorage(
 	projectionTableStr := QuoteString(projectionTable)
 	eventStoreTableQuoted := QuoteIdentifier(eventStoreTable)
 
-	/* #nosec */
+	/* #nosec G201 */
 	return &aggregateProjectionStorage{
 		projectionStateEncoder: projectionStateEncoder,
 		logger:                 logger,

driver/sql/postgres/projector_stream_storage.go

@@ -56,7 +56,7 @@ func newStreamProjectionStorage(
 	projectionTableQuoted := QuoteIdentifier(projectionTable)
 	projectionTableStr := QuoteString(projectionTable)
 
-	/* #nosec */
+	/* #nosec G201 */
 	return &streamProjectionStorage{
 		projectionName:         projectionName,
 		projectionStateEncoder: projectionStateEncoder,

metadata/metadata.go

@@ -98,6 +98,7 @@ func (v *valueData) MarshalJSON() ([]byte, error) {
 	return json.Marshal(v.AsMap())
 }
 
+// UnmarshalJSON unmarshals the provided json into a Metadata instance
 func UnmarshalJSON(json []byte) (Metadata, error) {
 	in := jlexer.Lexer{Data: json}
 	metadata := New()

mocks/mocks.go

@@ -22,13 +22,15 @@ import (
 
 var _ goengine.Message = &DummyMessage{}
 
+// DummyMessage a simple goengine.Message implementation used for testing
 type DummyMessage struct {
 	uuid      goengine.UUID
 	payload   interface{}
 	metadata  metadata.Metadata
 	createdAt time.Time
 }
 
+// NewDummyMessage returns a new DummyMessage
 func NewDummyMessage(id goengine.UUID, payload interface{}, meta metadata.Metadata, time time.Time) *DummyMessage {
 	return &DummyMessage{
 		id,
@@ -38,22 +40,27 @@ func NewDummyMessage(id goengine.UUID, payload interface{}, meta metadata.Metada
 	}
 }
 
+// UUID returns the identifier of this message
 func (d *DummyMessage) UUID() goengine.UUID {
 	return d.uuid
 }
 
+// CreatedAt returns the created time of the message
 func (d *DummyMessage) CreatedAt() time.Time {
 	return d.createdAt
 }
 
+// Payload returns the payload of the message
 func (d *DummyMessage) Payload() interface{} {
 	return d.payload
 }
 
+// Metadata return the message metadata
 func (d *DummyMessage) Metadata() metadata.Metadata {
 	return d.metadata
 }
 
+// WithMetadata Returns new instance of the message with key and value added to metadata
 func (d *DummyMessage) WithMetadata(key string, value interface{}) goengine.Message {
 	newMessage := *d
 	newMessage.metadata = metadata.WithValue(d.metadata, key, value)

strategy/json/sql/postgres/sql_schema.go

@@ -33,7 +33,7 @@ $EXIST$`
 // sqlTriggerEventStreamNotify a helper to create the sql on a event store table
 func sqlTriggerEventStreamNotifyTemplate(eventStreamName goengine.StreamName, eventStreamTable string) string {
 	triggerName := fmt.Sprintf("%s_notify", eventStreamTable)
-	/* #nosec */
+	/* #nosec G201 */
 	return fmt.Sprintf(
 		`DO LANGUAGE plpgsql $EXIST$
 		 BEGIN
@@ -61,7 +61,7 @@ func sqlTriggerEventStreamNotifyTemplate(eventStreamName goengine.StreamName, ev
 
 // StreamProjectorCreateSchema return the sql statement needed for the postgres database in order to use the StreamProjector
 func StreamProjectorCreateSchema(projectionTable string, streamName goengine.StreamName, streamTable string) []string {
-	/* #nosec */
+	/* #nosec G201 */
 	return []string{
 		sqlFuncEventStreamNotify,
 		sqlTriggerEventStreamNotifyTemplate(streamName, streamTable),
@@ -82,7 +82,7 @@ func StreamProjectorCreateSchema(projectionTable string, streamName goengine.Str
 
 // AggregateProjectorCreateSchema return the sql statement needed for the postgres database in order to use the AggregateProjector
 func AggregateProjectorCreateSchema(projectionTable string, streamName goengine.StreamName, streamTable string) []string {
-	/* #nosec */
+	/* #nosec G201 */
 	return []string{
 		sqlFuncEventStreamNotify,
 		sqlTriggerEventStreamNotifyTemplate(streamName, streamTable),

test/internal/postgres.go

@@ -82,7 +82,7 @@ func (c *dbController) disableDatabaseAccess(t *testing.T, databaseName string)
 	// Terminate existing connections
 	rows, err := c.db.Query("SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE datname = $1", databaseName)
 	require.NoError(t, err)
-	defer rows.Close()
+	require.NoError(t, err, rows.Close())
 }
 
 func (c *dbController) enableDatabaseAccess(t *testing.T, databaseName string) {