Skip to content

Commit 62f6bf2

Browse files
committed
fix cyclic dependecies
1 parent 88b0396 commit 62f6bf2

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

metrics.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
package goengine
22

3-
import (
4-
"github.com/hellofresh/goengine/driver/sql"
5-
)
6-
73
type (
84
// Metrics a structured metrics interface
95
Metrics interface {
106
ReceivedNotification(isNotification bool)
11-
QueueNotification(notification *sql.ProjectionNotification)
12-
StartNotificationProcessing(notification *sql.ProjectionNotification)
13-
FinishNotificationProcessing(notification *sql.ProjectionNotification, success bool, retry bool)
7+
QueueNotification(notification interface{})
8+
StartNotificationProcessing(notification interface{})
9+
FinishNotificationProcessing(notification interface{}, success bool, retry bool)
1410
}
1511
)

metrics_nop.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
package goengine
22

3-
import "github.com/hellofresh/goengine/driver/sql"
4-
53
var NopMetrics Metrics = &nopMetrics{}
64

75
type nopMetrics struct{}
86

97
func (nm *nopMetrics) ReceivedNotification(isNotification bool) {}
10-
func (nm *nopMetrics) QueueNotification(notification *sql.ProjectionNotification) {}
11-
func (nm *nopMetrics) StartNotificationProcessing(notification *sql.ProjectionNotification) {}
12-
func (nm *nopMetrics) FinishNotificationProcessing(notification *sql.ProjectionNotification, success bool, retry bool) {
8+
func (nm *nopMetrics) QueueNotification(notification interface{}) {}
9+
func (nm *nopMetrics) StartNotificationProcessing(notification interface{}) {}
10+
func (nm *nopMetrics) FinishNotificationProcessing(notification interface{}, success bool, retry bool) {
1311
}

0 commit comments

Comments
 (0)