Remove MarshalJSON from JSONMetadata

Since Metadata implement json.Marshaler there is no reason to have it for JSONMetadata.

Author: boekkooi-fresh

metadata/metadata.go

@@ -104,21 +104,10 @@ type JSONMetadata struct {
 }
 
 var (
-	// Ensure JSONMetadata implements the json.Marshaler interface
-	_ json.Marshaler = &JSONMetadata{}
 	// Ensure JSONMetadata implements the json.Unmarshaler interface
 	_ json.Unmarshaler = &JSONMetadata{}
 )
 
-// MarshalJSON returns a json representation of the wrapped Metadata
-func (j JSONMetadata) MarshalJSON() ([]byte, error) {
-	if j.Metadata == nil {
-		j.Metadata = New()
-	}
-
-	return json.Marshal(j.Metadata)
-}
-
 // UnmarshalJSON unmarshal the json into Metdadata
 func (j *JSONMetadata) UnmarshalJSON(data []byte) error {
 	r := jlexer.Lexer{Data: data}

metadata/metadata_test.go

@@ -212,21 +212,6 @@ func TestMetadata_MarshalJSON(t *testing.T) {
 	}
 }
 
-func TestJSONMetadata_MarshalJSON(t *testing.T) {
-	for _, testCase := range jsonTestCases {
-		t.Run(testCase.title, func(t *testing.T) {
-			m := metadata.JSONMetadata{
-				Metadata: testCase.metadata(),
-			}
-
-			mJSON, err := json.Marshal(m)
-
-			assert.JSONEq(t, testCase.json, string(mJSON))
-			assert.NoError(t, err)
-		})
-	}
-}
-
 func TestJSONMetadata_UnmarshalJSON(t *testing.T) {
 	for _, testCase := range jsonTestCases {
 		t.Run(testCase.title, func(t *testing.T) {