Skip to content

Commit 7ef95e6

Browse files
authored
Merge pull request #90 from hellofresh/patch/update-golint-issues
rename unused vars
2 parents cb6b42b + f75b647 commit 7ef95e6

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

.github/workflows/testing.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Check out code
1616
uses: actions/checkout@v3
1717
- name: golangci-lint
18-
uses: golangci/golangci-lint-action@v2
18+
uses: golangci/golangci-lint-action@v3
1919
with:
2020
only-new-issues: ${{ github.event_name == 'pull_request' }}
2121

driver/inmemory/eventstore.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func NewEventStore(logger goengine.Logger) *EventStore {
3838
}
3939

4040
// Create creates an event stream
41-
func (i *EventStore) Create(ctx context.Context, streamName goengine.StreamName) error {
41+
func (i *EventStore) Create(_ context.Context, streamName goengine.StreamName) error {
4242
if _, found := i.streams[streamName]; found {
4343
return ErrStreamExistsAlready
4444
}
@@ -49,15 +49,15 @@ func (i *EventStore) Create(ctx context.Context, streamName goengine.StreamName)
4949
}
5050

5151
// HasStream returns true if the stream exists
52-
func (i *EventStore) HasStream(ctx context.Context, streamName goengine.StreamName) bool {
52+
func (i *EventStore) HasStream(_ context.Context, streamName goengine.StreamName) bool {
5353
_, found := i.streams[streamName]
5454

5555
return found
5656
}
5757

5858
// Load returns a list of events based on the provided conditions
5959
func (i *EventStore) Load(
60-
ctx context.Context,
60+
_ context.Context,
6161
streamName goengine.StreamName,
6262
fromNumber int64,
6363
count *uint,

extension/amqp/amqp_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func (ch mockChannel) Consume(
5858
) (<-chan amqp.Delivery, error) {
5959
return make(chan amqp.Delivery), nil
6060
}
61-
func (ch mockChannel) Qos(prefetchCount, prefetchSize int, global bool) error {
61+
func (ch mockChannel) Qos(int, int, bool) error {
6262
return nil
6363
}
6464

logger_nop.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@ var NopLogger Logger = &nopLogger{}
88
type nopLogger struct {
99
}
1010

11-
func (nopLogger) Error(msg string, fields func(LoggerEntry)) {
11+
func (nopLogger) Error(string, func(LoggerEntry)) {
1212
}
1313

14-
func (nopLogger) Warn(msg string, fields func(LoggerEntry)) {
14+
func (nopLogger) Warn(string, func(LoggerEntry)) {
1515
}
1616

17-
func (nopLogger) Info(msg string, fields func(LoggerEntry)) {
17+
func (nopLogger) Info(string, func(LoggerEntry)) {
1818
}
1919

20-
func (nopLogger) Debug(msg string, fields func(LoggerEntry)) {
20+
func (nopLogger) Debug(string, func(LoggerEntry)) {
2121
}
2222

23-
func (n *nopLogger) WithFields(fields func(LoggerEntry)) Logger {
23+
func (n *nopLogger) WithFields(func(LoggerEntry)) Logger {
2424
return n
2525
}

metadata/matcher.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func WithConstraint(parent Matcher, field string, operator Operator, value inter
6565
}
6666
}
6767

68-
func (*emptyMatcher) Iterate(callback func(constraint Constraint)) {
68+
func (*emptyMatcher) Iterate(func(constraint Constraint)) {
6969
}
7070

7171
func (c *constraintMatcher) Iterate(callback func(constraint Constraint)) {

metadata/metadata.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ var (
6363
_ easyjson.Marshaler = new(emptyData)
6464
)
6565

66-
func (*emptyData) Value(key string) interface{} {
66+
func (*emptyData) Value(string) interface{} {
6767
return nil
6868
}
6969

0 commit comments

Comments
 (0)