Do not install statsd library by default

Author: vgarvardt

.travis.yml

@@ -7,6 +7,7 @@ php:
 
 script:
   - composer install -n
+  - vendor/bin/php-cs-fixer fix --dry-run -v
   - vendor/bin/phpunit
   - rm -rf vendor
   - composer update --prefer-lowest -n

composer.json

@@ -1,25 +1,37 @@
 {
   "name": "hellofresh/stats-php",
+  "keywords": [
+    "logging",
+    "stats"
+  ],
+  "homepage": "https://github.com/hellofresh/stats-php",
+  "license": "MIT",
   "authors": [
     {
       "name": "Vladimir Garvardt",
       "email": "[email protected]"
     }
   ],
+  "support": {
+    "email": "[email protected]"
+  },
   "autoload": {
     "psr-4": {
       "HelloFresh\\Stats\\": "src/"
     }
   },
   "require": {
     "php": ">= 5.6",
-    "league/statsd": "^1.4",
     "psr/http-message": "^1.0",
     "behat/transliterator": "^1.2",
     "psr/log": "^1.0"
   },
   "require-dev": {
     "friendsofphp/php-cs-fixer": "^2.3",
-    "phpunit/phpunit": "^5.7"
+    "phpunit/phpunit": "^5.7",
+    "league/statsd": "^1.4"
+  },
+  "suggest": {
+    "league/statsd": "Required for statsd backend"
   }
 }

src/Bucket/HTTPRequest.php

@@ -11,23 +11,23 @@ class HTTPRequest extends Plain
     /**
      * HTTPRequest constructor.
      *
-     * @param string $section
-     * @param RequestInterface $request
-     * @param bool $success
+     * @param string                       $section
+     * @param RequestInterface             $request
+     * @param bool                         $success
      * @param HTTPMetricAlterCallback|null $callback
      */
     public function __construct($section, RequestInterface $request, $success, HTTPMetricAlterCallback $callback = null)
     {
-        parent::__construct($section, $this->buildMetricOperation($request, $callback), $success);
+        parent::__construct($section, static::buildMetricOperation($request, $callback), $success);
     }
 
     /**
-     * @param RequestInterface $request
+     * @param RequestInterface             $request
      * @param HTTPMetricAlterCallback|null $callback
      *
      * @return MetricOperation
      */
-    public function buildMetricOperation(RequestInterface $request, HTTPMetricAlterCallback $callback = null)
+    public static function buildMetricOperation(RequestInterface $request, HTTPMetricAlterCallback $callback = null)
     {
         $operation = new MetricOperation([strtolower($request->getMethod())]);
         if ($request->getUri()->getPath() !== '/') {

tests/Client/StatsDTest.php

@@ -13,6 +13,10 @@ class StatsDTest extends TestCase
 {
     public function testConfigure()
     {
+        if (!class_exists('\League\StatsD\Client')) {
+            $this->markTestSkipped('Missing league/statsd package');
+        }
+
         $statsClient = $this->getMockBuilder('\HelloFresh\Stats\Client\StatsD')
             ->disableOriginalConstructor()
             ->getMock();
@@ -40,6 +44,10 @@ public function testConfigure()
 
     public function testInstances()
     {
+        if (!class_exists('\League\StatsD\Client')) {
+            $this->markTestSkipped('Missing league/statsd package');
+        }
+
         $statsClient = new StatsD('statsd://');
         $this->assertInstanceOf(Stats\Timer\StatsD::class, $statsClient->buildTimer());
 
@@ -56,6 +64,10 @@ public function testInstances()
 
     public function testHTTPRequestSection()
     {
+        if (!class_exists('\League\StatsD\Client')) {
+            $this->markTestSkipped('Missing league/statsd package');
+        }
+
         $section = uniqid('section', true);
 
         /** @var \PHPUnit_Framework_MockObject_MockObject|\League\StatsD\Client $statsd */

tests/FactoryTest.php

@@ -12,12 +12,23 @@ public function testBuild()
         /** @var \PHPUnit_Framework_MockObject_MockObject|\Psr\Log\LoggerInterface $logger */
         $logger = $this->getMockBuilder('\Psr\Log\LoggerInterface')->getMock();
 
-        $this->assertInstanceOf(Client\StatsD::class, Factory::build('statsd://qwe:1234/asd', $logger));
         $this->assertInstanceOf(Client\Log::class, Factory::build('log://log', $logger));
         $this->assertInstanceOf(Client\NoOp::class, Factory::build('noop://noop', $logger));
         $this->assertInstanceOf(Client\Memory::class, Factory::build('memory://memory', $logger));
     }
 
+    public function testBuildStatsD()
+    {
+        if (!class_exists('\League\StatsD\Client')) {
+            $this->markTestSkipped('Missing league/statsd package');
+        }
+
+        /** @var \PHPUnit_Framework_MockObject_MockObject|\Psr\Log\LoggerInterface $logger */
+        $logger = $this->getMockBuilder('\Psr\Log\LoggerInterface')->getMock();
+
+        $this->assertInstanceOf(Client\StatsD::class, Factory::build('statsd://qwe:1234/asd', $logger));
+    }
+
     /**
      * @expectedException \RuntimeException
      * @expectedExceptionMessage Unknown client type

tests/Incrementer/StatsDTest.php

@@ -14,6 +14,10 @@ protected function setUp()
 
     public function testMetrics()
     {
+        if (!class_exists('\League\StatsD\Client')) {
+            $this->markTestSkipped('Missing league/statsd package');
+        }
+
         /** @var \PHPUnit_Framework_MockObject_MockObject|\League\StatsD\Client $statsd */
         $statsd = $this->getMockBuilder('\League\StatsD\Client')->setMethods(['increment'])->getMock();
 

tests/State/StatsDTest.php

@@ -14,6 +14,10 @@ public function setUp()
 
     public function testSet()
     {
+        if (!class_exists('\League\StatsD\Client')) {
+            $this->markTestSkipped('Missing league/statsd package');
+        }
+
         /** @var \PHPUnit_Framework_MockObject_MockObject|\League\StatsD\Client $statsd */
         $statsd = $this->getMockBuilder('\League\StatsD\Client')->setMethods(['gauge'])->getMock();
 

tests/Timer/StatsDTest.php

@@ -9,6 +9,10 @@ class StatsDTest extends TestCase
 {
     public function testFinish()
     {
+        if (!class_exists('\League\StatsD\Client')) {
+            $this->markTestSkipped('Missing league/statsd package');
+        }
+
         /** @var \PHPUnit_Framework_MockObject_MockObject|\League\StatsD\Client $statsd */
         $statsd = $this->getMockBuilder('\League\StatsD\Client')->getMock();