Added more unit tests

Author: vgarvardt

src/Client/Log.php

@@ -35,7 +35,7 @@ public function __construct(LoggerInterface $logger)
      */
     public function buildTimer()
     {
-        return new Timer\Memory();
+        return new Timer\Log($this->logger);
     }
 
     /**

src/Client/Memory.php

@@ -17,6 +17,14 @@ class Memory extends AbstractClient implements Client
     /** @var Timer\Memory[] */
     protected $timers;
 
+    /**
+     * Memory constructor.
+     */
+    public function __construct()
+    {
+        $this->resetHTTPRequestSection();
+    }
+
     /**
      * @inheritdoc
      */

src/Client/NoOp.php

@@ -15,6 +15,14 @@ class NoOp extends AbstractClient implements Client
     /** @var State\NoOp */
     protected $state;
 
+    /**
+     * NoOp constructor.
+     */
+    public function __construct()
+    {
+        $this->resetHTTPRequestSection();
+    }
+
     /**
      * @inheritdoc
      */

src/Client/StatsD.php

@@ -7,7 +7,7 @@
 use HelloFresh\Stats\HTTPMetricAlterCallback;
 use HelloFresh\Stats\Incrementer;
 use HelloFresh\Stats\State;
-use HelloFresh\Stats\Timer\StatsD as StatsDTimer;
+use HelloFresh\Stats\Timer;
 use League\StatsD\Client as StatsDClient;
 
 class StatsD extends AbstractClient implements Client
@@ -33,6 +33,7 @@ public function __construct($dsn)
     {
         $this->client = new StatsDClient();
         $this->configure($dsn);
+        $this->resetHTTPRequestSection();
     }
 
     /**
@@ -42,13 +43,13 @@ protected function configure($dsn)
     {
         $url = (array)parse_url($dsn);
 
-        $params = parse_str(empty($url['query']) ? '' : $url['query']);
+        parse_str(empty($url['query']) ? '' : $url['query'], $params);
         $options = [
-            'host' => empty($url['host']) ? 'localhost' : '',
-            'port' => empty($url['port']) ? $url['port'] : 8125,
+            'host' => empty($url['host']) ? 'localhost' : $url['host'],
+            'port' => empty($url['port']) ? 8125 : $url['port'],
             'namespace' => empty($url['path']) ? '' : trim($url['path'], '/'),
             'timeout' => empty($params['timeout']) ? null : (float)$params['timeout'],
-            'throwConnectionExceptions' => empty($params['error']) ? true : (bool)$params['error'],
+            'throwConnectionExceptions' => isset($params['error']) ? (bool)$params['error'] : true,
         ];
 
         $this->client->configure($options);
@@ -59,7 +60,7 @@ protected function configure($dsn)
      */
     public function buildTimer()
     {
-        return new StatsDTimer($this->client);
+        return new Timer\StatsD($this->client);
     }
 
     /**

tests/Client/LogTest.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace HelloFresh\Stats\Client;
+
+
+use HelloFresh\Stats;
+use PHPUnit\Framework\TestCase;
+
+class LogTest extends TestCase
+{
+    public function testInstances()
+    {
+        /** @var \PHPUnit_Framework_MockObject_MockObject|\Psr\Log\LoggerInterface $logger */
+        $logger = $this->getMockBuilder('\Psr\Log\LoggerInterface')->getMock();
+
+        $statsClient = new Log($logger);
+        $this->assertInstanceOf(Stats\Timer\Log::class, $statsClient->buildTimer());
+    }
+}

tests/Client/MemoryTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace HelloFresh\Stats\Client;
+
+
+use HelloFresh\Stats;
+use PHPUnit\Framework\TestCase;
+
+class MemoryTest extends TestCase
+{
+    public function testInstances()
+    {
+        $statsClient = new Memory();
+        $this->assertInstanceOf(Stats\Timer\Memory::class, $statsClient->buildTimer());
+    }
+}

tests/Client/NoOpTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace HelloFresh\Stats\Client;
+
+
+use HelloFresh\Stats;
+use PHPUnit\Framework\TestCase;
+
+class NoOpTest extends TestCase
+{
+    public function testInstances()
+    {
+        $statsClient = new NoOp();
+        $this->assertInstanceOf(Stats\Timer\Memory::class, $statsClient->buildTimer());
+    }
+}

tests/Client/StatsDTest.php

@@ -0,0 +1,43 @@
+<?php
+
+namespace HelloFresh\Stats\Client;
+
+
+use HelloFresh\Stats;
+use PHPUnit\Framework\TestCase;
+
+class StatsDTest extends TestCase
+{
+    public function testConfigure()
+    {
+        $statsClient = $this->getMockBuilder('\HelloFresh\Stats\Client\StatsD')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $statsdClient = $this->getMockBuilder('\League\StatsD\Client')->getMock();
+        $statsdClient->expects($this->once())
+            ->method('configure')
+            ->with([
+                'host' => 'stats.local',
+                'port' => 1234,
+                'namespace' => 'prefix.ns',
+                'timeout' => 2.5,
+                'throwConnectionExceptions' => false,
+            ]);
+
+        $reflection = new \ReflectionClass($statsClient);
+        $propertyClient = $reflection->getProperty('client');
+        $propertyClient->setAccessible(true);
+        $propertyClient->setValue($statsClient, $statsdClient);
+
+        $methodConfigure = $reflection->getMethod('configure');
+        $methodConfigure->setAccessible(true);
+        $methodConfigure->invoke($statsClient, 'statsd://stats.local:1234/prefix.ns?timeout=2.5&error=0');
+    }
+
+    public function testInstances()
+    {
+        $statsClient = new StatsD('statsd://');
+        $this->assertInstanceOf(Stats\Timer\StatsD::class, $statsClient->buildTimer());
+    }
+}