Do not test protected methods

Author: vgarvardt

tests/Client/LogTest.php

@@ -5,7 +5,6 @@
 use HelloFresh\Stats\Bucket;
 use HelloFresh\Stats\Bucket\MetricOperation;
 use HelloFresh\Stats\Bucket\Plain;
-use HelloFresh\Stats\Incrementer;
 use HelloFresh\Stats\State;
 use PHPUnit\Framework\TestCase;
 
@@ -23,16 +22,6 @@ public function testInstances()
 
         $statsClient = new Log($logger);
         $this->assertInstanceOf(Stats\Timer\Log::class, $statsClient->buildTimer());
-
-        $reflection = new \ReflectionClass($statsClient);
-
-        $methodIncrementer = $reflection->getMethod('getIncrementer');
-        $methodIncrementer->setAccessible(true);
-        $this->assertInstanceOf(Incrementer\Log::class, $methodIncrementer->invoke($statsClient));
-
-        $methodState = $reflection->getMethod('getState');
-        $methodState->setAccessible(true);
-        $this->assertInstanceOf(State\Log::class, $methodState->invoke($statsClient));
     }
 
     public function testTrackRequest()

tests/Client/MemoryTest.php

@@ -3,8 +3,6 @@
 
 use HelloFresh\Stats;
 use HelloFresh\Stats\Bucket;
-use HelloFresh\Stats\Incrementer;
-use HelloFresh\Stats\State;
 use PHPUnit\Framework\TestCase;
 
 class MemoryTest extends TestCase
@@ -18,16 +16,6 @@ public function testInstances()
     {
         $statsClient = new Memory();
         $this->assertInstanceOf(Stats\Timer\Memory::class, $statsClient->buildTimer());
-
-        $reflection = new \ReflectionClass($statsClient);
-
-        $methodIncrementer = $reflection->getMethod('getIncrementer');
-        $methodIncrementer->setAccessible(true);
-        $this->assertInstanceOf(Incrementer\Memory::class, $methodIncrementer->invoke($statsClient));
-
-        $methodState = $reflection->getMethod('getState');
-        $methodState->setAccessible(true);
-        $this->assertInstanceOf(State\Memory::class, $methodState->invoke($statsClient));
     }
 
     public function testHTTPRequestSection()

tests/Client/NoOpTest.php

@@ -3,8 +3,6 @@
 
 use HelloFresh\Stats;
 use HelloFresh\Stats\Bucket;
-use HelloFresh\Stats\Incrementer;
-use HelloFresh\Stats\State;
 use PHPUnit\Framework\TestCase;
 
 class NoOpTest extends TestCase
@@ -13,16 +11,6 @@ public function testInstances()
     {
         $statsClient = new NoOp();
         $this->assertInstanceOf(Stats\Timer\Memory::class, $statsClient->buildTimer());
-
-        $reflection = new \ReflectionClass($statsClient);
-
-        $methodIncrementer = $reflection->getMethod('getIncrementer');
-        $methodIncrementer->setAccessible(true);
-        $this->assertInstanceOf(Incrementer\NoOp::class, $methodIncrementer->invoke($statsClient));
-
-        $methodState = $reflection->getMethod('getState');
-        $methodState->setAccessible(true);
-        $this->assertInstanceOf(State\NoOp::class, $methodState->invoke($statsClient));
     }
 
     public function testHTTPRequestSection()

tests/Client/StatsDTest.php

@@ -3,8 +3,6 @@
 
 use HelloFresh\Stats;
 use HelloFresh\Stats\Bucket;
-use HelloFresh\Stats\Incrementer;
-use HelloFresh\Stats\State;
 use PHPUnit\Framework\TestCase;
 
 class StatsDTest extends TestCase
@@ -42,16 +40,6 @@ public function testInstances()
 
         $statsClient = new StatsD('statsd://');
         $this->assertInstanceOf(Stats\Timer\StatsD::class, $statsClient->buildTimer());
-
-        $reflection = new \ReflectionClass($statsClient);
-
-        $methodIncrementer = $reflection->getMethod('getIncrementer');
-        $methodIncrementer->setAccessible(true);
-        $this->assertInstanceOf(Incrementer\StatsD::class, $methodIncrementer->invoke($statsClient));
-
-        $methodState = $reflection->getMethod('getState');
-        $methodState->setAccessible(true);
-        $this->assertInstanceOf(State\StatsD::class, $methodState->invoke($statsClient));
     }
 
     public function testHTTPRequestSection()