[FIX/PO-2958] silent client as the default client for statsd >v1.4

Eduardo Kasper · Eduardo Kasper · commit a6d0ddcecc61 · 2023-03-14T16:59:47.000+01:00
diff --git a/src/Client/StatsD.php b/src/Client/StatsD.php
@@ -5,8 +5,8 @@
 use HelloFresh\Stats\HTTPMetricAlterCallback;
 use HelloFresh\Stats\Incrementer;
 use HelloFresh\Stats\State;
+use HelloFresh\Stats\StatsD\SilentClient as StatsDClient;
 use HelloFresh\Stats\Timer;
-use League\StatsD\Client as StatsDClient;
 use League\StatsD\Exception\ConfigurationException;
 
 class StatsD extends AbstractClient implements Client
diff --git a/tests/Client/StatsDTest.php b/tests/Client/StatsDTest.php
@@ -53,7 +53,7 @@ public function testDefaultClientInstance()
         $statsD = new ExposedClientStatsD($dns);
         $instantiatedClient = $statsD->getClient();
 
-        $this->assertInstanceOf(Client::class, $instantiatedClient);
+        $this->assertInstanceOf(Stats\StatsD\SilentClient::class, $instantiatedClient);
     }
 
     /**
@@ -62,10 +62,10 @@ public function testDefaultClientInstance()
     public function testOptionalClientInstance()
     {
         $dns = 'statsd://stats.local:1234/prefix.ns?timeout=2.5&error=0';
-        $statsD = new ExposedClientStatsD($dns, Stats\StatsD\SilentClient::class);
+        $statsD = new ExposedClientStatsD($dns, Client::class);
         $instantiatedClient = $statsD->getClient();
 
-        $this->assertInstanceOf(Stats\StatsD\SilentClient::class, $instantiatedClient);
+        $this->assertInstanceOf(Client::class, $instantiatedClient);
     }
 
     public function testInstances()

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function testDefaultClientInstance()`
`53`	`53`	`$statsD = new ExposedClientStatsD($dns);`
`54`	`54`	`$instantiatedClient = $statsD->getClient();`
`55`	`55`
`56`		`- $this->assertInstanceOf(Client::class, $instantiatedClient);`
	`56`	`+ $this->assertInstanceOf(Stats\StatsD\SilentClient::class, $instantiatedClient);`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`/**`
`@@ -62,10 +62,10 @@ public function testDefaultClientInstance()`
`62`	`62`	`public function testOptionalClientInstance()`
`63`	`63`	`{`
`64`	`64`	`$dns = 'statsd://stats.local:1234/prefix.ns?timeout=2.5&error=0';`
`65`		`- $statsD = new ExposedClientStatsD($dns, Stats\StatsD\SilentClient::class);`
	`65`	`+ $statsD = new ExposedClientStatsD($dns, Client::class);`
`66`	`66`	`$instantiatedClient = $statsD->getClient();`
`67`	`67`
`68`		`- $this->assertInstanceOf(Stats\StatsD\SilentClient::class, $instantiatedClient);`
	`68`	`+ $this->assertInstanceOf(Client::class, $instantiatedClient);`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`public function testInstances()`