Merge pull request #1116 from jjeffers/1079-better-ui-indication-when-deleting-user

Adds a flash notice when deleting a user from the admin user UI. closes #1079

Author: scott

app/controllers/admin/users_controller.rb

@@ -135,7 +135,8 @@ def destroy
     @user.permanently_destroy
 
     respond_to do |format|
-      format.html { redirect_to admin_users_path }
+      format.html { redirect_to admin_users_path,
+        :flash => { :success => "User #{@user.name} was scheduled for permanent deletion." }}
       format.js { }
     end
   end

test/controllers/admin/users_controller_test.rb

@@ -78,6 +78,18 @@ def uploaded_file_object(klass, attribute, file, content_type = 'text/plain')
     assert_response :success
   end
 
+  test "an admin should see a message that a user was scheduled to be deleted" do
+    sign_in users(:admin)
+
+    user_name = User.find(3).name
+
+    delete :destroy, id: 3, locale: :en
+    assert_response :redirect
+    assert_equal "User #{user_name} was scheduled for permanent deletion.",
+      flash[:success]
+  end
+
+
   test "an admin should be able to anonymize a user" do
     sign_in users(:admin)
     xhr :post, :scrub, id: 3, locale: :en