staking regression

Author: withthelemons

src/kernel.cpp

@@ -370,9 +370,9 @@ bool CheckStakeKernelHash(uint32_t nBits, const CBlock& blockFrom, uint32_t nTxP
     CBigNum weightDayTarget = bnCoinDayWeight * bnTargetPerCoinDay;
     if (CBigNum(hashProofOfStake) > weightDayTarget)
     {
-        printf("\n\n\n>>> hashStake = %s > weightDayTarget=%s and it should not be\n",
-        CBigNum(hashProofOfStake).ToString().c_str(), weightDayTarget.ToString().c_str());
-        printf(">>> CheckStakeKernelHash - hashProofOfStake too much\n\n\n");
+        //printf("\n\n\n>>> hashStake = %s > weightDayTarget=%s and it should not be\n",
+        //CBigNum(hashProofOfStake).ToString().c_str(), weightDayTarget.ToString().c_str());
+        //printf(">>> CheckStakeKernelHash - hashProofOfStake too much\n\n\n");
         return false;
     }
     if (fDebug && !fPrintProofOfStake)

src/kernel_worker.cpp

@@ -21,7 +21,7 @@ void KernelWorker::Do_generic()
     // Compute maximum possible target to filter out majority of obviously insufficient hashes
     CBigNum bnTargetPerCoinDay;
     bnTargetPerCoinDay.SetCompact(nBits);
-    uint256 nMaxTarget = (bnTargetPerCoinDay * bnValueIn * nStakeMaxAge / COIN / nOneDay).getuint256();
+    uint256 nMaxTarget = (bnTargetPerCoinDay * bnValueIn * nStakeMaxAge / nOneDay).getuint256();
 
     SHA256_CTX ctx, workerCtx;
     // Init new sha256 context and update it
@@ -53,7 +53,7 @@ void KernelWorker::Do_generic()
         if (hashProofOfStake[7] > nMaxTarget32)
             continue;
 
-        CBigNum bnCoinDayWeight = bnValueIn * GetWeight((int64_t)nInputTxTime, (int64_t)nTimeTx) / COIN / nOneDay;
+        CBigNum bnCoinDayWeight = bnValueIn * GetWeight((int64_t)nInputTxTime, (int64_t)nTimeTx) / nOneDay;
         CBigNum bnTargetProofOfStake = bnCoinDayWeight * bnTargetPerCoinDay;
 
         if (bnTargetProofOfStake >= CBigNum(*pnHashProofOfStake))
@@ -81,7 +81,7 @@ bool ScanKernelBackward(unsigned char *kernel, uint32_t nBits, uint32_t nInputTx
     CBigNum bnValueIn(nValueIn);
 
     // Get maximum possible target to filter out the majority of obviously insufficient hashes
-    uint256 nMaxTarget = (bnTargetPerCoinDay * bnValueIn * nStakeMaxAge / COIN / nOneDay).getuint256();
+    uint256 nMaxTarget = (bnTargetPerCoinDay * bnValueIn * nStakeMaxAge / nOneDay).getuint256();
 
     SHA256_CTX ctx, workerCtx;
     // Init new sha256 context and update it
@@ -110,7 +110,7 @@ bool ScanKernelBackward(unsigned char *kernel, uint32_t nBits, uint32_t nInputTx
         if (hashProofOfStake > nMaxTarget)
             continue;
 
-        CBigNum bnCoinDayWeight = bnValueIn * GetWeight((int64_t)nInputTxTime, (int64_t)nTimeTx) / COIN / nOneDay;
+        CBigNum bnCoinDayWeight = bnValueIn * GetWeight((int64_t)nInputTxTime, (int64_t)nTimeTx) / nOneDay;
         CBigNum bnTargetProofOfStake = bnCoinDayWeight * bnTargetPerCoinDay;
 
         if (bnTargetProofOfStake >= CBigNum(hashProofOfStake))

src/kernelrecord.cpp

@@ -103,7 +103,7 @@ double KernelRecord::getProbToMintStake(double difficulty, int timeOffset) const
     //uint64_t coinAge = max(nValue * dayWeight / COIN, (int64_t)0);
     //return target * coinAge / pow(static_cast<double>(2), 256);
     int64_t Weight = (min((GetAdjustedTime() - nTime) + timeOffset, (int64_t)(nStakeMinAge+nStakeMaxAge)) - nStakeMinAge);
-    uint64_t coinAge = max(nValue * Weight / (COIN * nOneDay), (int64_t)0);
+    uint64_t coinAge = max(nValue * Weight / nOneDay, (int64_t)0);
     return coinAge / (pow(static_cast<double>(2),32) * difficulty);
 }
 

src/wallet.cpp

@@ -2133,7 +2133,7 @@ void CWallet::GetStakeWeightFromValue(const int64_t& nTime, const int64_t& nValu
         return;
     }
 
-    CBigNum bnCoinDayWeight = CBigNum(nValue) * nTimeWeight / COIN / nOneDay;
+    CBigNum bnCoinDayWeight = CBigNum(nValue) * nTimeWeight / nOneDay;
     nWeight = bnCoinDayWeight.getuint64();
 }