[*] refactor: video-editor

Author: heng30

lib/video-editor/src/commands.rs

@@ -4,6 +4,7 @@ pub mod export;
 pub mod filter;
 pub mod history;
 pub mod segment;
+pub mod subtitle;
 pub mod track;
 
 pub use batch::BatchCommand;
@@ -12,4 +13,5 @@ pub use export::*;
 pub use filter::*;
 pub use history::HistoryManager;
 pub use segment::*;
+pub use subtitle::*;
 pub use track::*;

lib/video-editor/src/commands/segment.rs

@@ -817,8 +817,6 @@ impl Command for SetSegmentVisibilityCommand {
     }
 }
 
-/// Command to detach audio tracks from a specific segment within a video track.
-/// This creates new audio tracks from the segment's audio streams.
 pub struct DetachSegmentAudioCommand {
     track_index: usize,
     segment_index: usize,
@@ -901,7 +899,8 @@ impl Command for DetachSegmentAudioCommand {
 
         if let Track::Video(vt) = track {
             let vt = std::sync::Arc::make_mut(vt);
-            vt.track.segments[self.segment_index] = video_track_mut.track.segments[self.segment_index].clone();
+            vt.track.segments[self.segment_index] =
+                video_track_mut.track.segments[self.segment_index].clone();
             vt.update_duration();
         }
 
@@ -958,8 +957,6 @@ impl Command for DetachSegmentAudioCommand {
     }
 }
 
-/// Command to detach subtitle tracks from a specific segment within a video track.
-/// This creates new subtitle tracks from the segment's subtitle streams.
 pub struct DetachSegmentSubtitleCommand {
     track_index: usize,
     segment_index: usize,
@@ -999,7 +996,6 @@ impl Command for DetachSegmentSubtitleCommand {
             }
         };
 
-        // Check segment index
         if self.segment_index >= video_track.track.segments.len() {
             return Err(Error::IndexOutOfBounds(
                 self.segment_index,
@@ -1008,21 +1004,15 @@ impl Command for DetachSegmentSubtitleCommand {
         }
 
         let segment = &video_track.track.segments[self.segment_index];
-
-        // Check if segment has subtitle streams
         if segment.metadata.subtitles.is_empty() {
             return Err(Error::InvalidConfig(
                 "Segment has no subtitle streams to detach".into(),
             ));
         }
 
-        // Save original segment metadata for undo
         self.old_segment_metadata = Some(segment.metadata.clone());
-
-        // Clone video track for modification
         let mut video_track_mut = video_track.as_ref().clone();
 
-        // Detach subtitle tracks from the segment
         let detached_subtitle_tracks: Vec<Track> = video_track_mut
             .detach_segment_subtitle_tracks(self.segment_index)
             .into_iter()
@@ -1035,18 +1025,17 @@ impl Command for DetachSegmentSubtitleCommand {
             ));
         }
 
-        // Update the video track with modified segment
         let track = manager
             .get_mut(self.track_index)
             .ok_or_else(|| Error::IndexOutOfBounds(self.track_index, manager_len))?;
 
         if let Track::Video(vt) = track {
             let vt = std::sync::Arc::make_mut(vt);
-            vt.track.segments[self.segment_index] = video_track_mut.track.segments[self.segment_index].clone();
+            vt.track.segments[self.segment_index] =
+                video_track_mut.track.segments[self.segment_index].clone();
             vt.update_duration();
         }
 
-        // Insert detached subtitle tracks
         let mut inserted_indices = Vec::new();
         for (i, track) in detached_subtitle_tracks.into_iter().enumerate() {
             let insert_idx = self.track_index + 1 + i;
@@ -1074,7 +1063,6 @@ impl Command for DetachSegmentSubtitleCommand {
             manager.remove_track(idx)?;
         }
 
-        // Restore original segment metadata
         let manager_len = manager.len();
         let track = manager
             .get_mut(self.track_index)
@@ -1099,8 +1087,6 @@ impl Command for DetachSegmentSubtitleCommand {
     }
 }
 
-/// Command to trim/remove gaps around a specific segment.
-/// This removes the gap before and after the specified segment.
 pub struct RemoveSegmentGapCommand {
     track_index: usize,
     segment_index: usize,
@@ -1178,7 +1164,11 @@ impl Command for RemoveSegmentGapCommand {
 
         // Restore start gap
         if start_gap > Duration::ZERO {
-            let start_index = if self.segment_index == 0 { 0 } else { self.segment_index };
+            let start_index = if self.segment_index == 0 {
+                0
+            } else {
+                self.segment_index
+            };
 
             for i in start_index..segments_count {
                 track.shift_segment_timeline(i, start_gap)?;
@@ -1211,7 +1201,6 @@ impl Command for RemoveSegmentGapCommand {
     }
 }
 
-/// Command to trim/remove the gap before (to the left of) a specific segment.
 pub struct RemoveSegmentLeftGapCommand {
     track_index: usize,
     segment_index: usize,
@@ -1293,7 +1282,6 @@ impl Command for RemoveSegmentLeftGapCommand {
     }
 }
 
-/// Command to trim/remove the gap after (to the right of) a specific segment.
 pub struct RemoveSegmentRightGapCommand {
     track_index: usize,
     segment_index: usize,