Skip to content
This repository was archived by the owner on Mar 16, 2025. It is now read-only.

Commit 487a59f

Browse files
[v2] Refactoring (#153 #158)
1 parent 9fb16cf commit 487a59f

22 files changed

+33
-101
lines changed

src/Trakt.NET.sln

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -126,15 +126,11 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Trakt.NET.HttpClientFactory
126126
EndProject
127127
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Trakt.NET.Extensions.TMDB", "libs\Trakt.NET.Extensions.TMDB\Trakt.NET.Extensions.TMDB.csproj", "{5E6FE4C0-07D9-010B-E19B-DA162549E9E3}"
128128
EndProject
129-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "shared", "shared", "{02EA681E-C7D8-13C7-8484-4AC65E1B71E8}"
130-
EndProject
131129
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "shared", "shared", "{B88173E7-DD80-40D7-B443-73E914D48D26}"
132130
ProjectSection(SolutionItems) = preProject
133131
libs\shared\Directory.Build.props = libs\shared\Directory.Build.props
134132
EndProjectSection
135133
EndProject
136-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Trakt.NET.Utilities", "libs\shared\Trakt.NET.Utilities\Trakt.NET.Utilities.csproj", "{16328885-FE44-B25E-AB0F-32A4802C0F5B}"
137-
EndProject
138134
Global
139135
GlobalSection(SolutionConfigurationPlatforms) = preSolution
140136
Debug|Any CPU = Debug|Any CPU
@@ -181,10 +177,6 @@ Global
181177
{5E6FE4C0-07D9-010B-E19B-DA162549E9E3}.Debug|Any CPU.Build.0 = Debug|Any CPU
182178
{5E6FE4C0-07D9-010B-E19B-DA162549E9E3}.Release|Any CPU.ActiveCfg = Release|Any CPU
183179
{5E6FE4C0-07D9-010B-E19B-DA162549E9E3}.Release|Any CPU.Build.0 = Release|Any CPU
184-
{16328885-FE44-B25E-AB0F-32A4802C0F5B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
185-
{16328885-FE44-B25E-AB0F-32A4802C0F5B}.Debug|Any CPU.Build.0 = Debug|Any CPU
186-
{16328885-FE44-B25E-AB0F-32A4802C0F5B}.Release|Any CPU.ActiveCfg = Release|Any CPU
187-
{16328885-FE44-B25E-AB0F-32A4802C0F5B}.Release|Any CPU.Build.0 = Release|Any CPU
188180
EndGlobalSection
189181
GlobalSection(SolutionProperties) = preSolution
190182
HideSolutionNode = FALSE
@@ -217,9 +209,7 @@ Global
217209
{991F0FB1-CDFD-412E-B7B2-81946E12D6D7} = {50AD22EC-EB56-476B-8DCE-4AF2B5BD8B09}
218210
{AE64986B-39E8-49C2-A3E0-48FBA888B437} = {E7B2A7FC-F550-4546-8F2C-6FC9AA49F6B5}
219211
{5E6FE4C0-07D9-010B-E19B-DA162549E9E3} = {E7B2A7FC-F550-4546-8F2C-6FC9AA49F6B5}
220-
{02EA681E-C7D8-13C7-8484-4AC65E1B71E8} = {E7B2A7FC-F550-4546-8F2C-6FC9AA49F6B5}
221212
{B88173E7-DD80-40D7-B443-73E914D48D26} = {377A7F6A-A4B9-45F6-AB2A-492F0E1F71AD}
222-
{16328885-FE44-B25E-AB0F-32A4802C0F5B} = {02EA681E-C7D8-13C7-8484-4AC65E1B71E8}
223213
EndGlobalSection
224214
GlobalSection(ExtensibilityGlobals) = postSolution
225215
SolutionGuid = {7025A39E-11A6-4587-98F7-E887B941D5A0}

src/libs/Trakt.NET.Extensions.TMDB/Internal/Json/SerializerContexts/TMDBJsonSerializerContextFactory.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#if NET6_0_OR_GREATER
22
using System.Text.Json.Serialization;
3-
using TraktNET.Utilities.Json;
43

54
namespace TraktNET
65
{

src/libs/Trakt.NET.Extensions.TMDB/Internal/TMDBConstants.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
using System.Text.Json;
22

3-
#if !NET8_0_OR_GREATER
4-
using TraktNET.Utilities.Json;
5-
#endif
6-
73
namespace TraktNET
84
{
95
internal static class TMDBConstants

src/libs/Trakt.NET.Extensions.TMDB/Trakt.NET.Extensions.TMDB.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
<ItemGroup>
99
<ProjectReference Include="..\Trakt.NET\Trakt.NET.csproj" />
10-
<ProjectReference Include="..\shared\Trakt.NET.Utilities\Trakt.NET.Utilities.csproj" />
1110
</ItemGroup>
1211

1312
</Project>

src/libs/Trakt.NET.Extensions.TMDB/TraktTMDBExtensions.cs

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@ public static async Task<TMDBMovieImages> GetTMDBImagesAsync(this TraktMovieMini
88
return await Task.FromResult(new TMDBMovieImages());
99
}
1010

11-
public static async Task<TMDBMovieImages> GetTMDBImagesAsync(this TraktMovie traktMovie, CancellationToken cancellationToken = default)
11+
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktMovieMinimal traktMovie, CancellationToken cancellationToken = default)
1212
{
1313
// TODO
14-
return await Task.FromResult(new TMDBMovieImages());
14+
return await Task.FromResult(new TMDBVideos());
1515
}
1616

17-
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktMovieMinimal traktMovie, CancellationToken cancellationToken = default)
17+
public static async Task<TMDBMovieImages> GetTMDBImagesAsync(this TraktMovie traktMovie, CancellationToken cancellationToken = default)
1818
{
1919
// TODO
20-
return await Task.FromResult(new TMDBVideos());
20+
return await Task.FromResult(new TMDBMovieImages());
2121
}
2222

2323
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktMovie traktMovie, CancellationToken cancellationToken = default)
@@ -31,19 +31,19 @@ public static async Task<TMDBShowImages> GetTMDBImagesAsync(this TraktShowMinima
3131
// TODO
3232
return await Task.FromResult(new TMDBShowImages());
3333
}
34-
35-
public static async Task<TMDBShowImages> GetTMDBImagesAsync(this TraktShow traktShow, CancellationToken cancellationToken = default)
34+
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktShowMinimal traktShow, CancellationToken cancellationToken = default)
3635
{
3736
// TODO
38-
return await Task.FromResult(new TMDBShowImages());
37+
return await Task.FromResult(new TMDBVideos());
3938
}
4039

41-
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktShowMinimal traktShow, CancellationToken cancellationToken = default)
40+
public static async Task<TMDBShowImages> GetTMDBImagesAsync(this TraktShow traktShow, CancellationToken cancellationToken = default)
4241
{
4342
// TODO
44-
return await Task.FromResult(new TMDBVideos());
43+
return await Task.FromResult(new TMDBShowImages());
4544
}
4645

46+
4747
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktShow traktShow, CancellationToken cancellationToken = default)
4848
{
4949
// TODO
@@ -56,16 +56,16 @@ public static async Task<TMDBSeasonImages> GetTMDBImagesAsync(this TraktSeasonMi
5656
return await Task.FromResult(new TMDBSeasonImages());
5757
}
5858

59-
public static async Task<TMDBSeasonImages> GetTMDBImagesAsync(this TraktSeason traktSeason, CancellationToken cancellationToken = default)
59+
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktSeasonMinimal traktSeason, CancellationToken cancellationToken = default)
6060
{
6161
// TODO
62-
return await Task.FromResult(new TMDBSeasonImages());
62+
return await Task.FromResult(new TMDBVideos());
6363
}
6464

65-
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktSeasonMinimal traktSeason, CancellationToken cancellationToken = default)
65+
public static async Task<TMDBSeasonImages> GetTMDBImagesAsync(this TraktSeason traktSeason, CancellationToken cancellationToken = default)
6666
{
6767
// TODO
68-
return await Task.FromResult(new TMDBVideos());
68+
return await Task.FromResult(new TMDBSeasonImages());
6969
}
7070

7171
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktSeason traktSeason, CancellationToken cancellationToken = default)
@@ -80,16 +80,16 @@ public static async Task<TMDBEpisodeImages> GetTMDBImagesAsync(this TraktEpisode
8080
return await Task.FromResult(new TMDBEpisodeImages());
8181
}
8282

83-
public static async Task<TMDBEpisodeImages> GetTMDBImagesAsync(this TraktEpisode traktEpisode, CancellationToken cancellationToken = default)
83+
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktEpisodeMinimal traktEpisode, CancellationToken cancellationToken = default)
8484
{
8585
// TODO
86-
return await Task.FromResult(new TMDBEpisodeImages());
86+
return await Task.FromResult(new TMDBVideos());
8787
}
8888

89-
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktEpisodeMinimal traktEpisode, CancellationToken cancellationToken = default)
89+
public static async Task<TMDBEpisodeImages> GetTMDBImagesAsync(this TraktEpisode traktEpisode, CancellationToken cancellationToken = default)
9090
{
9191
// TODO
92-
return await Task.FromResult(new TMDBVideos());
92+
return await Task.FromResult(new TMDBEpisodeImages());
9393
}
9494

9595
public static async Task<TMDBVideos> GetTMDBVideosAsync(this TraktEpisode traktEpisode, CancellationToken cancellationToken = default)

src/libs/Trakt.NET/Internal/Constants.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using System.Net;
22
using System.Text.Json;
3-
using TraktNET.Utilities.Json;
43

54
namespace TraktNET
65
{

src/libs/Trakt.NET/Internal/Extensions/StreamExtensions.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
#if NET6_0_OR_GREATER
2-
using TraktNET.Utilities.Json;
3-
#else
1+
#if !NET6_0_OR_GREATER
42
using System.Text.Json;
53
#endif
64

src/libs/shared/Trakt.NET.Utilities/Json/LowerSnakeCaseJsonNamingPolicy.cs renamed to src/libs/Trakt.NET/Internal/Json/LowerSnakeCaseJsonNamingPolicy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
using System.Runtime.CompilerServices;
66
using System.Text.Json;
77

8-
namespace TraktNET.Utilities.Json
8+
namespace TraktNET
99
{
1010
public sealed class LowerSnakeCaseJsonNamingPolicy : JsonNamingPolicy
1111
{

src/libs/shared/Trakt.NET.Utilities/Json/IJsonSerializerContextFactory.cs renamed to src/libs/Trakt.NET/Internal/Json/SerializerContexts/IJsonSerializerContextFactory.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
#if NET6_0_OR_GREATER
22
using System.Text.Json.Serialization;
33

4-
namespace TraktNET.Utilities.Json
4+
namespace TraktNET
55
{
6-
public interface IJsonSerializerContextFactory
6+
internal interface IJsonSerializerContextFactory
77
{
88
JsonSerializerContext GetContext<TJsonObjectType>();
99
}

src/libs/shared/Trakt.NET.Utilities/Json/JsonContextSerializer.cs renamed to src/libs/Trakt.NET/Internal/Json/SerializerContexts/JsonContextSerializer.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
using System.Text.Json;
33
using System.Text.Json.Serialization;
44

5-
namespace TraktNET.Utilities.Json
5+
namespace TraktNET
66
{
7-
public static class JsonContextSerializer
7+
internal static class JsonContextSerializer
88
{
9-
public static async Task<TJsonObjectType?> DeserializeAsync<TJsonObjectType>(string factoryKey, Stream stream,
9+
internal static async Task<TJsonObjectType?> DeserializeAsync<TJsonObjectType>(string factoryKey, Stream stream,
1010
CancellationToken cancellationToken = default) where TJsonObjectType : class
1111
{
1212
JsonSerializerContext jsonSerializerContext = JsonSerializerContextFactoryRegistry.Get(factoryKey).GetContext<TJsonObjectType>();
@@ -15,7 +15,7 @@ public static class JsonContextSerializer
1515
jsonSerializerContext, cancellationToken).ConfigureAwait(false) as TJsonObjectType;
1616
}
1717

18-
public static async Task<IReadOnlyList<TJsonObjectType>?> DeserializeArrayAsync<TJsonObjectType>(string factoryKey, Stream stream,
18+
internal static async Task<IReadOnlyList<TJsonObjectType>?> DeserializeArrayAsync<TJsonObjectType>(string factoryKey, Stream stream,
1919
CancellationToken cancellationToken = default)
2020
{
2121
JsonSerializerContext jsonSerializerContext = JsonSerializerContextFactoryRegistry.Get(factoryKey).GetContext<TJsonObjectType>();

0 commit comments

Comments
 (0)