Merge pull request #231 from henrikfroehling/merge/release-1.1.0/GH-224

henrikfroehling · web-flow · commit f3c4e5bcca88 · 2021-03-16T00:44:12.000+01:00
Resolves GH-224
diff --git a/Source/Lib/Trakt.NET/Requests/Calendars/ACalendarRequest'1.cs b/Source/Lib/Trakt.NET/Requests/Calendars/ACalendarRequest'1.cs
@@ -49,8 +49,6 @@ public override IDictionary<string, object> GetUriPathParameters()
 
         public override void Validate()
         {
-            if (Days.HasValue && (Days.Value < 1 || Days.Value > 31))
-                throw new ArgumentOutOfRangeException(nameof(Days), "days must have a value between 1 and 31");
         }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllDVDMovies_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllDVDMovies_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetAllDVDMovies_Throws_API_Exception(
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetAllDVDMovies_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetMockClient(GET_ALL_DVD_MOVIES_URI,
-                                                           CALENDAR_DVD_MOVIES_JSON,
-                                                           startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarMovie>>> act = () => client.Calendar.GetAllDVDMoviesAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetAllDVDMoviesAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllMovies_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllMovies_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetAllMovies_Throws_API_Exception(Htt
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetAllMovies_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetMockClient(GET_ALL_MOVIES_URI,
-                                                           CALENDAR_ALL_MOVIES_JSON,
-                                                           startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarMovie>>> act = () => client.Calendar.GetAllMoviesAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetAllMoviesAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllNewShows_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllNewShows_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetAllNewShows_Throws_API_Exception(H
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetAllNewShows_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetMockClient($"{GET_ALL_NEW_SHOWS_URI}",
-                                                           CALENDAR_ALL_SHOWS_JSON,
-                                                           startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarShow>>> act = () => client.Calendar.GetAllNewShowsAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetAllNewShowsAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllSeasonPremieres_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllSeasonPremieres_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetAllSeasonPremieres_Throws_API_Exce
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetAllSeasonPremieres_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetMockClient(GET_ALL_SEASON_PREMIERES_URI,
-                                                           CALENDAR_ALL_SHOWS_JSON,
-                                                           startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarShow>>> act = () => client.Calendar.GetAllSeasonPremieresAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetAllSeasonPremieresAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllShows_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetAllShows_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetAllShows_Throws_API_Exception(Http
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetAllShows_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetMockClient(GET_ALL_SHOWS_URI,
-                                                           CALENDAR_ALL_SHOWS_JSON,
-                                                           startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarShow>>> act = () => client.Calendar.GetAllShowsAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetAllShowsAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserDVDMovies_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserDVDMovies_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetUserDVDMovies_Throws_API_Exception
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetUserDVDMovies_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetOAuthMockClient(GET_USER_DVD_MOVIES_URI,
-                                                                CALENDAR_DVD_MOVIES_JSON,
-                                                                startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarMovie>>> act = () => client.Calendar.GetUserDVDMoviesAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetUserDVDMoviesAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserMovies_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserMovies_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetUserMovies_Throws_API_Exception(Ht
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetUserMovies_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetOAuthMockClient(GET_USER_MOVIES_URI,
-                                                                CALENDAR_ALL_MOVIES_JSON,
-                                                                startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarMovie>>> act = () => client.Calendar.GetUserMoviesAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetUserMoviesAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserNewShows_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserNewShows_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetUserNewShows_Throws_API_Exception(
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetUserNewShows_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetOAuthMockClient(GET_USER_NEW_SHOWS_URI,
-                                                                CALENDAR_ALL_SHOWS_JSON,
-                                                                startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarShow>>> act = () => client.Calendar.GetUserNewShowsAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetUserNewShowsAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserSeasonPremieres_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserSeasonPremieres_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetUserSeasonPremieres_Throws_API_Exc
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetUserSeasonPremieres_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetOAuthMockClient(GET_USER_SEASON_PREMIERES_URI,
-                                                                CALENDAR_ALL_SHOWS_JSON,
-                                                                startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarShow>>> act = () => client.Calendar.GetUserSeasonPremieresAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetUserSeasonPremieresAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserShows_Tests.cs b/Source/Tests/Trakt.NET.Modules.Tests/TraktCalendarModule/TraktCalendarModuleTests_GetUserShows_Tests.cs
@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetUserShows_Throws_API_Exception(Htt
                 (exception.GetType() == exceptionType).Should().BeTrue();
             }
         }
-
-        [Fact]
-        public void Test_TraktCalendarModule_GetUserShows_ArgumentExceptions()
-        {
-            TraktClient client = TestUtility.GetOAuthMockClient(GET_USER_SHOWS_URI,
-                                                                CALENDAR_ALL_SHOWS_JSON,
-                                                                startDate: START_DATE, endDate: END_DATE);
-
-            Func<Task<TraktListResponse<ITraktCalendarShow>>> act = () => client.Calendar.GetUserShowsAsync(null, 0);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-
-            act = () => client.Calendar.GetUserShowsAsync(null, 32);
-            act.Should().Throw<ArgumentOutOfRangeException>();
-        }
     }
 }
diff --git a/Source/Tests/Trakt.NET.Requests.Tests/Calendars/ACalendarRequest'1_Tests.cs b/Source/Tests/Trakt.NET.Requests.Tests/Calendars/ACalendarRequest'1_Tests.cs

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,6 @@ public override IDictionary<string, object> GetUriPathParameters()`
`49`	`49`
`50`	`50`	`public override void Validate()`
`51`	`51`	`{`
`52`		`- if (Days.HasValue && (Days.Value < 1 \|\| Days.Value > 31))`
`53`		`- throw new ArgumentOutOfRangeException(nameof(Days), "days must have a value between 1 and 31");`
`54`	`52`	`}`
`55`	`53`	`}`
`56`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -352,19 +352,5 @@ public async Task Test_TraktCalendarModule_GetAllDVDMovies_Throws_API_Exception(`
`352`	`352`	`(exception.GetType() == exceptionType).Should().BeTrue();`
`353`	`353`	`}`
`354`	`354`	`}`
`355`		`-`
`356`		`- [Fact]`
`357`		`- public void Test_TraktCalendarModule_GetAllDVDMovies_ArgumentExceptions()`
`358`		`- {`
`359`		`- TraktClient client = TestUtility.GetMockClient(GET_ALL_DVD_MOVIES_URI,`
`360`		`- CALENDAR_DVD_MOVIES_JSON,`
`361`		`- startDate: START_DATE, endDate: END_DATE);`
`362`		`-`
`363`		`- Func<Task<TraktListResponse<ITraktCalendarMovie>>> act = () => client.Calendar.GetAllDVDMoviesAsync(null, 0);`
`364`		`- act.Should().Throw<ArgumentOutOfRangeException>();`
`365`		`-`
`366`		`- act = () => client.Calendar.GetAllDVDMoviesAsync(null, 32);`
`367`		`- act.Should().Throw<ArgumentOutOfRangeException>();`
`368`		`- }`
`369`	`355`	`}`
`370`	`356`	`}`