code cosmetics

Author: henrypp

src/db.c

@@ -3,19 +3,15 @@
 
 #include "global.h"
 
-_Success_ (NT_SUCCESS (return))
-NTSTATUS _app_db_initialize (
+_Success_ (SUCCEEDED (return))
+HRESULT _app_db_initialize (
 	_Out_ PDB_INFORMATION db_info,
 	_In_ BOOLEAN is_reader
 )
 {
-	NTSTATUS status;
-
 	RtlZeroMemory (db_info, sizeof (DB_INFORMATION));
 
-	status = _r_xml_initializelibrary (&db_info->xml_library, is_reader);
-
-	return status;
+	return _r_xml_initializelibrary (&db_info->xml_library, is_reader);
 }
 
 VOID _app_db_destroy (

src/db.h

@@ -68,8 +68,8 @@ static const BYTE profile2_fourcc_old[] = {
 #define PROFILE2_SHA256_LENGTH 32UL
 #define PROFILE2_HEADER_LENGTH (PROFILE2_FOURCC_LENGTH + PROFILE2_SHA256_LENGTH)
 
-_Success_ (NT_SUCCESS (return))
-NTSTATUS _app_db_initialize (
+_Success_ (SUCCEEDED (return))
+HRESULT _app_db_initialize (
 	_Out_ PDB_INFORMATION db_info,
 	_In_ BOOLEAN is_reader
 );

src/profile.c

@@ -1709,8 +1709,8 @@ NTSTATUS _app_profile_load (
 )
 {
 	DB_INFORMATION db_info;
-	NTSTATUS status;
 	BOOLEAN is_update;
+	NTSTATUS status;
 
 	status = _app_db_initialize (&db_info, TRUE);
 
@@ -1790,8 +1790,8 @@ NTSTATUS _app_profile_save (
 {
 	DB_INFORMATION db_info;
 	LONG64 timestamp;
-	NTSTATUS status;
 	BOOLEAN is_backuprequired = FALSE;
+	NTSTATUS status;
 
 	status = _app_db_initialize (&db_info, FALSE);