Skip to content

Commit 9405329

Browse files
authored
Merge pull request #1762 from relokin/catalogue-fixes2
[catalogue] Fix AArch64 ifetch typing and VMSA fault-handler expectations This PR fixes a set of issues in the AArch64 catalogue tests: - fix register size mismatches in aarch64-ifetch WRC tests - add explicit types for registers that hold labels in aarch64-ifetch tests - stop checking for faults in aarch64-VMSA tests when a fault handler is present The changes are limited to catalogue litmus tests: - catalogue/aarch64-ifetch/tests/... - catalogue/aarch64-VMSA/tests/...
2 parents ffad269 + eadc4c2 commit 9405329

File tree

71 files changed

+92
-104
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+92
-104
lines changed

catalogue/aarch64-VMSA/shelf.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@
112112
"tests/F2.mod.litmus",
113113
"tests/F2S+DSB-ETS.litmus",
114114
"tests/F2S.litmus",
115-
"tests/F2Sdb+DSB-ETS.litmus",
116115
"tests/F2V.litmus",
117116
"tests/F3.litmus",
118117
"tests/F4.litmus",
@@ -802,7 +801,6 @@
802801
"tests/needTLBI2.litmus",
803802
"tests/permchange-M-shoot+DMB.ISH.litmus",
804803
"tests/newlob/LB+dmb.sy+acq-HU.litmus",
805-
"tests/newlob/LB+dmb.sy+dmb.sy-HU.litmus",
806804
"tests/newlob/LB+dmb.sy+dsb.sy-HU.litmus",
807805
"tests/newlob/LB+dmb.sy+dsb.sy-isb-HU.litmus",
808806
"tests/newlob/LB+dmb.sy+pickaddr-po-HUdb.litmus",

catalogue/aarch64-VMSA/tests/@armv8-a

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ F2.mod-with-type+BBM2.litmus
9292
F2.mod.litmus
9393
F2S+DSB-ETS.litmus
9494
F2S.litmus
95-
F2Sdb+DSB-ETS.litmus
9695
F2V.litmus
9796
F3.litmus
9897
F4.litmus

catalogue/aarch64-VMSA/tests/CASAL+FAIL+FH.litmus

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ Variant=vmsa
1616
| L1: | ;
1717
| LDR W5,[X2] | ;
1818

19-
exists (fault(P1:L0,x) /\ 1:X5=0)
19+
exists(1:X9=label:"P1:L1" /\ 1:X5=0)

catalogue/aarch64-VMSA/tests/CASAL+FAIL2+FH.litmus

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,4 @@ Variant=vmsa
2020
MOV W5,#1 | L1: | ;
2121
STR W5,[X6] | LDR W5,[X2] | ;
2222

23-
exists (fault(P1:L0,x) /\ 1:X5=0)
23+
exists (1:X9=label:"P1:L1" /\ 1:X5=0)

catalogue/aarch64-VMSA/tests/F2Sdb+DSB-ETS.litmus

Lines changed: 0 additions & 14 deletions
This file was deleted.

catalogue/aarch64-VMSA/tests/newlob/@all

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
LB+dmb.sy+acq-HU.litmus
2-
LB+dmb.sy+dmb.sy-HU.litmus
32
LB+dmb.sy+dsb.sy-HU.litmus
43
LB+dmb.sy+dsb.sy-isb-HU.litmus
54
LB+dmb.sy+pickaddr-po-HUdb.litmus

catalogue/aarch64-VMSA/tests/newlob/LB+dmb.sy+dmb.sy-HU.litmus

Lines changed: 0 additions & 16 deletions
This file was deleted.

catalogue/aarch64-VMSA/tests/newlob/S+dsb.sy-tlbi-dsb.sy+ctrl.litmus

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ Variant=vmsa
1515
MOV W2,#1 | L0: | ;
1616
STR W2,[X3] | | ;
1717

18-
exists (1:X2=1 /\ not (fault(P1,x,MMU:Permission)))
18+
exists (1:X2=1 /\ 1:X9=0)

catalogue/aarch64-VMSA/tests/order-via-faults/MP-via_fault_STLR.litmus

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ Variant=vmsa
77
1:X3=y; 1:X1=x; 1:X8=z;
88
}
99
P0 | P1 | P1.F ;
10-
MOV X7,#1 | LDR W2,[X3] | ADR X9,L0 ;
10+
MOV W7,#1 | LDR W2,[X3] | ADR X9,L0 ;
1111
STR W7,[X8] | MOV W0,#1 | MSR ELR_EL1,X9 ;
1212
STLR W7,[X3] | STLR W0,[X1] | LDR W10,[X8] ;
1313
| | ERET ;
1414
| L0: | ;
1515

16-
exists (1:X2=1 /\ 1:X10=0 /\ fault(P1))
16+
exists (1:X2=1 /\ 1:X10=0 /\ 1:X9=label:"P1:L0")

catalogue/aarch64-VMSA/tests/order-via-faults/R-via_fault_STR.litmus

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ Variant=vmsa
77
1:X3=y; 1:X1=x; 1:X8=z;
88
}
99
P0 | P1 | P1.F ;
10-
MOV X7,#1 | MOV W2,#2 | ADR X9,L0 ;
10+
MOV W7,#1 | MOV W2,#2 | ADR X9,L0 ;
1111
STR W7,[X8] | STR W2,[X3] | MSR ELR_EL1,X9 ;
1212
STLR W7,[X3] | DMB ST | LDR W10,[X8] ;
1313
| STR W0,[X1] | ERET ;
1414
| L0: | ;
1515

16-
exists ([y]=2 /\ 1:X10=0 /\ fault(P1))
16+
exists ([y]=2 /\ 1:X10=0 /\ 1:X9=label:"P1:L0")

0 commit comments

Comments
 (0)